From: Cornelia Huck <cohuck@redhat.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org
Subject: Re: [PATCH v3] target/s390x/kvm: Enable adapter interruption suppression again
Date: Mon, 20 Jan 2020 17:29:18 +0100 [thread overview]
Message-ID: <20200120172918.26d5db9b.cohuck@redhat.com> (raw)
In-Reply-To: <a4606ae6-1c74-d584-4bf1-9e4d11bb7a8e@linux.ibm.com>
On Mon, 20 Jan 2020 11:23:37 -0500
Matthew Rosato <mjrosato@linux.ibm.com> wrote:
> On 1/20/20 8:24 AM, Thomas Huth wrote:
> > The AIS feature has been disabled late in the v2.10 development cycle since
> > there were some issues with migration (see commit 3f2d07b3b01ea61126b -
> > "s390x/ais: for 2.10 stable: disable ais facility"). We originally wanted
> > to enable it again for newer machine types, but apparently we forgot to do
> > this so far. Let's do it for the new s390-ccw-virtio-5.0 machine now.
> >
> > While at it, also add a more verbose comment why we need the *_allowed()
> > wrappers in s390-virtio-ccw.c.
> >
> > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1756946
> > Reviewed-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
>
> Took it for a spin with vfio-pci. With this patch applied, I see the
> appropriate change reflected in guest /proc/cpuinfo. I did some tracing
> and see the expected behavior changes (ex: hits in host
> kvm_s390_injrect_airq that show suppression occurring). Data transfer
> tests worked fine. Also sanity-tested that ais=off behaves as expected.
>
> Looks good to me.
>
Excellent, thanks for testing!
Should I add a Tested-by: ?
next prev parent reply other threads:[~2020-01-20 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 13:24 [PATCH v3] target/s390x/kvm: Enable adapter interruption suppression again Thomas Huth
2020-01-20 16:23 ` Matthew Rosato
2020-01-20 16:29 ` Cornelia Huck [this message]
2020-01-20 16:32 ` Matthew Rosato
2020-01-20 16:24 ` Cornelia Huck
2020-01-20 17:27 ` Cornelia Huck
2020-01-21 14:33 ` Matthew Rosato
2020-01-21 14:46 ` Cornelia Huck
2020-01-21 15:22 ` Thomas Huth
2020-01-21 16:05 ` Matthew Rosato
2020-01-21 16:11 ` Thomas Huth
2020-01-21 16:12 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120172918.26d5db9b.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.