From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6E1C2D0CE for ; Tue, 21 Jan 2020 09:32:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1D4D22522 for ; Tue, 21 Jan 2020 09:32:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rtcJ+LQl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728712AbgAUJcG (ORCPT ); Tue, 21 Jan 2020 04:32:06 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55357 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727360AbgAUJcF (ORCPT ); Tue, 21 Jan 2020 04:32:05 -0500 Received: by mail-wm1-f68.google.com with SMTP id q9so2138451wmj.5 for ; Tue, 21 Jan 2020 01:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=imtrsyE4PqkfOuBH2bEU5/ycShpe5DgMQpGEtomyMa0=; b=rtcJ+LQlDZ/dhGfo9Iu5OJd4+HKMy2yzD9iSGdalzOoIEncUjzsz5/aNNTd5RjsSc8 zO8R7IWeVumQmIJtNgo4RVZt7gUhd5yZRRBQqVDryoKs8BU04+PpGfSZJNvnjsH/62yj utNq7GGLPGyTxTb1yb3mltp6nzJAjgAWU6qQKOTamwB12SgQZpUurDCVdShHDY4zSwRt 27hnYDJCXhMMgdvO1mW+7T9xCr4uphzvbjrusTEF0ylfATpdKENfYomQu6F+lwzn6RUS UpDbh4WVRvpRmqp5fb/B2A+GM9Tidwg6k1/Hgf4wLH/tybPmLM/Hd8ve+be8A6ZldBH9 pQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=imtrsyE4PqkfOuBH2bEU5/ycShpe5DgMQpGEtomyMa0=; b=DBU9nS8F9D0wfL7hE5bDdfAkmEoCXB104JX2eBulte9LY2twiYU3xyrggpKrCf6R9O UWbGRlCoLsNm608CVQgcw/uHQDcM+DOT53EB5RstKeik3OwUF9iyrx3IEEm3AX0XRtRb M0sXOzrL+F+deJBG097KE/3TrnWljBBX8A/EMHl/Lt91uVe48O0F3Y68NAVecgwkdX5S 2UWmqxvczaizRXr0eWgBNnX3yUJRXV6UasGLJ3Kj+QrbC5XIy5tTPQAW93OMjMXdBt/D ofNNo34nGghij58WaFmy2GElxXJdD4OiuvugIGgPG98jk0PN8qVQ7Ltv8+O3z0px1XWr ttag== X-Gm-Message-State: APjAAAVBo2N9aCk5xM17i7kyDADalyp5ptaHsbb5yvTidzND1U1bhtVQ u1sa5rihQlSRYdr4Eb1jdH8utg== X-Google-Smtp-Source: APXvYqxXLTNXCnqXFHWAqOhNn4BqFUdupPBlV6/fm+9Ho9HF0rYCv/gYw3ZqBCY91j9ikIx2kYRjiw== X-Received: by 2002:a1c:a584:: with SMTP id o126mr3199652wme.163.1579599122625; Tue, 21 Jan 2020 01:32:02 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id g7sm51210925wrq.21.2020.01.21.01.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:32:01 -0800 (PST) Date: Tue, 21 Jan 2020 09:31:58 +0000 From: Quentin Perret To: Lukasz Luba Cc: Dietmar Eggemann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Chris.Redpath@arm.com, ionela.voinescu@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, kernel-team@android.com Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093158.GA154455@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Monday 20 Jan 2020 at 18:38:41 (+0000), Lukasz Luba wrote: > I think we could avoid this additional argument 'cpumask'. I have > checked the cpufreq_cpu_get function, which should do be good for this: > > ---------->8------------------------- > static int _get_sharing_cpus(struct device *cpu_dev, struct cpumask *span) > { > struct cpufreq_policy *policy; > > policy = cpufreq_cpu_get(cpu_dev->id); > if (policy) { > cpumask_copy(span, policy->cpus); That should be with 'policy->related_cpus', but yes if the policy cpumasks have been populated this approach is OK I think. > cpufreq_cpu_put(policy); > return 0; > } else { > return -EINVAL; > } > } > --------------------------8<------------------------------- Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19757C2D0CE for ; Tue, 21 Jan 2020 09:32:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF36422522 for ; Tue, 21 Jan 2020 09:32:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KqiYrgEQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="rtcJ+LQl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF36422522 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TdxNuHbdB9DyV4UCjShjjn5mPK7KmFg1hcjXDnkt+bs=; b=KqiYrgEQUUr+Ao 9od5shWQdblY2THGup3A8aPlwspLCn/8aRSdRYA+0A67BDhebTJzcTc0jOGUkLnRful6WMqHtnMTc RsKrhd4tGWetdUL2XVH6nqbHHWNo3qrPzePe1RI5VXB5O6tujiQIDRPtxnP/rK2YqlvLZwMubYaNP SPJ80H9tEI9xbyRDNEjYAHkHAmr1+2oR/j0LfLBB19CKYx10MO9GhroBjW54OK58xc7xTNtzHYpcd AZQAXaQoGERPLDV1xIuHSWXKWYnh4HU5pDvuZ/K7Qpl4h/0QAIhVzzlzTfyZFmVQ6YL6diovzOj6H h9s9asgX/uaa9R4D6VpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itptL-0007nq-Uq; Tue, 21 Jan 2020 09:32:11 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itptF-0007md-Vn for linux-mediatek@lists.infradead.org; Tue, 21 Jan 2020 09:32:10 +0000 Received: by mail-wm1-x342.google.com with SMTP id p17so2192576wma.1 for ; Tue, 21 Jan 2020 01:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=imtrsyE4PqkfOuBH2bEU5/ycShpe5DgMQpGEtomyMa0=; b=rtcJ+LQlDZ/dhGfo9Iu5OJd4+HKMy2yzD9iSGdalzOoIEncUjzsz5/aNNTd5RjsSc8 zO8R7IWeVumQmIJtNgo4RVZt7gUhd5yZRRBQqVDryoKs8BU04+PpGfSZJNvnjsH/62yj utNq7GGLPGyTxTb1yb3mltp6nzJAjgAWU6qQKOTamwB12SgQZpUurDCVdShHDY4zSwRt 27hnYDJCXhMMgdvO1mW+7T9xCr4uphzvbjrusTEF0ylfATpdKENfYomQu6F+lwzn6RUS UpDbh4WVRvpRmqp5fb/B2A+GM9Tidwg6k1/Hgf4wLH/tybPmLM/Hd8ve+be8A6ZldBH9 pQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=imtrsyE4PqkfOuBH2bEU5/ycShpe5DgMQpGEtomyMa0=; b=oJ9XiuGHKczWl2jlZ8RNfPi+ljpuCE3c+C+UerKenwtsAW4dRBUC5piUDdCn9M23h8 QHp2PDXIaBbah12Tr9cBIxVqqiwHJXJFvKImEhqauS9yzmgN4cZ/X2bfiykAXO48hYMa 0DxqZy9dKBndS24FVBpy8Vo1GUHSA4Cee+gF7+KkX/n5locYwcRWgVKjMrz2dtyAHQSk VQyKPlmD3BQlG3nMCbKpzW03Y8O9jI+nNPIBbtOi4YA3BfLr0oVu0svuHJuBCelLDXBd uzgvJUVsZKmtedyJvf2ryxqKGKF1dsdUOwEBnW3yQ+HJ+r9N1jQvcOLjJOHVaxqLp1RD mqCQ== X-Gm-Message-State: APjAAAXGVS/wMoqtACO2yEnaf3Ir9Y/QfPNFIgh3FwbUOVEg4oQCE70S B4i2gIANcBu+ls2z6HxTezmPzA== X-Google-Smtp-Source: APXvYqxXLTNXCnqXFHWAqOhNn4BqFUdupPBlV6/fm+9Ho9HF0rYCv/gYw3ZqBCY91j9ikIx2kYRjiw== X-Received: by 2002:a1c:a584:: with SMTP id o126mr3199652wme.163.1579599122625; Tue, 21 Jan 2020 01:32:02 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id g7sm51210925wrq.21.2020.01.21.01.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:32:01 -0800 (PST) Date: Tue, 21 Jan 2020 09:31:58 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093158.GA154455@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200121_013206_050429_7506ABF6 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com, mgorman@suse.de, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, ionela.voinescu@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Monday 20 Jan 2020 at 18:38:41 (+0000), Lukasz Luba wrote: > I think we could avoid this additional argument 'cpumask'. I have > checked the cpufreq_cpu_get function, which should do be good for this: > > ---------->8------------------------- > static int _get_sharing_cpus(struct device *cpu_dev, struct cpumask *span) > { > struct cpufreq_policy *policy; > > policy = cpufreq_cpu_get(cpu_dev->id); > if (policy) { > cpumask_copy(span, policy->cpus); That should be with 'policy->related_cpus', but yes if the policy cpumasks have been populated this approach is OK I think. > cpufreq_cpu_put(policy); > return 0; > } else { > return -EINVAL; > } > } > --------------------------8<------------------------------- Thanks, Quentin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Perret Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Date: Tue, 21 Jan 2020 09:31:58 +0000 Message-ID: <20200121093158.GA154455@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Lukasz Luba Cc: Dietmar Eggemann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Chris.Redpath@arm.com, ionela.voinescu@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix. List-Id: linux-omap@vger.kernel.org On Monday 20 Jan 2020 at 18:38:41 (+0000), Lukasz Luba wrote: > I think we could avoid this additional argument 'cpumask'. I have > checked the cpufreq_cpu_get function, which should do be good for this: > > ---------->8------------------------- > static int _get_sharing_cpus(struct device *cpu_dev, struct cpumask *span) > { > struct cpufreq_policy *policy; > > policy = cpufreq_cpu_get(cpu_dev->id); > if (policy) { > cpumask_copy(span, policy->cpus); That should be with 'policy->related_cpus', but yes if the policy cpumasks have been populated this approach is OK I think. > cpufreq_cpu_put(policy); > return 0; > } else { > return -EINVAL; > } > } > --------------------------8<------------------------------- Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F29C2D0CE for ; Tue, 21 Jan 2020 09:32:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3204C22522 for ; Tue, 21 Jan 2020 09:32:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tglQISl/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="rtcJ+LQl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3204C22522 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v9gMkOLoZy27401AHpS7UDGfCIMxmJb1PzQwZeGveTk=; b=tglQISl/6XPyL1 vBhGLGVR5cAWoGFOq6ZIB+Nwji4Cn1abKTOUQYTW49LMAB5vE0mhGdmxhzvkN67SbhDs2f86VZb1E 0IPcMCvRvz2qs28/2iq6q8wrCVY0a+W6q4+0l2iSYVzZEFNVO5SGaxThQe0JPhwZ/EbNr6c7oxo03 U4i4/FFb/Rr0jecTJXuOj9/DNs4eCe1Pwlez1e6GzALNVXgudmXe3JHuaPqAZaIu/GRcxn49ETSx5 Y1wILc+o24+aknDj/mG7lJ0sAZHjwuMx8tXDzmSqENGufgCqI+/DPXr0vVSX0mboOBkoXsvBpq2b7 EF+WYDEQ5nbdHt+ORm2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itptM-0007oZ-TF; Tue, 21 Jan 2020 09:32:12 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itptG-0007mc-18 for linux-arm-kernel@lists.infradead.org; Tue, 21 Jan 2020 09:32:11 +0000 Received: by mail-wm1-x344.google.com with SMTP id p17so2196603wmb.0 for ; Tue, 21 Jan 2020 01:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=imtrsyE4PqkfOuBH2bEU5/ycShpe5DgMQpGEtomyMa0=; b=rtcJ+LQlDZ/dhGfo9Iu5OJd4+HKMy2yzD9iSGdalzOoIEncUjzsz5/aNNTd5RjsSc8 zO8R7IWeVumQmIJtNgo4RVZt7gUhd5yZRRBQqVDryoKs8BU04+PpGfSZJNvnjsH/62yj utNq7GGLPGyTxTb1yb3mltp6nzJAjgAWU6qQKOTamwB12SgQZpUurDCVdShHDY4zSwRt 27hnYDJCXhMMgdvO1mW+7T9xCr4uphzvbjrusTEF0ylfATpdKENfYomQu6F+lwzn6RUS UpDbh4WVRvpRmqp5fb/B2A+GM9Tidwg6k1/Hgf4wLH/tybPmLM/Hd8ve+be8A6ZldBH9 pQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=imtrsyE4PqkfOuBH2bEU5/ycShpe5DgMQpGEtomyMa0=; b=tGnOCaeF7uuWct7aKvTbmKonx+UBtxy/TED70m1O6Ifm+k8AhXY08KHcqS3LG3bqO4 uGM7RlOwJcVLkEacSFMI2iINg4vRU0KIbAA5M03CMxa8bK2B2rHwyEsAbHCjI5FPq0Tn z0AwMBGDA7dvn0xW5quLS95wmVQFjPXNrbiUjbFKU0DGGWFQWiM39DQrXt/CPReLTbwG BsDNOr3V4j8vtunEGkPbaf98wTCrqrS9VKYRQjkpYfPRIon5y/gy5g+mpmC75g35rYzI qtiqvfa+vzoX5jhYieuhrWZgVM11rvYagbDSApu0srdMfh2LloMKIk2vEr+s9aax/tSI O0OA== X-Gm-Message-State: APjAAAWbtVIUIPxtQPbXMhT/nno/FkxHeIWYzhGWrN2cBtVC33NqRfG9 kfb78VST8FL1UlzkcjBecZXRHA== X-Google-Smtp-Source: APXvYqxXLTNXCnqXFHWAqOhNn4BqFUdupPBlV6/fm+9Ho9HF0rYCv/gYw3ZqBCY91j9ikIx2kYRjiw== X-Received: by 2002:a1c:a584:: with SMTP id o126mr3199652wme.163.1579599122625; Tue, 21 Jan 2020 01:32:02 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id g7sm51210925wrq.21.2020.01.21.01.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:32:01 -0800 (PST) Date: Tue, 21 Jan 2020 09:31:58 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093158.GA154455@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200121_013206_068473_813DFB77 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com, mgorman@suse.de, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, ionela.voinescu@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 20 Jan 2020 at 18:38:41 (+0000), Lukasz Luba wrote: > I think we could avoid this additional argument 'cpumask'. I have > checked the cpufreq_cpu_get function, which should do be good for this: > > ---------->8------------------------- > static int _get_sharing_cpus(struct device *cpu_dev, struct cpumask *span) > { > struct cpufreq_policy *policy; > > policy = cpufreq_cpu_get(cpu_dev->id); > if (policy) { > cpumask_copy(span, policy->cpus); That should be with 'policy->related_cpus', but yes if the policy cpumasks have been populated this approach is OK I think. > cpufreq_cpu_put(policy); > return 0; > } else { > return -EINVAL; > } > } > --------------------------8<------------------------------- Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE4CC33CAF for ; Wed, 22 Jan 2020 08:22:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15B9724655 for ; Wed, 22 Jan 2020 08:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="rtcJ+LQl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15B9724655 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 452756F3FA; Wed, 22 Jan 2020 08:21:30 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44B4E6EC18 for ; Tue, 21 Jan 2020 09:32:04 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id p17so2196604wmb.0 for ; Tue, 21 Jan 2020 01:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=imtrsyE4PqkfOuBH2bEU5/ycShpe5DgMQpGEtomyMa0=; b=rtcJ+LQlDZ/dhGfo9Iu5OJd4+HKMy2yzD9iSGdalzOoIEncUjzsz5/aNNTd5RjsSc8 zO8R7IWeVumQmIJtNgo4RVZt7gUhd5yZRRBQqVDryoKs8BU04+PpGfSZJNvnjsH/62yj utNq7GGLPGyTxTb1yb3mltp6nzJAjgAWU6qQKOTamwB12SgQZpUurDCVdShHDY4zSwRt 27hnYDJCXhMMgdvO1mW+7T9xCr4uphzvbjrusTEF0ylfATpdKENfYomQu6F+lwzn6RUS UpDbh4WVRvpRmqp5fb/B2A+GM9Tidwg6k1/Hgf4wLH/tybPmLM/Hd8ve+be8A6ZldBH9 pQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=imtrsyE4PqkfOuBH2bEU5/ycShpe5DgMQpGEtomyMa0=; b=cS8FQJpK0k9akITYfAfDXAi1fBAxyBYheBDU2QRHav4MvLNpgiJA/oOGST7+dSwFp2 6hnUNIA2L7Zp/oyMpKbTSuKWGv+lmmIIPplInCZ+7qHUH2SdvQPGoMYPKOYKfpZXaSWs FMNj16881b+5bsQYgx4Owfet6HWZ/SvfAUgwz76cHBAhkNVw1h3NVdP1z6eBglRgJzgG EUxdsxq9/4oEpiQygnXXi/kQtxSX5r42hQP7WNhfXRCT+6x89UTU16GPuq44xeXqmwUJ rLGCsY6nhej137tP1zMbm0Wre3Sa7EsrDNl0aEoE2rS/wuCp0BGfoFDOnX2WlJtvkc45 VTIQ== X-Gm-Message-State: APjAAAW9oLK4xcwddb+zFbF4M8rG7Pf/xkFavhGO6+gn12OjY/bzdEXZ B3LQ4wrzAWlZii7mEtYseXAtRg== X-Google-Smtp-Source: APXvYqxXLTNXCnqXFHWAqOhNn4BqFUdupPBlV6/fm+9Ho9HF0rYCv/gYw3ZqBCY91j9ikIx2kYRjiw== X-Received: by 2002:a1c:a584:: with SMTP id o126mr3199652wme.163.1579599122625; Tue, 21 Jan 2020 01:32:02 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id g7sm51210925wrq.21.2020.01.21.01.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:32:01 -0800 (PST) Date: Tue, 21 Jan 2020 09:31:58 +0000 From: Quentin Perret To: Lukasz Luba Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093158.GA154455@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Wed, 22 Jan 2020 08:21:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com, mgorman@suse.de, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, Dietmar Eggemann , linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, ionela.voinescu@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Monday 20 Jan 2020 at 18:38:41 (+0000), Lukasz Luba wrote: > I think we could avoid this additional argument 'cpumask'. I have > checked the cpufreq_cpu_get function, which should do be good for this: > > ---------->8------------------------- > static int _get_sharing_cpus(struct device *cpu_dev, struct cpumask *span) > { > struct cpufreq_policy *policy; > > policy = cpufreq_cpu_get(cpu_dev->id); > if (policy) { > cpumask_copy(span, policy->cpus); That should be with 'policy->related_cpus', but yes if the policy cpumasks have been populated this approach is OK I think. > cpufreq_cpu_put(policy); > return 0; > } else { > return -EINVAL; > } > } > --------------------------8<------------------------------- Thanks, Quentin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel