From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D858C2D0CE for ; Tue, 21 Jan 2020 09:38:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F47E24654 for ; Tue, 21 Jan 2020 09:38:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="I4Il4xqb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728826AbgAUJiC (ORCPT ); Tue, 21 Jan 2020 04:38:02 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:36079 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbgAUJiC (ORCPT ); Tue, 21 Jan 2020 04:38:02 -0500 Received: by mail-wr1-f68.google.com with SMTP id z3so2373092wru.3 for ; Tue, 21 Jan 2020 01:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=I4Il4xqb/mQRJaa0qSSl+Y25gZ18e057wP1tdP0lh2yLeaVpX0hadSOR4cl/LQpB3Q tyaDpcGYEDRokttwYZKiVcZfJVF8EHoSYV8AeT5Pk8Cx7E9Px1VKdhTcXR1aAUSJd42D xFOr6MeGSxv5TF/P/YEky3SS2IZFj68f7cxUiU1OZ4UxuYB744pGOuVT1Fv5ZBgPKRCQ 7lN+SeGd90TfRO9gjPQRhJKb/pkMVZLlA3k0gUeRo6+ZVDTta1IW1eGaQBVEL1GveVLC n0vz510kYT0OpN/IyanOQzCHQTHpjRTMgbVeaY/5N811ccD6PckCAVfLKOa3fN1tAM5n aJ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=ROgKz8bpoCwnR1H/rJE04BDVh/4y/IkOSeOUKU4N1wO09AZjJdu1L3lXHsaOZeLgJr SbhYCf9TZIH52hZyGDxjqjL5VWzJ/d8uCFNwBC/3+4JZ9RTsTByJvdBhhi0UkIEVQ6xb SVeBR3s+v1ipa4L2ySKI6gsMeTYaOZqyadge6bGXaRKWiWedfoIQIfyZGxx1dtLQaQDz gbQ/6wpG5v5JWvjSkZNkpdsUOEmk65AQQx6KA0h32nI78I6w4CTgSiRHrgthlp3Pq8jl hpEr1NonHoyiMpJXtfAkHYojE0rIEkNlcny/otg15Dj1nue/oe8EQEXG8Bhqz9ruBN1Q XHVA== X-Gm-Message-State: APjAAAXbTQzTS5lOwdnJGKT2+j8Zr7Fsb+XACeVBuXhcCNRFHn61UrfR fdiZM3bPLGN2RccWZvh32wNSag== X-Google-Smtp-Source: APXvYqzNPRBGH9fYa6XMUb9Kcbd+L9DaQWdS1c4YXNu4dlR3oazpTgiDZXxcGp6bVMzhgy2FLbeDYg== X-Received: by 2002:adf:dfc2:: with SMTP id q2mr4336811wrn.251.1579599479951; Tue, 21 Jan 2020 01:37:59 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id u22sm54210033wru.30.2020.01.21.01.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:37:59 -0800 (PST) Date: Tue, 21 Jan 2020 09:37:55 +0000 From: Quentin Perret To: Dietmar Eggemann Cc: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Chris.Redpath@arm.com, ionela.voinescu@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, kernel-team@android.com Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093755.GA157387@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote: > True. But then we hard-code that a CPU device performance domain can > only be a frequency domain (which is true today). > > The task scheduler (build_perf_domains()) and thermal are already using > cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework > would too for CPU devices. I assume that could work with a couple of > adaptations in Documentation/power/energy-model.rst. Agreed, and if one day we have a real use case where the pd mask and the cpufreq policy mask need to be different, we'll do the necessary changes. But until then I don't see a reason to object to Lukasz' proposal. So +1 from me. Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C318DC2D0CE for ; Tue, 21 Jan 2020 09:38:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97C7224654 for ; Tue, 21 Jan 2020 09:38:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LLhxQ56+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="I4Il4xqb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97C7224654 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b4MAAo5AzdvkkBCe1HzLrweMNsU4pkILDvoG+0lOlP8=; b=LLhxQ56+VHpEc6 tcKrFzq1yyWgu4uhHxJn9Z5cKmbteuQMBiy5fXnSKahBywal+E75of6GUoP+OGhJlljz144fLkLw+ cylcA1YxsCDT8ntGgGhXQ6VNDiWM7AZzTxuucffi4FzeDWgOfbrcFEiZLIVl4reI7loUneblXHH0W YwRi3Pl/qSJDF2tbDIKdwVwwmB1hReh+pkJtIHJUs3BkI/oivOFMedkWd/DFLNbKacqN8Uo1VD9pp zQyWeCCjnwK+AkCBKWoYkl8UGaYgrbVcmnE24p7KPZIVUb/68oGb5bYL0A+r17J4Dd+Ls0rw/eePc raKGmDDW1jYuZlgmSJ9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itpz2-0001W9-TD; Tue, 21 Jan 2020 09:38:04 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itpz0-0001VJ-2O for linux-mediatek@lists.infradead.org; Tue, 21 Jan 2020 09:38:03 +0000 Received: by mail-wr1-x444.google.com with SMTP id j42so2298400wrj.12 for ; Tue, 21 Jan 2020 01:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=I4Il4xqb/mQRJaa0qSSl+Y25gZ18e057wP1tdP0lh2yLeaVpX0hadSOR4cl/LQpB3Q tyaDpcGYEDRokttwYZKiVcZfJVF8EHoSYV8AeT5Pk8Cx7E9Px1VKdhTcXR1aAUSJd42D xFOr6MeGSxv5TF/P/YEky3SS2IZFj68f7cxUiU1OZ4UxuYB744pGOuVT1Fv5ZBgPKRCQ 7lN+SeGd90TfRO9gjPQRhJKb/pkMVZLlA3k0gUeRo6+ZVDTta1IW1eGaQBVEL1GveVLC n0vz510kYT0OpN/IyanOQzCHQTHpjRTMgbVeaY/5N811ccD6PckCAVfLKOa3fN1tAM5n aJ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=aRmz1qN/nGeVVKbguAqffsfuaBKpfTO08cmlH9pTvGlRYY6Yaj1pQE42O7K3iirSEh mND+acTTnsEEgaSYQ8YuP3U1PIYwhWpKR16Ya6aeewo0miDBfeDbCdGPgEYXpzvuCLKH KEooZfEN0KLqzgfpP7Z1M3bItQvtBM5dPeZkLkiHHClOcJZ7m7PwXeyWzVO3yQpcoFZ5 LAYey5oyJng6M/xh0K+hts8F8Ilche3dRgBxMbIJ8G44l2tw1hlrjkEs+USH9oCAWtwS Ha5PMRb4CVrb0mrGQpZc5dzwcFyDBNLVk9RL9Q8ZAY2d/3MVtMT1j5zovd/vzRgs4LdL 5tQw== X-Gm-Message-State: APjAAAWl3vu3AUQC11mzEBJqThiDNviNpVps6DVbC4xKzeDPzO5x71PH 3NmcFCoqQUbZtFzX7z4nRlWo1g== X-Google-Smtp-Source: APXvYqzNPRBGH9fYa6XMUb9Kcbd+L9DaQWdS1c4YXNu4dlR3oazpTgiDZXxcGp6bVMzhgy2FLbeDYg== X-Received: by 2002:adf:dfc2:: with SMTP id q2mr4336811wrn.251.1579599479951; Tue, 21 Jan 2020 01:37:59 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id u22sm54210033wru.30.2020.01.21.01.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:37:59 -0800 (PST) Date: Tue, 21 Jan 2020 09:37:55 +0000 From: Quentin Perret To: Dietmar Eggemann Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093755.GA157387@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200121_013802_138134_445ACB71 X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com, mgorman@suse.de, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, ionela.voinescu@arm.com, Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote: > True. But then we hard-code that a CPU device performance domain can > only be a frequency domain (which is true today). > > The task scheduler (build_perf_domains()) and thermal are already using > cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework > would too for CPU devices. I assume that could work with a couple of > adaptations in Documentation/power/energy-model.rst. Agreed, and if one day we have a real use case where the pd mask and the cpufreq policy mask need to be different, we'll do the necessary changes. But until then I don't see a reason to object to Lukasz' proposal. So +1 from me. Thanks, Quentin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Perret Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Date: Tue, 21 Jan 2020 09:37:55 +0000 Message-ID: <20200121093755.GA157387@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:46052 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727220AbgAUJiC (ORCPT ); Tue, 21 Jan 2020 04:38:02 -0500 Received: by mail-wr1-f67.google.com with SMTP id j42so2298398wrj.12 for ; Tue, 21 Jan 2020 01:38:01 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Dietmar Eggemann Cc: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Chris.Redpath@arm.com, ionela.voinescu@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote: > True. But then we hard-code that a CPU device performance domain can > only be a frequency domain (which is true today). > > The task scheduler (build_perf_domains()) and thermal are already using > cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework > would too for CPU devices. I assume that could work with a couple of > adaptations in Documentation/power/energy-model.rst. Agreed, and if one day we have a real use case where the pd mask and the cpufreq policy mask need to be different, we'll do the necessary changes. But until then I don't see a reason to object to Lukasz' proposal. So +1 from me. Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB39C33CAA for ; Tue, 21 Jan 2020 09:38:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95F1024655 for ; Tue, 21 Jan 2020 09:38:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GqYDh3tl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="I4Il4xqb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95F1024655 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zZKCeeTvVGbQxYIMfZF7gGyUeK4fSGqnGQN6KuQsb6E=; b=GqYDh3tl4ecFAC G/Xw0bsbqIgfigFOszXr2IM56hiBaNeCRjxMEFGfZ7TlhPEnsyCMhaWUFpUv37Ox073EiWgGbCuu9 Mqcb+TjqF5HzdUCvKDPL762eb/4oq7u2g67Ipvly1ouFVWqb5uHF/x+a5RTcGnVReLwpTggOYB9Ts +kNdI4WPMoRa11poNAoakXfrqBIprI0tqG7zpV2/k6i7O+xdJS8hw8I/jPtTA+Y16YLBuQ9FaJfii c98JVrY3u15QEkXtd9hrButMGEEXCTyzZUhMK1PpJs58IRXkXmmqe+bhPhW4jDePbHa55SRBylACo ABHhjd814wkJrBB80dUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itpz3-0001Wv-LU; Tue, 21 Jan 2020 09:38:05 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itpz0-0001VK-2U for linux-arm-kernel@lists.infradead.org; Tue, 21 Jan 2020 09:38:03 +0000 Received: by mail-wr1-x441.google.com with SMTP id y17so2353197wrh.5 for ; Tue, 21 Jan 2020 01:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=I4Il4xqb/mQRJaa0qSSl+Y25gZ18e057wP1tdP0lh2yLeaVpX0hadSOR4cl/LQpB3Q tyaDpcGYEDRokttwYZKiVcZfJVF8EHoSYV8AeT5Pk8Cx7E9Px1VKdhTcXR1aAUSJd42D xFOr6MeGSxv5TF/P/YEky3SS2IZFj68f7cxUiU1OZ4UxuYB744pGOuVT1Fv5ZBgPKRCQ 7lN+SeGd90TfRO9gjPQRhJKb/pkMVZLlA3k0gUeRo6+ZVDTta1IW1eGaQBVEL1GveVLC n0vz510kYT0OpN/IyanOQzCHQTHpjRTMgbVeaY/5N811ccD6PckCAVfLKOa3fN1tAM5n aJ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=W62eJ2IA1QcfRErXVc7arv2YKJtZOaS/mTLzsyLvwPpJ2m3q0lWYIxzurbQ6pgRjWp cuQdM3mZb5pkCL2kkmnBgKvpD+0K5E1RKtiPBVJdR6sAHOJX0Da36TiDeNRSrUCu7Ek2 XWWFQFeeGBZcDVZeOZpwiWWcbB0yRNWZ4PZVImfzlZ0GCoLuqal/aDjtlfQhJB1wX6y6 eU4eVDIGhvFir74yoOUMM3OKb053D3Vlo6noPQQgr7q+NXBSXqn/Ahgf2+cvPk34bOIe 9WPgEZ2Dwyya6U+pS88popcTybKFSR+IY7Hs3YtGCo0jSmA7ZsbjZU5BRO+uNJxe25Th FD/A== X-Gm-Message-State: APjAAAUhSJckUQUSbuNkv7Z1Vj/09outi+TCDrg75QQOBqGhOfbG7FUN IG8tuSgzuP+isOTrMN348CNVLA== X-Google-Smtp-Source: APXvYqzNPRBGH9fYa6XMUb9Kcbd+L9DaQWdS1c4YXNu4dlR3oazpTgiDZXxcGp6bVMzhgy2FLbeDYg== X-Received: by 2002:adf:dfc2:: with SMTP id q2mr4336811wrn.251.1579599479951; Tue, 21 Jan 2020 01:37:59 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id u22sm54210033wru.30.2020.01.21.01.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:37:59 -0800 (PST) Date: Tue, 21 Jan 2020 09:37:55 +0000 From: Quentin Perret To: Dietmar Eggemann Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093755.GA157387@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200121_013802_139651_B885EF93 X-CRM114-Status: GOOD ( 10.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com, mgorman@suse.de, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, ionela.voinescu@arm.com, Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote: > True. But then we hard-code that a CPU device performance domain can > only be a frequency domain (which is true today). > > The task scheduler (build_perf_domains()) and thermal are already using > cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework > would too for CPU devices. I assume that could work with a couple of > adaptations in Documentation/power/energy-model.rst. Agreed, and if one day we have a real use case where the pd mask and the cpufreq policy mask need to be different, we'll do the necessary changes. But until then I don't see a reason to object to Lukasz' proposal. So +1 from me. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB1FC2D0DB for ; Wed, 22 Jan 2020 08:21:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0FB42253D for ; Wed, 22 Jan 2020 08:21:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="I4Il4xqb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0FB42253D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C0CD6F3DA; Wed, 22 Jan 2020 08:21:12 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id A92516EC1A for ; Tue, 21 Jan 2020 09:38:01 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id t2so2388355wrr.1 for ; Tue, 21 Jan 2020 01:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=I4Il4xqb/mQRJaa0qSSl+Y25gZ18e057wP1tdP0lh2yLeaVpX0hadSOR4cl/LQpB3Q tyaDpcGYEDRokttwYZKiVcZfJVF8EHoSYV8AeT5Pk8Cx7E9Px1VKdhTcXR1aAUSJd42D xFOr6MeGSxv5TF/P/YEky3SS2IZFj68f7cxUiU1OZ4UxuYB744pGOuVT1Fv5ZBgPKRCQ 7lN+SeGd90TfRO9gjPQRhJKb/pkMVZLlA3k0gUeRo6+ZVDTta1IW1eGaQBVEL1GveVLC n0vz510kYT0OpN/IyanOQzCHQTHpjRTMgbVeaY/5N811ccD6PckCAVfLKOa3fN1tAM5n aJ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+M730A48Aqh4pFSc6/yOGVnR2p3jp3qMHztEPqPnpzo=; b=ZxTbtOtq3AaWePRZpBnmCvp3uzaJRU/tYDK7GtkL9xmE6pPyqAAUKRCHrIwkRFKoSo 7fEuOycKe2W5IpPcDV2pOSXOmu/iU6M+lGbtHMqt/5Qr/l0BsGE2v2H+2QtnZqbjYIsi 5BlJcXcGtfT6P+AkTZjB5kMx4Xv8BaHJ/zT7MHFZ+GsNREQRhul9xx6rrgB9L7BK/1I9 w4k4hdGX77amNMRjhls4fEYux3vL0cSg2exWDPixdpHoOjd9e9dwSNOcHmiK5H+IqZBn xcqz9NULnkJfMCCSs2Ai77sMV2Fjo5RihVa+umlSJpZDyltOVHDODEcQWbtVDh55QMiw cYtg== X-Gm-Message-State: APjAAAV7pj+rHj441kWoUHnHx+yLPnWIASK5HshyAkgLAC8x/UJts6vi 1SrdjCw3HjbxuBDcDfGri3VRuQ== X-Google-Smtp-Source: APXvYqzNPRBGH9fYa6XMUb9Kcbd+L9DaQWdS1c4YXNu4dlR3oazpTgiDZXxcGp6bVMzhgy2FLbeDYg== X-Received: by 2002:adf:dfc2:: with SMTP id q2mr4336811wrn.251.1579599479951; Tue, 21 Jan 2020 01:37:59 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id u22sm54210033wru.30.2020.01.21.01.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 01:37:59 -0800 (PST) Date: Tue, 21 Jan 2020 09:37:55 +0000 From: Quentin Perret To: Dietmar Eggemann Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200121093755.GA157387@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <20200117105437.GA211774@google.com> <40587d98-0e8d-cbac-dbf5-d26501d47a8c@arm.com> <20200120150918.GA164543@google.com> <8332c4ac-2a7d-1e2d-76e9-7c979a666257@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Wed, 22 Jan 2020 08:21:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, kernel-team@android.com, mgorman@suse.de, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, ionela.voinescu@arm.com, Lukasz Luba Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tuesday 21 Jan 2020 at 10:10:16 (+0100), Dietmar Eggemann wrote: > True. But then we hard-code that a CPU device performance domain can > only be a frequency domain (which is true today). > > The task scheduler (build_perf_domains()) and thermal are already using > cpufreq_cpu_get() to access the cpufreq policy. Now the EM framework > would too for CPU devices. I assume that could work with a couple of > adaptations in Documentation/power/energy-model.rst. Agreed, and if one day we have a real use case where the pd mask and the cpufreq policy mask need to be different, we'll do the necessary changes. But until then I don't see a reason to object to Lukasz' proposal. So +1 from me. Thanks, Quentin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel