From: Jean Delvare <jdelvare@suse.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: i801: Add support for Intel Comet Lake PCH-V
Date: Tue, 21 Jan 2020 10:05:12 +0100 [thread overview]
Message-ID: <20200121100512.7da72467@endymion> (raw)
In-Reply-To: <20200116074651.529380-1-jarkko.nikula@linux.intel.com>
On Thu, 16 Jan 2020 09:46:51 +0200, Jarkko Nikula wrote:
> Add support for Intel Comet Lake PCH-V which is based on Intel Kaby
> Lake. Difference between it and other Comet Lake variants is that former
> uses previous iTCO version 4 and latter use version 6 like Intel Cannon
> Lake PCH.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-i801.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 44db3a91d32d..ca4f096fef74 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -68,6 +68,7 @@
> * Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes
> * Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes
> * Jasper Lake (SOC) 0x4da3 32 hard yes yes yes
> + * Comet Lake-V (PCH) 0xa3a3 32 hard yes yes yes
> *
> * Features supported by this driver:
> * Software PEC no
> @@ -244,6 +245,7 @@
> #define PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS 0xa223
> #define PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS 0xa2a3
> #define PCI_DEVICE_ID_INTEL_CANNONLAKE_H_SMBUS 0xa323
> +#define PCI_DEVICE_ID_INTEL_COMETLAKE_V_SMBUS 0xa3a3
>
> struct i801_mux_config {
> char *gpio_chip;
> @@ -1074,6 +1076,7 @@ static const struct pci_device_id i801_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_V_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) },
> @@ -1742,6 +1745,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
> case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
> case PCI_DEVICE_ID_INTEL_KABYLAKE_PCH_H_SMBUS:
> + case PCI_DEVICE_ID_INTEL_COMETLAKE_V_SMBUS:
> priv->features |= FEATURE_BLOCK_PROC;
> priv->features |= FEATURE_I2C_BLOCK_READ;
> priv->features |= FEATURE_IRQ;
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-01-21 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 7:46 [PATCH] i2c: i801: Add support for Intel Comet Lake PCH-V Jarkko Nikula
2020-01-21 9:05 ` Jean Delvare [this message]
2020-01-29 21:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121100512.7da72467@endymion \
--to=jdelvare@suse.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.