From: Mike Snitzer <snitzer@redhat.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com, bob.liu@oracle.com, axboe@kernel.dk,
agk@redhat.com, dm-devel@redhat.com, song@kernel.org,
tytso@mit.edu, adilger.kernel@dilger.ca,
Chaitanya.Kulkarni@wdc.com, darrick.wong@oracle.com,
ming.lei@redhat.com, osandov@fb.com, jthumshirn@suse.de,
minwoo.im.dev@gmail.com, damien.lemoal@wdc.com,
andrea.parri@amarulasolutions.com, hare@suse.com, tj@kernel.org,
ajay.joshi@wdc.com, sagi@grimberg.me, dsterba@suse.com,
bvanassche@acm.org, dhowells@redhat.com, asml.silence@gmail.com
Subject: Re: [PATCH v4 6/7] dm: Directly disable max_allocate_sectors for now
Date: Tue, 21 Jan 2020 07:24:59 -0500 [thread overview]
Message-ID: <20200121122458.GA9365@redhat.com> (raw)
In-Reply-To: <157960337238.108120.18048939587162465175.stgit@localhost.localdomain>
On Tue, Jan 21 2020 at 5:42am -0500,
Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
> Since dm inherits limits from underlining block devices,
> this patch directly disables max_allocate_sectors for dm
> till full allocation support is implemented.
>
> This prevents high-level primitives (generic_make_request_checks(),
> __blkdev_issue_write_zeroes(), ...) from sending REQ_ALLOCATE
> requests.
>
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> ---
> drivers/md/dm-table.c | 2 ++
> drivers/md/md.h | 1 +
> 2 files changed, 3 insertions(+)
You're mixing DM and MD changes in the same patch.
But I'm wondering if it might be best to set this default for stacking
devices in blk_set_stacking_limits()?
And then it is up to each stacking driver to override as needed.
Mike
next prev parent reply other threads:[~2020-01-21 12:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 10:42 [PATCH v4 0/7] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES Kirill Tkhai
2020-01-21 10:42 ` [PATCH v4 1/7] block: Add @flags argument to bdev_write_zeroes_sectors() Kirill Tkhai
2020-01-21 10:42 ` [PATCH v4 2/7] block: Pass op_flags into blk_queue_get_max_sectors() Kirill Tkhai
2020-01-21 10:42 ` [PATCH v4 3/7] block: Introduce blk_queue_get_max_write_zeroes_sectors() Kirill Tkhai
2020-01-21 10:42 ` [PATCH v4 4/7] block: Add support for REQ_ALLOCATE flag Kirill Tkhai
2020-01-21 10:42 ` [PATCH v4 5/7] block: Add blk_queue_max_allocate_sectors() Kirill Tkhai
2020-01-21 10:42 ` [PATCH v4 6/7] dm: Directly disable max_allocate_sectors for now Kirill Tkhai
2020-01-21 12:24 ` Mike Snitzer [this message]
2020-01-21 12:36 ` Kirill Tkhai
2020-01-21 13:33 ` Kirill Tkhai
2020-01-21 13:48 ` Mike Snitzer
2020-01-21 14:20 ` Kirill Tkhai
2020-01-21 14:43 ` Mike Snitzer
2020-01-21 15:13 ` Kirill Tkhai
2020-01-21 10:42 ` [PATCH v4 7/7] loop: Add support for REQ_ALLOCATE Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121122458.GA9365@redhat.com \
--to=snitzer@redhat.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=adilger.kernel@dilger.ca \
--cc=agk@redhat.com \
--cc=ajay.joshi@wdc.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bob.liu@oracle.com \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=hare@suse.com \
--cc=jthumshirn@suse.de \
--cc=ktkhai@virtuozzo.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=osandov@fb.com \
--cc=sagi@grimberg.me \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.