From: Jakub Kicinski <kuba@kernel.org>
To: gautamramk@gmail.com
Cc: netdev@vger.kernel.org,
"Mohit P. Tahiliani" <tahiliani@nitk.edu.in>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"David S . Miller" <davem@davemloft.net>,
"Dave Taht" <dave.taht@gmail.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Leslie Monis" <lesliemonis@gmail.com>,
"Sachin D . Patil" <sdp.sachin@gmail.com>,
"V . Saicharan" <vsaicharan1998@gmail.com>,
"Mohit Bhasi" <mohitbhasi1998@gmail.com>
Subject: Re: [PATCH net-next v6 10/10] net: sched: add Flow Queue PIE packet scheduler
Date: Wed, 22 Jan 2020 07:42:03 -0800 [thread overview]
Message-ID: <20200122074203.00566700@cakuba> (raw)
In-Reply-To: <20200122113533.28128-11-gautamramk@gmail.com>
On Wed, 22 Jan 2020 17:05:33 +0530, gautamramk@gmail.com wrote:
> + err = tcf_block_get(&q->block, &q->filter_list, sch, extack);
> + if (err)
> + goto init_failure;
I think you're missing a tcf_block_put() call or equivalent.
next prev parent reply other threads:[~2020-01-22 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 11:35 [PATCH net-next v6 00/10] net: sched: add Flow Queue PIE packet scheduler gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 01/10] net: sched: pie: move common code to pie.h gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 02/10] pie: use U64_MAX to denote (2^64 - 1) gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 03/10] pie: rearrange macros in order of length gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 04/10] pie: use u8 instead of bool in pie_vars gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 05/10] pie: rearrange structure members and their initializations gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 06/10] pie: improve comments and commenting style gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 07/10] net: sched: pie: fix commenting gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 08/10] net: sched: pie: fix alignment in struct instances gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 09/10] net: sched: pie: export symbols to be reused by FQ-PIE gautamramk
2020-01-22 11:35 ` [PATCH net-next v6 10/10] net: sched: add Flow Queue PIE packet scheduler gautamramk
2020-01-22 15:42 ` Jakub Kicinski [this message]
2020-01-22 17:40 ` Gautam Ramakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122074203.00566700@cakuba \
--to=kuba@kernel.org \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=gautamramk@gmail.com \
--cc=jhs@mojatatu.com \
--cc=lesliemonis@gmail.com \
--cc=mohitbhasi1998@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sdp.sachin@gmail.com \
--cc=stephen@networkplumber.org \
--cc=tahiliani@nitk.edu.in \
--cc=toke@redhat.com \
--cc=vsaicharan1998@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.