From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F189C33CB6 for ; Wed, 22 Jan 2020 08:57:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35E2624672 for ; Wed, 22 Jan 2020 08:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579683465; bh=BO71Ig/atLd53yrlotlahFJmi4U33jJcXrA6eU31LNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZxLHUh8z+Fm0BzHWD4ySpPe1BD84KS6KtfNLbVB7SAzGfO2FJST6Qp9dHuhlxaZ+c AKaIfXBvrPUL3hAZ+eaLDAGy+fB1cE/oJ47MFQ6w6382/dJQI3jZlX6HNaezyj3p3Q UGh9VBjFO7gVdhXpUTVms9tIs1EETeV4p0DuYcB4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727141AbgAVI5k (ORCPT ); Wed, 22 Jan 2020 03:57:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:51230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbgAVI5k (ORCPT ); Wed, 22 Jan 2020 03:57:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A58D2253D; Wed, 22 Jan 2020 08:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579683460; bh=BO71Ig/atLd53yrlotlahFJmi4U33jJcXrA6eU31LNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=deLMlOvVGt6KXrxBOrsAoTZHWciDMV7Sz2wzzQJppb0jnvG7vHH+E0IzQD9Kbx22n kgNN3WCX1AD0FMlNy7YxshX7m2I4nWnelN1/qT3vSyqhxNMKl9BOvQxghskC/9bBIK MpW5chD0AJHbi+kSoOotLENcW3gOicEgOla/kSDk= Date: Wed, 22 Jan 2020 09:57:37 +0100 From: Greg Kroah-Hartman To: "T.Kohada" Cc: Mori.Takahiro@ab.mitsubishielectric.co.jp, motai.hirotaka@aj.mitsubishielectric.co.jp, Valdis Kletnieks , linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: exfat: remove fs_func struct. Message-ID: <20200122085737.GA2511011@kroah.com> References: <20200117062046.20491-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200117062046.20491-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jan 17, 2020 at 03:20:46PM +0900, T.Kohada wrote: > Remove 'fs_func struct' and change indirect calls to direct calls. > > The following issues are described in exfat's TODO. > > Create helper function for exfat_set_entry_time () and > > exfat_set_entry_type () because it's sort of ugly to be calling the same functionn directly and other code calling through the fs_func struc ponters ... > > The fs_func struct was used for switching the helper functions of fat16/fat32/exfat. > Now, it has lost the role of switching, just making the code less readable. > > Signed-off-by: T.Kohada We need a "full" name here, not just an abbreviation, use what you would for a document. Also the patch does not apply to the linux-next tree at all, so I can't take it. Please rebase and resend. thanks, greg k-h