From: Wolfram Sang <wsa@the-dreams.de>
To: Rishi Gupta <gupt21@gmail.com>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
wsa+renesas@sang-engineering.com, gregkh@linuxfoundation.org,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: mcp2221: add usb to i2c-smbus host bridge driver
Date: Wed, 22 Jan 2020 14:13:20 +0100 [thread overview]
Message-ID: <20200122131320.GA20984@ninjato> (raw)
In-Reply-To: <1579581860-29560-1-git-send-email-gupt21@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Tue, Jan 21, 2020 at 10:14:20AM +0530, Rishi Gupta wrote:
> MCP2221 is a USB HID to I2C/SMbus host bridge device. This
> commit implements i2c and smbus host adapter support. 7-bit
> address and i2c multi-message transaction is also supported.
>
> Signed-off-by: Rishi Gupta <gupt21@gmail.com>
My main concern is there are quite some limitations in mcp_i2c_xfer().
Looking at them, I think we should just drop it. This seems to be an
SMBus controller, not I2C. Or?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-22 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 4:44 [PATCH v2] HID: mcp2221: add usb to i2c-smbus host bridge driver Rishi Gupta
2020-01-21 23:27 ` Benjamin Tissoires
2020-01-22 11:47 ` rishi gupta
2020-01-22 13:13 ` Wolfram Sang [this message]
2020-01-22 13:18 ` rishi gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122131320.GA20984@ninjato \
--to=wsa@the-dreams.de \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=gupt21@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.