From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf,v2] netfilter: nf_tables: autoload modules from the abort path
Date: Wed, 22 Jan 2020 23:28:08 +0100 [thread overview]
Message-ID: <20200122222808.GR795@breakpoint.cc> (raw)
In-Reply-To: <20200122211706.150042-1-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> + list_for_each_entry(req, &net->nft.module_list, list) {
> + if (!strcmp(req->module, module_name) && req->done)
> + return 0;
> + }
If the module is already on this list, why does it need to be
added a second time?
Other than that I like this idea as it avoids the entire "drop
transaction mutex while inside a transaction" mess.
next prev parent reply other threads:[~2020-01-22 22:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 21:17 [PATCH nf,v2] netfilter: nf_tables: autoload modules from the abort path Pablo Neira Ayuso
2020-01-22 22:28 ` Florian Westphal [this message]
2020-01-22 22:49 ` Pablo Neira Ayuso
2020-01-22 22:50 ` Pablo Neira Ayuso
2020-01-23 3:45 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122222808.GR795@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.