From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6389C32771 for ; Wed, 22 Jan 2020 23:06:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B95024673 for ; Wed, 22 Jan 2020 23:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579734416; bh=iDK9mhfatk0/hNugU/WPUPfmhu1Thz7bh75Z2DXYU/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2k3faRC0Cn34xJPIhNdJV9melIHeKiB14zBeYhfyVJ8fHow//4nE6yZLiSG2a54ET q5R3M/d+MVf2+GWvFddlhMy9i0K20A9YQrus2rRyUfRBlLya/RFHXOw90he7ia1uSM +Wb12c8r1TNg/7Bf4W8k/aNpMrM/nLQlNF1spvp4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbgAVXGx (ORCPT ); Wed, 22 Jan 2020 18:06:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:42486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbgAVXGw (ORCPT ); Wed, 22 Jan 2020 18:06:52 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9A802465A; Wed, 22 Jan 2020 23:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579734412; bh=iDK9mhfatk0/hNugU/WPUPfmhu1Thz7bh75Z2DXYU/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MdMedgKfSUinhQoW7EX8dAKvj1YwqwHzlbb1cbzLT6dOt2HZWykDyFD3k2cNyhQyK 8GB5uINMlhWRPvQRr20QS8SxKPsazWkqZ9NELkASmhvpjUozkcfUA+LLJ+HQqgq/Lb YogycmIn0nDOqv8LkTPXOOSGVMsOMS5102vK6M3Q= Date: Wed, 22 Jan 2020 15:06:50 -0800 From: Eric Biggers To: linux-fscrypt@vger.kernel.org Cc: Daniel Rosenberg , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi , linux-mtd@lists.infradead.org, Richard Weinberger Subject: Re: [PATCH v5 0/6] fscrypt preparations for encryption+casefolding Message-ID: <20200122230649.GC182745@gmail.com> References: <20200120223201.241390-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120223201.241390-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jan 20, 2020 at 02:31:55PM -0800, Eric Biggers wrote: > This is a cleaned up and fixed version of the fscrypt patches to prepare > for directories that are both encrypted and casefolded. > > Patches 1-3 start deriving a SipHash key for the new dirhash method that > will be used by encrypted+casefolded directories. To avoid unnecessary > overhead, we only do this if the directory is actually casefolded. > > Patch 4 fixes a bug in UBIFS where it didn't gracefully handle invalid > hash values in fscrypt no-key names. This is an existing bug, but the > new fscrypt no-key name format (patch 6) made it much easier to trigger; > it started being hit by 'kvm-xfstests -c ubifs -g encrypt'. > > Patch 5 updates UBIFS to make it ready for the new fscrypt no-key name > format that always includes the dirhash. > > Patch 6 modifies the fscrypt no-key names to always include the dirhash, > since with the new dirhash method the dirhash will no longer be > computable from the ciphertext filename without the key. It also fixes > a longstanding issue where there could be collisions in the no-key > names, due to not using a proper cryptographic hash to abbreviate names. > > For more information see the main patch series, which includes the > filesystem-specific changes: > https://lkml.kernel.org/linux-fscrypt/20200117214246.235591-1-drosen@google.com/T/#u > > This applies to fscrypt.git#master. > > Changed v4 => v5: > - Fixed UBIFS encryption to work with the new no-key name format. I've applied this series to fscrypt.git#master; however I'd still like Acked-bys from the UBIFS maintainers on the two UBIFS patches, as well as more Reviewed-bys from anyone interested. If I don't hear anything from anyone, I might drop these to give more time, especially if there isn't an v5.5-rc8. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8730BC32771 for ; Wed, 22 Jan 2020 23:07:06 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 489772465A; Wed, 22 Jan 2020 23:07:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="cCF6d0kj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="nD620xvl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="MdMedgKf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 489772465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iuP5V-0008OP-To; Wed, 22 Jan 2020 23:07:05 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iuP5U-0008OB-NQ for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Jan 2020 23:07:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nukPsxWLLzQ1KeasqoNBdJ+Ht4Ckwhu8wdfENE7E+lY=; b=cCF6d0kjCnCGEL3xaOumQKsZzl BMu5bQEJLlannKVGN1B5cnNLWUfXHRjGOJjI/RkRMbauoRqFyL3MvW8blgy3RR94OFaH4DhrRkoMy /yR//+WbEhFmHb0GFoMpd+uCiizfX3QHtlztaCN69ISghf60L0c/Q/d4YYx+XljluHQQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nukPsxWLLzQ1KeasqoNBdJ+Ht4Ckwhu8wdfENE7E+lY=; b=nD620xvlvQy1ljW50LX4NjzCld mKnbnst+skiXHpkaN5UYNKpW98qXQ0V6PGcJYzcU+q9nIdzl+0PhbdXI5S8dtVy5cMbaoOrl8N4Bv lk9j696sClox2ONUPzbJ/NIWPmhGNGdkbeWwXKEDy7E4fWAryLyYIhV+I3mPYUPBjr74=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iuP5S-00FBDi-KB for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Jan 2020 23:07:04 +0000 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9A802465A; Wed, 22 Jan 2020 23:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579734412; bh=iDK9mhfatk0/hNugU/WPUPfmhu1Thz7bh75Z2DXYU/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MdMedgKfSUinhQoW7EX8dAKvj1YwqwHzlbb1cbzLT6dOt2HZWykDyFD3k2cNyhQyK 8GB5uINMlhWRPvQRr20QS8SxKPsazWkqZ9NELkASmhvpjUozkcfUA+LLJ+HQqgq/Lb YogycmIn0nDOqv8LkTPXOOSGVMsOMS5102vK6M3Q= Date: Wed, 22 Jan 2020 15:06:50 -0800 From: Eric Biggers To: linux-fscrypt@vger.kernel.org Message-ID: <20200122230649.GC182745@gmail.com> References: <20200120223201.241390-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200120223201.241390-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1iuP5S-00FBDi-KB Subject: Re: [f2fs-dev] [PATCH v5 0/6] fscrypt preparations for encryption+casefolding X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Rosenberg , Gabriel Krisman Bertazi , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Richard Weinberger , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Jan 20, 2020 at 02:31:55PM -0800, Eric Biggers wrote: > This is a cleaned up and fixed version of the fscrypt patches to prepare > for directories that are both encrypted and casefolded. > > Patches 1-3 start deriving a SipHash key for the new dirhash method that > will be used by encrypted+casefolded directories. To avoid unnecessary > overhead, we only do this if the directory is actually casefolded. > > Patch 4 fixes a bug in UBIFS where it didn't gracefully handle invalid > hash values in fscrypt no-key names. This is an existing bug, but the > new fscrypt no-key name format (patch 6) made it much easier to trigger; > it started being hit by 'kvm-xfstests -c ubifs -g encrypt'. > > Patch 5 updates UBIFS to make it ready for the new fscrypt no-key name > format that always includes the dirhash. > > Patch 6 modifies the fscrypt no-key names to always include the dirhash, > since with the new dirhash method the dirhash will no longer be > computable from the ciphertext filename without the key. It also fixes > a longstanding issue where there could be collisions in the no-key > names, due to not using a proper cryptographic hash to abbreviate names. > > For more information see the main patch series, which includes the > filesystem-specific changes: > https://lkml.kernel.org/linux-fscrypt/20200117214246.235591-1-drosen@google.com/T/#u > > This applies to fscrypt.git#master. > > Changed v4 => v5: > - Fixed UBIFS encryption to work with the new no-key name format. I've applied this series to fscrypt.git#master; however I'd still like Acked-bys from the UBIFS maintainers on the two UBIFS patches, as well as more Reviewed-bys from anyone interested. If I don't hear anything from anyone, I might drop these to give more time, especially if there isn't an v5.5-rc8. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF83BC32771 for ; Wed, 22 Jan 2020 23:07:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 804662465A for ; Wed, 22 Jan 2020 23:07:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cnAsHPfx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="MdMedgKf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 804662465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H//3bL14IfmUmalsHoYTFk5SH+K+IQxINScRC33LaZ0=; b=cnAsHPfxjiB5u1 vaIztiSZHmSoGzBS7Th2sTnoTIcJYz5rYa+anW5eKkL8Vp2IFG8ePRz9LzSstjEMa9yCY3TZ55IfT Ud9Qn+DAP++Etz4J5O2aau+3rP2mEFmEgJQ1QDxsghKwOygKzNL3utteLNjyHFsS1Ny2sYT/G3kHL dvxWcBmPdMohsIlG1j848cZsHjD4a1zwrznQQAuO4MphEKoannd0c1ogHjEtbR0kJJmNkcui3lrVi HhNhsTlEaG+b8/edkWEO2MZGepOeo2KHOmoEw/bXxC936zzGky8iLFCRf0Sm+POGnAXa3bv+wsr74 fyPULHUkPiPapPq65lhw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuP5M-0003ap-1L; Wed, 22 Jan 2020 23:06:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuP5J-0003a4-74 for linux-mtd@lists.infradead.org; Wed, 22 Jan 2020 23:06:54 +0000 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9A802465A; Wed, 22 Jan 2020 23:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579734412; bh=iDK9mhfatk0/hNugU/WPUPfmhu1Thz7bh75Z2DXYU/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MdMedgKfSUinhQoW7EX8dAKvj1YwqwHzlbb1cbzLT6dOt2HZWykDyFD3k2cNyhQyK 8GB5uINMlhWRPvQRr20QS8SxKPsazWkqZ9NELkASmhvpjUozkcfUA+LLJ+HQqgq/Lb YogycmIn0nDOqv8LkTPXOOSGVMsOMS5102vK6M3Q= Date: Wed, 22 Jan 2020 15:06:50 -0800 From: Eric Biggers To: linux-fscrypt@vger.kernel.org Subject: Re: [PATCH v5 0/6] fscrypt preparations for encryption+casefolding Message-ID: <20200122230649.GC182745@gmail.com> References: <20200120223201.241390-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200120223201.241390-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200122_150653_279486_79409479 X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Rosenberg , Gabriel Krisman Bertazi , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Richard Weinberger , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Jan 20, 2020 at 02:31:55PM -0800, Eric Biggers wrote: > This is a cleaned up and fixed version of the fscrypt patches to prepare > for directories that are both encrypted and casefolded. > > Patches 1-3 start deriving a SipHash key for the new dirhash method that > will be used by encrypted+casefolded directories. To avoid unnecessary > overhead, we only do this if the directory is actually casefolded. > > Patch 4 fixes a bug in UBIFS where it didn't gracefully handle invalid > hash values in fscrypt no-key names. This is an existing bug, but the > new fscrypt no-key name format (patch 6) made it much easier to trigger; > it started being hit by 'kvm-xfstests -c ubifs -g encrypt'. > > Patch 5 updates UBIFS to make it ready for the new fscrypt no-key name > format that always includes the dirhash. > > Patch 6 modifies the fscrypt no-key names to always include the dirhash, > since with the new dirhash method the dirhash will no longer be > computable from the ciphertext filename without the key. It also fixes > a longstanding issue where there could be collisions in the no-key > names, due to not using a proper cryptographic hash to abbreviate names. > > For more information see the main patch series, which includes the > filesystem-specific changes: > https://lkml.kernel.org/linux-fscrypt/20200117214246.235591-1-drosen@google.com/T/#u > > This applies to fscrypt.git#master. > > Changed v4 => v5: > - Fixed UBIFS encryption to work with the new no-key name format. I've applied this series to fscrypt.git#master; however I'd still like Acked-bys from the UBIFS maintainers on the two UBIFS patches, as well as more Reviewed-bys from anyone interested. If I don't hear anything from anyone, I might drop these to give more time, especially if there isn't an v5.5-rc8. - Eric ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/