From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] spl: Move check for SPL_LIBCOMMON support to header
Date: Wed, 22 Jan 2020 18:25:50 -0500 [thread overview]
Message-ID: <20200122232550.GA5284@bill-the-cat> (raw)
In-Reply-To: <20200107233623.21587-1-afd@ti.com>
On Tue, Jan 07, 2020 at 06:36:23PM -0500, Andrew F. Davis wrote:
> Print statements in SPL depend on lib/common support, due to this many
> such print statements are ifdef'd. Instead of checking at each call site
> move the check to the common.h header and remove these inline checks.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
This breaks a number of platforms as can be seen on Travis/GitLab/Azure.
I bisected down to this commit while testing by using the firefly-px30
board.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200122/7229c87c/attachment.sig>
prev parent reply other threads:[~2020-01-22 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 23:36 [U-Boot] [PATCH v2] spl: Move check for SPL_LIBCOMMON support to header Andrew F. Davis
2020-01-08 4:16 ` Lokesh Vutla
2020-01-22 23:25 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122232550.GA5284@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.