From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E79FC3F68F for ; Thu, 23 Jan 2020 06:44:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E84D2467F for ; Thu, 23 Jan 2020 06:44:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="G/mRONxn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="w1p1nQD4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E84D2467F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2C292166D; Thu, 23 Jan 2020 07:43:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2C292166D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579761847; bh=BmoIQNOCORmUCbDs5W8DADyK5hhc2lmoK3rAPlWrSzk=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=G/mRONxn0uNCuvhEKsu597j+1071cFJp+/k4RdNkwnQ282WFVWaF/tBTSQPWinP6u O+I6o716Ii/NJKTnaMshGkCKB4xsZ6cJa5d7WpWdwCZ7kfcAUpIzrk/1Yon2ilpEOY 8oHeJ3X6SM7VqHUTp0jk8nZTApdEX+nWqXa8rqp0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 950B4F8015B; Thu, 23 Jan 2020 07:43:16 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 62C7BF801D9; Thu, 23 Jan 2020 07:43:14 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4E66AF80112 for ; Thu, 23 Jan 2020 07:43:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4E66AF80112 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="w1p1nQD4" Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1835217F4; Thu, 23 Jan 2020 06:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579761788; bh=xAQZj9tFY1FT0CiNNJlEJTsbJX8801qGcsw3AFIuivc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=w1p1nQD4PvUFTg70UDMsv9EfZ/21Xb6vHclyPaNttcT2tmD7Nkl/6CbAKlx5qkAJ9 IW/7KPBbFReuNQLWbmkkfVtwEjSBeCcX1Uj/WQPg0Pb6f9RjRKYTpfjwtVmqj2VStA cn5Mk5b6cLr/6f3zZXgg4BX7uMkzS9J9srW/Y6Cg= Date: Thu, 23 Jan 2020 07:43:06 +0100 From: Greg Kroah-Hartman To: Mark Brown Message-ID: <20200123064306.GA124954@kroah.com> References: <20200122190752.3081016-1-perex@perex.cz> <26ae4dbd-b1b8-c640-0dc0-d8c2bbe666e2@linux.intel.com> <20200122202530.GG3833@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200122202530.GG3833@sirena.org.uk> Cc: Dragos Tarcatu , Sasha Levin , ALSA development , Takashi Iwai , Ranjani Sridharan , stable@vger.kernel.org, Pierre-Louis Bossart Subject: Re: [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Jan 22, 2020 at 08:25:30PM +0000, Mark Brown wrote: > On Wed, Jan 22, 2020 at 01:28:57PM -0600, Pierre-Louis Bossart wrote: > > On 1/22/20 1:07 PM, Jaroslav Kysela wrote: > > > > The code which checks the return value for snd_soc_add_dai_link() call > > > in soc_tplg_fe_link_create() moved the snd_soc_add_dai_link() call before > > > link->dobj members initialization. > > > > While it does not affect the latest kernels, the old soc-core.c code > > > in the stable kernels is affected. The snd_soc_add_dai_link() function uses > > > the link->dobj.type member to check, if the link structure is valid. > > > > Reorder the link->dobj initialization to make things work again. > > > It's harmless for the recent code (and the structure should be properly > > > initialized before other calls anyway). > > > > The problem is in stable linux-5.4.y since version 5.4.11 when the > > > upstream commit 76d270364932 was applied. > > > I am not following. Is this a fix for linux-5.4-y only, or is it needed on > > Mark's tree? In the latter case, what is broken? We've been using Mark's > > tree without issues, wondering what we missed? > > He's saying it's a fix for stable but it's just a cleanup and robustness > improvement in current kernels - when the patch 76d270364932 (ASoC: > topology: Check return value for snd_soc_add_dai_link()) was backported > by the bot the bot missed some other context which triggered bugs. > > Copying in Sasha and Greg for stable (not sure if the list works by > itself). How this was marked-up is fine, our scripts can easily handle it, thanks. greg k-h _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D851AC33CAA for ; Thu, 23 Jan 2020 06:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A006A2467B for ; Thu, 23 Jan 2020 06:43:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579761789; bh=xAQZj9tFY1FT0CiNNJlEJTsbJX8801qGcsw3AFIuivc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sMO4j3SZJRVRa3cZtUU2meiBdGj2sEqbRb1t4fkPcrPfidfe6qb/3y2ySDzJhffg4 64dWoAPEjdt5RLAt+G8Bhe8zx4u2Fs2WKpl87wrL/jUmS0S7LS5+Z//A8z8naN0ZVi iU5OR/2tRF1tOWJsz8/LzhacF+7BfdjW2j7iKKLA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725818AbgAWGnJ (ORCPT ); Thu, 23 Jan 2020 01:43:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:34540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgAWGnJ (ORCPT ); Thu, 23 Jan 2020 01:43:09 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1835217F4; Thu, 23 Jan 2020 06:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579761788; bh=xAQZj9tFY1FT0CiNNJlEJTsbJX8801qGcsw3AFIuivc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=w1p1nQD4PvUFTg70UDMsv9EfZ/21Xb6vHclyPaNttcT2tmD7Nkl/6CbAKlx5qkAJ9 IW/7KPBbFReuNQLWbmkkfVtwEjSBeCcX1Uj/WQPg0Pb6f9RjRKYTpfjwtVmqj2VStA cn5Mk5b6cLr/6f3zZXgg4BX7uMkzS9J9srW/Y6Cg= Date: Thu, 23 Jan 2020 07:43:06 +0100 From: Greg Kroah-Hartman To: Mark Brown Cc: Pierre-Louis Bossart , Jaroslav Kysela , ALSA development , Dragos Tarcatu , Takashi Iwai , Ranjani Sridharan , stable@vger.kernel.org, Sasha Levin Subject: Re: [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order Message-ID: <20200123064306.GA124954@kroah.com> References: <20200122190752.3081016-1-perex@perex.cz> <26ae4dbd-b1b8-c640-0dc0-d8c2bbe666e2@linux.intel.com> <20200122202530.GG3833@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200122202530.GG3833@sirena.org.uk> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 22, 2020 at 08:25:30PM +0000, Mark Brown wrote: > On Wed, Jan 22, 2020 at 01:28:57PM -0600, Pierre-Louis Bossart wrote: > > On 1/22/20 1:07 PM, Jaroslav Kysela wrote: > > > > The code which checks the return value for snd_soc_add_dai_link() call > > > in soc_tplg_fe_link_create() moved the snd_soc_add_dai_link() call before > > > link->dobj members initialization. > > > > While it does not affect the latest kernels, the old soc-core.c code > > > in the stable kernels is affected. The snd_soc_add_dai_link() function uses > > > the link->dobj.type member to check, if the link structure is valid. > > > > Reorder the link->dobj initialization to make things work again. > > > It's harmless for the recent code (and the structure should be properly > > > initialized before other calls anyway). > > > > The problem is in stable linux-5.4.y since version 5.4.11 when the > > > upstream commit 76d270364932 was applied. > > > I am not following. Is this a fix for linux-5.4-y only, or is it needed on > > Mark's tree? In the latter case, what is broken? We've been using Mark's > > tree without issues, wondering what we missed? > > He's saying it's a fix for stable but it's just a cleanup and robustness > improvement in current kernels - when the patch 76d270364932 (ASoC: > topology: Check return value for snd_soc_add_dai_link()) was backported > by the bot the bot missed some other context which triggered bugs. > > Copying in Sasha and Greg for stable (not sure if the list works by > itself). How this was marked-up is fine, our scripts can easily handle it, thanks. greg k-h