From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Remove unused enum fuse_buf_copy_flags
Date: Thu, 23 Jan 2020 10:19:29 +0000 [thread overview]
Message-ID: <20200123101929.GC2698@work-vm> (raw)
In-Reply-To: <5E28F304.70602@cn.fujitsu.com>
* Xiao Yang (yangx.jy@cn.fujitsu.com) wrote:
> On 2020/1/23 2:52, Dr. David Alan Gilbert wrote:
> > I'm confused as to which version this patch is against; all the worlds I
> > can see don't take 'req' into fuse_buf_copy.
> Hi Dave,
>
> I just used the development branch:
> https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev
>
> I saw that fuse_buf_copy() still has 'req' parameter on this branch. Is it
> obsolete?
> https://gitlab.com/virtio-fs/qemu/blob/virtio-fs-dev/tools/virtiofsd/buffer.c#L270
OK, my mistake - the 'req' parameter is added late on, in the DAX
extensions; so I need to backport this cleanup before it.
I'll do that.
Dave
> Best Regards,
> Xiao Yang
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2020-01-23 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 2:40 [Virtio-fs] [PATCH] virtiofsd: Remove unused enum fuse_buf_copy_flags Xiao Yang
2020-01-22 16:34 ` Stefan Hajnoczi
2020-01-22 18:52 ` Dr. David Alan Gilbert
2020-01-23 1:12 ` Xiao Yang
2020-01-23 10:19 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123101929.GC2698@work-vm \
--to=dgilbert@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.