From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD65C2D0DB for ; Thu, 23 Jan 2020 14:17:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7C5220718 for ; Thu, 23 Jan 2020 14:17:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7C5220718 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B4516FD0E; Thu, 23 Jan 2020 14:17:33 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E9576E0AD for ; Thu, 23 Jan 2020 14:17:32 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jan 2020 06:16:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,354,1574150400"; d="scan'208";a="222353516" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga008.fm.intel.com with SMTP; 23 Jan 2020 06:16:45 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 23 Jan 2020 16:16:46 +0200 Date: Thu, 23 Jan 2020 16:16:46 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: <20200123141646.GU13686@intel.com> References: <20200123140004.14136-1-jani.nikula@intel.com> <20200123140004.14136-6-jani.nikula@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200123140004.14136-6-jani.nikula@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH RESEND 6/6] drm/i915/pm: use intel de functions for forcewake register access X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jan 23, 2020 at 04:00:04PM +0200, Jani Nikula wrote: > Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and > switch to using intel_de_read_fw() and intel_de_write_fw(), > respectively. > = > No functional changes. > = > Signed-off-by: Jani Nikula Only a few oddities spotted. Overall series lgtm For all Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_pm.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index 36d158d6c5b2..1cf909d8347b 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -5061,9 +5061,10 @@ static void skl_ddb_entry_write(struct drm_i915_pr= ivate *dev_priv, > const struct skl_ddb_entry *entry) > { > if (entry->end) > - I915_WRITE_FW(reg, (entry->end - 1) << 16 | entry->start); > + intel_de_write_fw(dev_priv, reg, > + (entry->end - 1) << 16 | entry->start); > else > - I915_WRITE_FW(reg, 0); > + intel_de_write_fw(dev_priv, reg, 0); > } > = > static void skl_write_wm_level(struct drm_i915_private *dev_priv, > @@ -5079,7 +5080,7 @@ static void skl_write_wm_level(struct drm_i915_priv= ate *dev_priv, > val |=3D level->plane_res_b; > val |=3D level->plane_res_l << PLANE_WM_LINES_SHIFT; > = > - I915_WRITE_FW(reg, val); > + intel_de_write_fw(dev_priv, reg, val); > } > = > void skl_write_plane_wm(struct intel_plane *plane, > -- = > 2.20.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx