From: Florian Westphal <fw@strlen.de>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Florian Westphal <fw@strlen.de>,
Praveen Chaudhary <praveen5582@gmail.com>,
pablo@netfilter.org, davem@davemloft.net, kadlec@netfilter.org,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Zhenggen Xu <zxu@linkedin.com>,
Andy Stracner <astracner@linkedin.com>
Subject: Re: [PATCH v3] [net]: Fix skb->csum update in inet_proto_csum_replace16().
Date: Thu, 23 Jan 2020 15:29:29 +0100 [thread overview]
Message-ID: <20200123142929.GV795@breakpoint.cc> (raw)
In-Reply-To: <1c1fc75d-e69c-f2f6-78ce-de9dc8aa89ca@iogearbox.net>
Daniel Borkmann <daniel@iogearbox.net> wrote:
> On 1/23/20 9:21 AM, Florian Westphal wrote:
> > So, AFAIU from what you're saying above the patch seems fine as-is and
> > just needs a more verbose commit message explaining why replace16()
> > doesn't update skb->csum while all the other ones do.
> >
> > Is that correct?
>
> Probably better a comment in the code to avoid confusion on why it's not done in
> inet_proto_csum_replace16() but all the other cases; mainly to avoid some folks
> in future sending random cleanup patches w/ removal attempts.
Makes sense, thanks!
Praveen, can you spin a v4 with a comment in replace16 that it
intentionally elides the skb->csum update because the function is
only used by ipv6?
Thanks!
next prev parent reply other threads:[~2020-01-23 14:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 22:52 [PATCH v3] [net]: Fix skb->csum update in inet_proto_csum_replace16() Praveen Chaudhary
2019-11-06 22:52 ` Praveen Chaudhary
2020-01-22 10:17 ` Daniel Borkmann
2020-01-22 11:43 ` Florian Westphal
2020-01-22 16:22 ` Daniel Borkmann
2020-01-23 8:21 ` Florian Westphal
2020-01-23 14:20 ` Daniel Borkmann
2020-01-23 14:29 ` Florian Westphal [this message]
2020-01-23 20:33 ` [PATCH v4] " Praveen Chaudhary
2020-01-23 20:33 ` Praveen Chaudhary
2020-01-24 19:04 ` Pablo Neira Ayuso
2020-01-23 20:50 ` [PATCH v3] " Praveen Chaudhary
2020-01-22 5:51 ` Praveen Chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123142929.GV795@breakpoint.cc \
--to=fw@strlen.de \
--cc=astracner@linkedin.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=praveen5582@gmail.com \
--cc=zxu@linkedin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.