From: Wei Yang <richardw.yang@linux.intel.com>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
mhocko@suse.com, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [v2 PATCH] mm: move_pages: report the number of non-attempted pages
Date: Fri, 24 Jan 2020 06:40:35 +0800 [thread overview]
Message-ID: <20200123224035.GA29851@richard> (raw)
In-Reply-To: <01fc1c6b-1cab-7f7e-7879-4fc7b0e4a231@linux.alibaba.com>
On Wed, Jan 22, 2020 at 07:56:50PM -0800, Yang Shi wrote:
>
>
>On 1/22/20 7:27 PM, Wei Yang wrote:
>> On Thu, Jan 23, 2020 at 07:38:51AM +0800, Yang Shi wrote:
>> > Since commit a49bd4d71637 ("mm, numa: rework do_pages_move"),
>> > the semantic of move_pages() was changed to return the number of
>> > non-migrated pages (failed to migration) and the call would be aborted
>> > immediately if migrate_pages() returns positive value. But it didn't
>> > report the number of pages that we even haven't attempted to migrate.
>> > So, fix it by including non-attempted pages in the return value.
>> >
>> First, we want to change the semantic of move_pages(2). The return value
>> indicates the number of pages we didn't managed to migrate?
>
>This is my understanding.
>
>>
>> Second, the return value from migrate_pages() doesn't mean the number of pages
>> we failed to migrate. For example, one -ENOMEM is returned on the first page,
>> migrate_pages() would return 1. But actually, no page successfully migrated.
>
>This would not happen at all since migrate_pages() would just return -ENOMEM
>instead of a positive value, right?
>
Oh, you are right.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2020-01-23 22:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 23:38 [v2 PATCH] mm: move_pages: report the number of non-attempted pages Yang Shi
2020-01-23 3:27 ` Wei Yang
2020-01-23 3:56 ` Yang Shi
2020-01-23 22:40 ` Wei Yang [this message]
2020-01-23 8:55 ` Michal Hocko
2020-01-23 22:56 ` Wei Yang
2020-01-24 6:46 ` Michal Hocko
2020-01-24 15:26 ` Wei Yang
2020-01-24 15:26 ` Wei Yang
2020-01-24 15:40 ` Michal Hocko
2020-01-24 23:19 ` Wei Yang
2020-01-24 17:48 ` Yang Shi
2020-01-24 23:20 ` Wei Yang
2020-01-23 22:59 ` Wei Yang
2020-01-23 23:36 ` Yang Shi
2020-01-23 23:44 ` Wei Yang
2020-01-27 9:55 ` Michal Hocko
2020-01-27 16:34 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123224035.GA29851@richard \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=stable@vger.kernel.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.