From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E7E3C2D0DB for ; Fri, 24 Jan 2020 09:48:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF9E421734 for ; Fri, 24 Jan 2020 09:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859313; bh=397TAFOZ9B5BamrBQvBNE0GIVGJqI2DAukQZQ861zZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oJ1UI+EDu6L895bMEqC3XEbj9DV+koW4SVpqAXj+cBGvQNh1cKzmC/OwSKHC5GWzk VkxNrKH5dFdgOlqjtCUU3lRxBABCStotvGAPFSmmakLV/yORjhU0wSgj9fI7WVCu9o cO64iueAdQlrLeUanyk80dQ8RQqNc6KXhE+kiKgg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387732AbgAXJsb (ORCPT ); Fri, 24 Jan 2020 04:48:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:48596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730051AbgAXJsa (ORCPT ); Fri, 24 Jan 2020 04:48:30 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 333D920718; Fri, 24 Jan 2020 09:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859309; bh=397TAFOZ9B5BamrBQvBNE0GIVGJqI2DAukQZQ861zZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k2DV5mibED9XdgXm1aib/tqp6NBlMaof48O92Lg3vY+gTzdrXq8FimVYRmoJS2rev SKq1s/oAjJE6BcGanWQ9c1vCvdQGFeWKRH8ZC7dx6fJzYgMsrYDGZwaaQ6TRVWIhAU dw/4KPSe/c6L9Hx0r5ACozmbdh6IfO6jJdhBgXLQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Danny Alexander , Johannes Berg , Luca Coelho , Sasha Levin Subject: [PATCH 4.14 076/343] iwlwifi: mvm: fix A-MPDU reference assignment Date: Fri, 24 Jan 2020 10:28:14 +0100 Message-Id: <20200124092929.865148569@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Berg [ Upstream commit 1f7698abedeeb3fef3cbcf78e16f925df675a179 ] The current code assigns the reference, and then goes to increment it if the toggle bit has changed. That way, we get Toggle 0 0 0 0 1 1 1 1 ID 1 1 1 1 1 2 2 2 Fix that by assigning the post-toggle ID to get Toggle 0 0 0 0 1 1 1 1 ID 1 1 1 1 2 2 2 2 Reported-by: Danny Alexander Signed-off-by: Johannes Berg Fixes: fbe4112791b8 ("iwlwifi: mvm: update mpdu metadata API") Signed-off-by: Luca Coelho Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c index 7fb8bbaf21420..1a12e829e98b0 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c @@ -871,12 +871,12 @@ void iwl_mvm_rx_mpdu_mq(struct iwl_mvm *mvm, struct napi_struct *napi, bool toggle_bit = phy_info & IWL_RX_MPDU_PHY_AMPDU_TOGGLE; rx_status->flag |= RX_FLAG_AMPDU_DETAILS; - rx_status->ampdu_reference = mvm->ampdu_ref; /* toggle is switched whenever new aggregation starts */ if (toggle_bit != mvm->ampdu_toggle) { mvm->ampdu_ref++; mvm->ampdu_toggle = toggle_bit; } + rx_status->ampdu_reference = mvm->ampdu_ref; } rcu_read_lock(); -- 2.20.1