From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0851CC2D0DB for ; Fri, 24 Jan 2020 09:55:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C89BC206D5 for ; Fri, 24 Jan 2020 09:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859720; bh=lXMmNVPGOzXutVT+BEzC2h53HK83CcbMiFQ/30mAHNo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BPwEtrrqnu9ixJsGqkt/CUwAOLjLnDFT/ueeXpipgGo8aIVa8g1TlvXqXeSZFLRwe ZrNx+tSaVUHw3riz/mLlBphSgZilLNMuYiOHhf11+pQTfigGG6fcroOy57TB+LLym9 MxObVwSOKTwEoCaAflfYx++XtoR+5gYhIah+O0Zk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388013AbgAXJzT (ORCPT ); Fri, 24 Jan 2020 04:55:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:58460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726701AbgAXJzS (ORCPT ); Fri, 24 Jan 2020 04:55:18 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F495206D5; Fri, 24 Jan 2020 09:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859718; bh=lXMmNVPGOzXutVT+BEzC2h53HK83CcbMiFQ/30mAHNo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pg6wlfp1I1ECo/QGJwECXwqXPIUpQzEErh9RcfmQj+kHG3rPyS5EW3YCIOUP2VNP5 Kb7WrF2QF3nMeABF3u1WydWjZrrM+ed/w9g7utgSx4Waaz8hlnQ5I6QdpwrfC6HRsv c0sK6p2RzqvUsfuzNGKvdsf2gGXfcTYrhHwUhoAc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Trond Myklebust , Anna Schumaker , Sasha Levin Subject: [PATCH 4.14 178/343] NFS: Dont interrupt file writeout due to fatal errors Date: Fri, 24 Jan 2020 10:29:56 +0100 Message-Id: <20200124092943.410476024@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit 14bebe3c90b326d2a0df78aed5e9de090c71d878 ] When flushing out dirty pages, the fact that we may hit fatal errors is not a reason to stop writeback. Those errors are reported through fsync(), not through the flush mechanism. Fixes: a6598813a4c5b ("NFS: Don't write back further requests if there...") Signed-off-by: Trond Myklebust Signed-off-by: Anna Schumaker Signed-off-by: Sasha Levin --- fs/nfs/write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 01b9d9341b541..ed3f5afc4ff7f 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -643,7 +643,7 @@ out: return ret; out_launder: nfs_write_error_remove_page(req); - return ret; + return 0; } static int nfs_do_writepage(struct page *page, struct writeback_control *wbc, -- 2.20.1