From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0AA2C32771 for ; Fri, 24 Jan 2020 09:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8986920838 for ; Fri, 24 Jan 2020 09:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858661; bh=n7H6OOhGFz0vpNcqfaDAEuG/THjzXxmW6Kp9OXvYMNs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PqzTZfREk0R14K7zGiTrprx561nvvvJo6wuG9vart6COiHajJeAFFNGSHh+eEVcKq yiatg2c9LIigjIRW6aGigr9h63mhtwt1eYYVhcvx1iBUyyeCE/epsbjM/hbp38rLlq My+1qNCdgeaV0RcTSkFNYBPXZ+NoLxyOLmokhup4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731217AbgAXJhl (ORCPT ); Fri, 24 Jan 2020 04:37:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:34970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729746AbgAXJhk (ORCPT ); Fri, 24 Jan 2020 04:37:40 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0ABD72070A; Fri, 24 Jan 2020 09:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579858659; bh=n7H6OOhGFz0vpNcqfaDAEuG/THjzXxmW6Kp9OXvYMNs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1sn+vFTDNZMn6GmiKbl5Wq3STNCSjlB4dxhlHZSPNttKusJccLr/E3syPl07K4F4p ZmKlFmLyOGocuFYe8YcGqyQUcJEDeaH+1kFzuRouHd6aBMkcIY06l+k/kt5n/7oWn+ NPWorgozVjbnQXnM28GjJPcBxUZJ7nkxhFfXex1o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alain Volmat , Pierre-Yves MORDRET , Wolfram Sang Subject: [PATCH 4.19 003/639] i2c: stm32f7: rework slave_id allocation Date: Fri, 24 Jan 2020 10:22:53 +0100 Message-Id: <20200124093047.507971823@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alain Volmat commit 52d3be711e065a97a57c2f2ffba3098748855bd6 upstream. The IP can handle two slave addresses. One address can either be 7 bits or 10 bits while the other can only be 7 bits. In order to ensure that a 10 bits address can always be allocated (assuming there is only one 7 bits address already allocated), pick up the 7-bits only address slot in priority when performing a 7-bits address allocation. Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support") Signed-off-by: Alain Volmat Reviewed-by: Pierre-Yves MORDRET Signed-off-by: Wolfram Sang Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-stm32f7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -1252,7 +1252,7 @@ static int stm32f7_i2c_get_free_slave_id * slave[0] supports 7-bit and 10-bit slave address * slave[1] supports 7-bit slave address only */ - for (i = 0; i < STM32F7_I2C_MAX_SLAVE; i++) { + for (i = STM32F7_I2C_MAX_SLAVE - 1; i >= 0; i--) { if (i == 1 && (slave->flags & I2C_CLIENT_PEC)) continue; if (!i2c_dev->slave[i]) {