From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4875C32771 for ; Fri, 24 Jan 2020 11:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C79720678 for ; Fri, 24 Jan 2020 11:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579866088; bh=IIbvXaX8A539yHpVEbWLR+RBbu4LU+EBaZ4KPYSjYVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GYqiE2NiM6NHEZooBnYV+nQKAa+z9V42+V6v5MrIBg14D4NQ4PpJ+NshApnWUbPx6 m4Clug2Kh8QmdLfCoNmJodey9ibedyD9pE9kKZ7UuablBUhZB2l+XNksB4gXvUt48b Ks/tbsK0qawyXPt7rdKDL/do95CWARxUCeeF5dC4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392026AbgAXLl0 (ORCPT ); Fri, 24 Jan 2020 06:41:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:56300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390276AbgAXLS4 (ORCPT ); Fri, 24 Jan 2020 06:18:56 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1CAA52075D; Fri, 24 Jan 2020 11:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864735; bh=IIbvXaX8A539yHpVEbWLR+RBbu4LU+EBaZ4KPYSjYVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S8cAgEUeF2Mr7nSTFw6bs7HuVWW6wt0bdoWcYdjnf1P0oI4N0SNNAQgw+B9n6XsuI eV+Y0HMyT4z/1Kk1SLR/AGZhQ2+qXdCN1JOlqVSuF5oYaO2h2XejRtIzdivpY0gC2R uL5N1kwU/l9U2EvHFTLJEXqKrZK2mbvlHzLhqPOE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Ulf Hansson , Sasha Levin Subject: [PATCH 4.19 351/639] mmc: core: fix possible use after free of host Date: Fri, 24 Jan 2020 10:28:41 +0100 Message-Id: <20200124093131.087638678@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit 8e1943af2986db42bee2b8dddf49a36cdb2e9219 ] In the function mmc_alloc_host, the function put_device is called to release allocated resources when mmc_gpio_alloc fails. Finally, the function pointed by host->class_dev.class->dev_release (i.e., mmc_host_classdev_release) is used to release resources including the host structure. However, after put_device, host is used and released again. Resulting in a use-after-free bug. Fixes: 1ed217194488 ("mmc: core: fix error path in mmc_host_alloc") Signed-off-by: Pan Bian Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/core/host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index f57f5de542064..dd1c14d8f6863 100644 --- a/drivers/mmc/core/host.c +++ b/drivers/mmc/core/host.c @@ -385,8 +385,6 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev) if (mmc_gpio_alloc(host)) { put_device(&host->class_dev); - ida_simple_remove(&mmc_host_ida, host->index); - kfree(host); return NULL; } -- 2.20.1