From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B8EC2D0DB for ; Fri, 24 Jan 2020 11:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE2D72087E for ; Fri, 24 Jan 2020 11:19:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864778; bh=4p+be+coHUlVVoDLul07RH1h3Nd28mtPbmVgvkwIqO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=leusNLeA7gLA3H3ltp0bzfnMevidZp0kv6VvBLehAO4pG0BF4Ju2nvXmJy1vd088R yR0u2iI0uO0j4lfE1iNkLPj8c8LCO7McXUy8/Ih3RawLWzEKQI5GOiZ83AGJQu9UL8 29Helwri3+WEsZBdqgtPnycR12MZdLb7da/DA/OA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390831AbgAXLTh (ORCPT ); Fri, 24 Jan 2020 06:19:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:57012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390598AbgAXLTf (ORCPT ); Fri, 24 Jan 2020 06:19:35 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A3DD2467F; Fri, 24 Jan 2020 11:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864774; bh=4p+be+coHUlVVoDLul07RH1h3Nd28mtPbmVgvkwIqO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RBRyEOYWvjDPhqFybONSYz5BS9T1s15QRIBhYqUQdx4pxZloalEeOQTfW5I/wHut3 aIganQEKsgW3F3TV2FmsVzVF7oZ8JEaUZVZvZpKOA9nOe7JbPmh39/xZGkXpETWZ+t 29QOHFFjigqK2m2GONNfXVsadfN7jc0P/KohGQmo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Howells , Sasha Levin Subject: [PATCH 4.19 354/639] afs: Fix the afs.cell and afs.volume xattr handlers Date: Fri, 24 Jan 2020 10:28:44 +0100 Message-Id: <20200124093131.451001271@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells [ Upstream commit c73aa4102f5b9f261a907c3b3df94cd2c478504d ] Fix the ->get handlers for the afs.cell and afs.volume xattrs to pass the source data size to memcpy() rather than target buffer size. Overcopying the source data occasionally causes the kernel to oops. Fixes: d3e3b7eac886 ("afs: Add metadata xattrs") Signed-off-by: David Howells Signed-off-by: Sasha Levin --- fs/afs/xattr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c index cfcc674e64a55..411f67c79f090 100644 --- a/fs/afs/xattr.c +++ b/fs/afs/xattr.c @@ -50,7 +50,7 @@ static int afs_xattr_get_cell(const struct xattr_handler *handler, return namelen; if (namelen > size) return -ERANGE; - memcpy(buffer, cell->name, size); + memcpy(buffer, cell->name, namelen); return namelen; } @@ -104,7 +104,7 @@ static int afs_xattr_get_volume(const struct xattr_handler *handler, return namelen; if (namelen > size) return -ERANGE; - memcpy(buffer, volname, size); + memcpy(buffer, volname, namelen); return namelen; } -- 2.20.1