From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E04C35242 for ; Fri, 24 Jan 2020 11:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 574C120704 for ; Fri, 24 Jan 2020 11:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865208; bh=r7IbhevZ3vbcrxTfXmNL6qpthsVQKciIUQJ7zwQ+h3A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ILQGRhFxr4nq+tDMFDRpE6HjL2IMSYrx7fd8twfJN9YEM1MtXiBsIMd35P9aOCB1d HLeprtnm6b2lZobrjoAbASxZFtx5d8vxWOcFKmXFi7VKY6zwBVfF7HO/kqA+M02BMP MWng8O3h4cXfuBbWU9lZ94p82sG4EhKdrn/hwZfE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391580AbgAXL0n (ORCPT ); Fri, 24 Jan 2020 06:26:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:41624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391573AbgAXL0j (ORCPT ); Fri, 24 Jan 2020 06:26:39 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12311214DB; Fri, 24 Jan 2020 11:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865198; bh=r7IbhevZ3vbcrxTfXmNL6qpthsVQKciIUQJ7zwQ+h3A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wnFIDbY2NExa9KjkhZ98Iw1vvuwpnGP23PLc7ETEORhoXF3UqVGaTvsGIadVmolEm ZG0o4Q29FQ28M4pnm3mOdvJl0LWONcnuAb60fv1fAOoYmdFn4vdwaLj6CeflquG6pt 8Q+H7sWowurbeHlDVVxzCLMERTm/pRGMBEsduPHQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joel Stanley , Alistair Popple , Eddie James , Sasha Levin Subject: [PATCH 4.19 467/639] fsi: sbefifo: Dont fail operations when in SBE IPL state Date: Fri, 24 Jan 2020 10:30:37 +0100 Message-Id: <20200124093145.849193289@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eddie James [ Upstream commit 7ce98fb6c53d2311b3e9faae90b1a9c1a96534db ] SBE fifo operations should be allowed while the SBE is in any of the "IPL" states. Operations should succeed in this state. Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO Reviewed-by: Joel Stanley Tested-by: Alistair Popple Signed-off-by: Eddie James Link: https://lore.kernel.org/r/1561575415-3282-1-git-send-email-eajames@linux.ibm.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/fsi/fsi-sbefifo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index ae861342626e3..9fa3959e08554 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -289,11 +289,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >> CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN: return -ESHUTDOWN; + case SBE_STATE_DMT: + return -EBUSY; case SBE_STATE_IPLING: case SBE_STATE_ISTEP: case SBE_STATE_MPIPL: - case SBE_STATE_DMT: - return -EBUSY; case SBE_STATE_RUNTIME: case SBE_STATE_DUMP: /* Not sure about that one */ break; -- 2.20.1