From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ECB4C2D0DB for ; Fri, 24 Jan 2020 11:34:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A92E21556 for ; Fri, 24 Jan 2020 11:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865643; bh=WXTOtUGRg2V2l9B4diXh0N+8ULEc7qKV7Gjz43dGa9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lJoe+PuEX0v3G6LSgqNKDRDxehLBQVodoUWEWrTuad7Rx3Ngp7j7cmp6i3uuQZDpE lSadZuSOa0iTHmQOGjTd9AkZsgNBOrwq/zlma5q6XttAJ/gcqgOyQUWP8pFB/UZF90 oMG9mvGVRRvgpUPjjL/CpQPO/txAeHvPpuZRfwAQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404673AbgAXLeC (ORCPT ); Fri, 24 Jan 2020 06:34:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:53722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404148AbgAXLd6 (ORCPT ); Fri, 24 Jan 2020 06:33:58 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82D84206D4; Fri, 24 Jan 2020 11:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865638; bh=WXTOtUGRg2V2l9B4diXh0N+8ULEc7qKV7Gjz43dGa9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GI9ujjeqmXPn4+y68F1dv47MXdw4gx0CEgB8KJHGQhJpwROP0iT5WBGBpgUJ/65l6 UCyrQ2jLps9X4VV3cTDMRfVlwaSR9Z7NSnhWQrirxP+P3iwQHfMixfkEP/kgGVZSAD Ys4+uFAMTx+L8G9RVUzwTocWLPelVjN1nCf8v384= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Martin Blumenstingl , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 580/639] net: stmmac: dwmac-meson8b: Fix signedness bug in probe Date: Fri, 24 Jan 2020 10:32:30 +0100 Message-Id: <20200124093202.129993726@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit f10210517a2f37feea2edf85eb34c98977265c16 ] The "dwmac->phy_mode" is an enum and in this context GCC treats it as an unsigned int so the error handling is never triggered. Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC") Signed-off-by: Dan Carpenter Reviewed-by: Martin Blumenstingl Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c index 94b46258e8ff8..0a17535f13ae4 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c @@ -355,7 +355,7 @@ static int meson8b_dwmac_probe(struct platform_device *pdev) dwmac->dev = &pdev->dev; dwmac->phy_mode = of_get_phy_mode(pdev->dev.of_node); - if (dwmac->phy_mode < 0) { + if ((int)dwmac->phy_mode < 0) { dev_err(&pdev->dev, "missing phy-mode property\n"); ret = -EINVAL; goto err_remove_config_dt; -- 2.20.1