From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC v6 3/5] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores
Date: Fri, 24 Jan 2020 11:53:11 +0800 [thread overview]
Message-ID: <202001241134.RSpx6QDP%lkp@intel.com> (raw)
In-Reply-To: <20200121063307.17221-4-parth@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 7243 bytes --]
Hi Parth,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on tip/sched/core]
[also build test WARNING on powerpc/next tip/auto-latest linux/master linus/master v5.5-rc7 next-20200122]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Parth-Shah/TurboSched-A-scheduler-for-sustaining-Turbo-Frequencies-for-longer-durations/20200124-041428
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git afa70d941f663c69c9a64ec1021bbcfa82f0e54a
config: sparc64-randconfig-a001-20200124 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/sparc/include/asm/bug.h:6:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from arch/sparc/include/asm/current.h:15,
from include/linux/sched.h:12,
from kernel/sched/sched.h:5,
from kernel/sched/fair.c:23:
kernel/sched/fair.c: In function 'is_small_bg_task':
kernel/sched/sched.h:2484:45: error: 'struct task_struct' has no member named 'latency_nice'; did you mean 'latency_record'?
#define is_bg_task(p) (bgtask_latency((p)->latency_nice))
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
>> kernel/sched/fair.c:5910:2: note: in expansion of macro 'if'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~
kernel/sched/sched.h:2484:25: note: in expansion of macro 'bgtask_latency'
#define is_bg_task(p) (bgtask_latency((p)->latency_nice))
^~~~~~~~~~~~~~
kernel/sched/fair.c:5910:6: note: in expansion of macro 'is_bg_task'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~~~~~~~~~
kernel/sched/sched.h:2483:39: error: 'MAX_LATENCY_NICE' undeclared (first use in this function); did you mean 'MAX_CFTYPE_NAME'?
#define bgtask_latency(lat) ((lat) == MAX_LATENCY_NICE)
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
>> kernel/sched/fair.c:5910:2: note: in expansion of macro 'if'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~
kernel/sched/sched.h:2484:25: note: in expansion of macro 'bgtask_latency'
#define is_bg_task(p) (bgtask_latency((p)->latency_nice))
^~~~~~~~~~~~~~
kernel/sched/fair.c:5910:6: note: in expansion of macro 'is_bg_task'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~~~~~~~~~
kernel/sched/sched.h:2483:39: note: each undeclared identifier is reported only once for each function it appears in
#define bgtask_latency(lat) ((lat) == MAX_LATENCY_NICE)
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
>> kernel/sched/fair.c:5910:2: note: in expansion of macro 'if'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~
kernel/sched/sched.h:2484:25: note: in expansion of macro 'bgtask_latency'
#define is_bg_task(p) (bgtask_latency((p)->latency_nice))
^~~~~~~~~~~~~~
kernel/sched/fair.c:5910:6: note: in expansion of macro 'is_bg_task'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~~~~~~~~~
kernel/sched/sched.h:2484:45: error: 'struct task_struct' has no member named 'latency_nice'; did you mean 'latency_record'?
#define is_bg_task(p) (bgtask_latency((p)->latency_nice))
^
include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
>> kernel/sched/fair.c:5910:2: note: in expansion of macro 'if'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~
kernel/sched/sched.h:2484:25: note: in expansion of macro 'bgtask_latency'
#define is_bg_task(p) (bgtask_latency((p)->latency_nice))
^~~~~~~~~~~~~~
kernel/sched/fair.c:5910:6: note: in expansion of macro 'is_bg_task'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~~~~~~~~~
kernel/sched/sched.h:2484:45: error: 'struct task_struct' has no member named 'latency_nice'; did you mean 'latency_record'?
#define is_bg_task(p) (bgtask_latency((p)->latency_nice))
^
include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value'
(cond) ? \
^~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~~~~~~~~~~~
>> kernel/sched/fair.c:5910:2: note: in expansion of macro 'if'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~
kernel/sched/sched.h:2484:25: note: in expansion of macro 'bgtask_latency'
#define is_bg_task(p) (bgtask_latency((p)->latency_nice))
^~~~~~~~~~~~~~
kernel/sched/fair.c:5910:6: note: in expansion of macro 'is_bg_task'
if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
^~~~~~~~~~
vim +/if +5910 kernel/sched/fair.c
5903
5904 /*
5905 * Classify small background tasks with higher latency_nice value for task
5906 * packing.
5907 */
5908 static inline bool is_small_bg_task(struct task_struct *p)
5909 {
> 5910 if (is_bg_task(p) && (task_util(p) > (SCHED_CAPACITY_SCALE >> 3)))
5911 return true;
5912
5913 return false;
5914 }
5915
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24763 bytes --]
next prev parent reply other threads:[~2020-01-24 3:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 6:33 [RFC v6 0/5] TurboSched: A scheduler for sustaining Turbo Frequencies for longer durations Parth Shah
2020-01-21 6:33 ` [RFC v6 1/5] sched: Introduce switch to enable TurboSched for task packing Parth Shah
2020-01-22 21:37 ` Tim Chen
2020-01-23 6:35 ` Parth Shah
2020-01-24 2:14 ` kbuild test robot
2020-01-21 6:33 ` [RFC v6 2/5] sched/core: Update turbo_sched count only when required Parth Shah
2020-01-24 2:28 ` kbuild test robot
2020-01-24 2:36 ` kbuild test robot
2020-01-21 6:33 ` [RFC v6 3/5] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores Parth Shah
2020-01-24 0:30 ` kbuild test robot
2020-01-24 3:53 ` kbuild test robot [this message]
2020-01-27 9:43 ` [RFC PATCH] sched/fair: __pcpu_scope_turbo_sched_mask can be static kbuild test robot
2020-01-21 6:33 ` [RFC v6 4/5] sched/fair: Provide arch hook to find domain for non idle core search scan Parth Shah
2020-01-21 6:33 ` [RFC v6 5/5] powerpc: Set turbo domain to NUMA node for task packing Parth Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001241134.RSpx6QDP%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.