All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Niklas Cassel <nks@flawful.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] power: avs: qcom-cpr: add a printout after the driver has been initialized
Date: Fri, 24 Jan 2020 09:10:17 -0800	[thread overview]
Message-ID: <20200124171017.GY1511@yoga> (raw)
In-Reply-To: <20200113200258.18031-1-nks@flawful.org>

On Mon 13 Jan 12:02 PST 2020, Niklas Cassel wrote:

> In order to easier inform the user that the driver has been initialized
> successfully, add a printout after the driver has been initialized.
> 
> At the same time, remove a dev_dbg() that is now redundant.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
>  drivers/power/avs/qcom-cpr.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 9192fb747653..b158a684d05c 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -1547,8 +1547,6 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
>  		goto unlock;
>  	}
>  
> -	dev_dbg(drv->dev, "number of OPPs: %d\n", drv->num_corners);
> -
>  	drv->corners = devm_kcalloc(drv->dev, drv->num_corners,
>  				    sizeof(*drv->corners),
>  				    GFP_KERNEL);
> @@ -1586,6 +1584,9 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
>  				   acc_desc->enable_mask,
>  				   acc_desc->enable_mask);
>  
> +	dev_info(drv->dev, "driver initialized with %u OPPs\n",
> +		 drv->num_corners);
> +
>  unlock:
>  	mutex_unlock(&drv->lock);
>  
> -- 
> 2.24.1
> 

      reply	other threads:[~2020-01-24 17:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 20:02 [PATCH] power: avs: qcom-cpr: add a printout after the driver has been initialized Niklas Cassel
2020-01-24 17:10 ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200124171017.GY1511@yoga \
    --to=bjorn.andersson@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nks@flawful.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.