From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 2/4] io-wq: add 'id' to io_wq
Date: Fri, 24 Jan 2020 14:31:39 -0700 [thread overview]
Message-ID: <20200124213141.22108-3-axboe@kernel.dk> (raw)
In-Reply-To: <20200124213141.22108-1-axboe@kernel.dk>
Add each io_wq to a global list, and assign an id for each of them. This
is in preparation for attaching to an existing io_wq, rather than
creating a new one.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
fs/io-wq.c | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/fs/io-wq.c b/fs/io-wq.c
index 54e270ae12ab..51b3677d6fbd 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -16,9 +16,14 @@
#include <linux/slab.h>
#include <linux/kthread.h>
#include <linux/rculist_nulls.h>
+#include <linux/idr.h>
#include "io-wq.h"
+static LIST_HEAD(wq_list);
+static DEFINE_MUTEX(wq_lock);
+static DEFINE_IDR(wq_idr);
+
#define WORKER_IDLE_TIMEOUT (5 * HZ)
enum {
@@ -115,6 +120,8 @@ struct io_wq {
struct completion done;
refcount_t use_refs;
+ struct list_head wq_list;
+ unsigned int id;
};
static bool io_worker_get(struct io_worker *worker)
@@ -1076,6 +1083,15 @@ struct io_wq *io_wq_create(unsigned bounded, struct io_wq_data *data)
goto err;
}
refcount_set(&wq->use_refs, 1);
+
+ /* if we're out of IDs or fail to get one, use 0 */
+ mutex_lock(&wq_lock);
+ wq->id = idr_alloc(&wq_idr, wq, 1, INT_MAX, GFP_KERNEL);
+ if (wq->id < 0)
+ wq->id = 0;
+
+ list_add(&wq->wq_list, &wq_list);
+ mutex_unlock(&wq_lock);
reinit_completion(&wq->done);
return wq;
}
@@ -1119,6 +1135,13 @@ static void __io_wq_destroy(struct io_wq *wq)
void io_wq_destroy(struct io_wq *wq)
{
- if (refcount_dec_and_test(&wq->use_refs))
+ if (refcount_dec_and_test(&wq->use_refs)) {
+ mutex_lock(&wq_lock);
+ if (wq->id)
+ idr_remove(&wq_idr, wq->id);
+ list_del(&wq->wq_list);
+ mutex_unlock(&wq_lock);
+
__io_wq_destroy(wq);
+ }
}
--
2.25.0
next prev parent reply other threads:[~2020-01-24 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 21:31 [PATCHSET v2 0/4] Add support for shared io-wq backends Jens Axboe
2020-01-24 21:31 ` [PATCH 1/4] io-wq: make the io_wq ref counted Jens Axboe
2020-01-24 21:31 ` Jens Axboe [this message]
2020-01-24 21:31 ` [PATCH 3/4] io-wq: allow lookup of existing io_wq with given id Jens Axboe
2020-01-24 21:31 ` [PATCH 4/4] io_uring: add support for sharing kernel io-wq workqueue Jens Axboe
2020-01-25 7:45 ` Stefan Metzmacher
2020-01-25 16:44 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-01-23 23:16 [PATCHSET 0/4] Add support for shared io-wq backends Jens Axboe
2020-01-23 23:16 ` [PATCH 2/4] io-wq: add 'id' to io_wq Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124213141.22108-3-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.