From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18BCAC2D0CE for ; Fri, 24 Jan 2020 22:28:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7AA32075D for ; Fri, 24 Jan 2020 22:28:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7AA32075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BEF06E455; Fri, 24 Jan 2020 22:28:51 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D164B6E455 for ; Fri, 24 Jan 2020 22:28:49 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 14:28:49 -0800 X-IronPort-AV: E=Sophos;i="5.70,359,1574150400"; d="scan'208";a="251425113" Received: from rdvivi-losangeles.jf.intel.com (HELO intel.com) ([10.165.21.202]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 14:28:48 -0800 Date: Fri, 24 Jan 2020 14:30:19 -0800 From: Rodrigo Vivi To: Chris Wilson Message-ID: <20200124223019.GA3529069@intel.com> References: <157987409843.2524.2998401254997919669@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <157987409843.2524.2998401254997919669@skylake-alporthouse-com> Subject: Re: [Intel-gfx] [RFC 00/33] drm/i915/display: mass conversion to intel_de_*() register accessors X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, Lucas De Marchi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jan 24, 2020 at 01:54:58PM +0000, Chris Wilson wrote: > Quoting Jani Nikula (2020-01-24 13:25:21) > > Hey all, > > > > So I sent [1] to convert some forcewake register accessors... but what if we > > just ripped off the bandage once and for all? It's going to hurt, a lot, but > > we'd get it done. > > > > This completely rids us of the "dev_priv" dependency in display/. > > > > All the patches here are per-file and independent of each other. We could also > > pick and apply the ones that are least likely to conflict. > > > > Opinions? > > > > > > BR, > > Jani. > > > > > > PS. I didn't bother looking at the checkpatch warnings this may generate at this > > point. I just used the --linux-spacing option for spatch, and closed my eyes. I > > completely scripted the generation of the series, apart from just a couple of > > build fixes. > > Yup. Suck it all in, clean up with the usual code refreshes. > Schadenfreude-by: Chris Wilson > > I've looked at a couple of patches to confirm that it does appear purely > mechanical, > Acked-by: Chris Wilson Since it is purely mechanical with coccinelle, why not to make in only one patch? Anyway: Acked-by: Rodrigo Vivi > -Chris > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx