From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@gmail.com>
Cc: linux-ext4@vger.kernel.org, darrick.wong@oracle.com
Subject: Re: [PATCH 1/2] ext4: fix symbolic enum printing in trace output
Date: Sat, 25 Jan 2020 02:03:18 -0500 [thread overview]
Message-ID: <20200125070318.GC1108497@mit.edu> (raw)
In-Reply-To: <20191114200147.1073-1-dmonakhov@gmail.com>
On Thu, Nov 14, 2019 at 08:01:46PM +0000, Dmitry Monakhov wrote:
> Trace's macro __print_flags() produce raw event's decraration w/o knowing actual
> flags value
>
> cat /sys/kernel/debug/tracing/events/ext4/ext4_ext_map_blocks_exit/format
> ..
> __print_flags(REC->mflags, "", { (1 << BH_New),
>
> For that reason we have to explicitly define it via special macro TRACE_DEFINE_ENUM()
> Also add missed EXTENT_STATUS_REFERENCED flag.
>
> #Before patch
> ext4:ext4_ext_map_blocks_exit: dev 253,0 ino 2 flags lblk 0 pblk 4177 len 1 mflags 0x20 ret 1
> ext4:ext4_ext_map_blocks_exit: dev 253,0 ino 12 flags CREATE lblk 0 pblk 34304 len 1 mflags 0x60 ret 1
>
> #With patch
> ext4:ext4_ext_map_blocks_exit: dev 253,0 ino 2 flags lblk 0 pblk 4177 len 1 mflags M ret 1
> ext4:ext4_ext_map_blocks_exit: dev 253,0 ino 12 flags CREATE lblk 0 pblk 34816 len 1 mflags NM ret 1
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@gmail.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2020-01-25 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 20:01 [PATCH 1/2] ext4: fix symbolic enum printing in trace output Dmitry Monakhov
2019-11-14 20:01 ` [PATCH 2/2] ext4: fix extent_status trace points Dmitry Monakhov
2020-01-25 7:03 ` Theodore Y. Ts'o
2019-11-14 21:01 ` [PATCH 1/2] ext4: fix symbolic enum printing in trace output Darrick J. Wong
2020-01-25 7:03 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125070318.GC1108497@mit.edu \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=dmonakhov@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.