From: Jason Gunthorpe <jgg@mellanox.com>
To: Devesh Sharma <devesh.sharma@broadcom.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH for-next 2/7] RDMA/bnxt_re: Replace chip context structure with pointer
Date: Sat, 25 Jan 2020 18:03:01 +0000 [thread overview]
Message-ID: <20200125180252.GD4616@mellanox.com> (raw)
In-Reply-To: <1579845165-18002-3-git-send-email-devesh.sharma@broadcom.com>
On Fri, Jan 24, 2020 at 12:52:40AM -0500, Devesh Sharma wrote:
> static void bnxt_re_destroy_chip_ctx(struct bnxt_re_dev *rdev)
> {
> + struct bnxt_qplib_chip_ctx *chip_ctx;
> +
> + if (!rdev->chip_ctx)
> + return;
> + chip_ctx = rdev->chip_ctx;
> + rdev->chip_ctx = NULL;
> rdev->rcfw.res = NULL;
> rdev->qplib_res.cctx = NULL;
> + kfree(chip_ctx);
> }
Are you sure this kfree is late enough? I couldn't deduce if it was
really safe to NULL chip_ctx here.
IMHO you should free it as part of the ib device dealloc.
Jason
next prev parent reply other threads:[~2020-01-25 18:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 5:52 [PATCH for-next 0/7] Refactor control path of bnxt_re driver Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 1/7] RDMA/bnxt_re: Refactor queue pair creation code Devesh Sharma
2020-01-24 11:23 ` Leon Romanovsky
2020-01-25 17:03 ` Devesh Sharma
2020-01-25 18:50 ` Leon Romanovsky
2020-01-27 7:39 ` Devesh Sharma
2020-01-30 6:04 ` Devesh Sharma
2020-01-25 17:46 ` Jason Gunthorpe
2020-01-27 8:13 ` Devesh Sharma
2020-01-27 8:16 ` Devesh Sharma
2020-01-27 9:27 ` Leon Romanovsky
2020-01-27 9:26 ` Leon Romanovsky
2020-01-27 11:31 ` Devesh Sharma
2020-01-30 6:04 ` Devesh Sharma
2020-01-30 13:37 ` Parav Pandit
2020-01-30 16:03 ` Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 2/7] RDMA/bnxt_re: Replace chip context structure with pointer Devesh Sharma
2020-01-25 18:03 ` Jason Gunthorpe [this message]
2020-01-27 7:39 ` Devesh Sharma
2020-01-27 8:04 ` Leon Romanovsky
2020-01-27 11:17 ` Devesh Sharma
2020-01-28 20:15 ` Jason Gunthorpe
2020-01-30 6:05 ` Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 3/7] RDMA/bnxt_re: Refactor hardware queue memory allocation Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 4/7] RDMA/bnxt_re: Refactor net ring allocation function Devesh Sharma
2020-01-26 14:29 ` Leon Romanovsky
2020-01-27 7:40 ` Devesh Sharma
2020-01-27 8:02 ` Leon Romanovsky
2020-01-27 11:25 ` Devesh Sharma
2020-01-27 12:44 ` Leon Romanovsky
2020-01-27 14:14 ` Devesh Sharma
2020-01-28 18:09 ` Jason Gunthorpe
2020-01-28 0:35 ` Jason Gunthorpe
2020-01-28 2:43 ` Devesh Sharma
2020-01-28 18:09 ` Jason Gunthorpe
2020-01-29 8:29 ` Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 5/7] RDMA/bnxt_re: Refactor command queue management code Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 6/7] RDMA/bnxt_re: Refactor notification " Devesh Sharma
2020-01-24 5:52 ` [PATCH for-next 7/7] RDMA/bnxt_re: Refactor doorbell management functions Devesh Sharma
2020-01-25 18:04 ` [PATCH for-next 0/7] Refactor control path of bnxt_re driver Jason Gunthorpe
2020-01-27 7:39 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125180252.GD4616@mellanox.com \
--to=jgg@mellanox.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.