From: Jason <jgg@ziepe.ca>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Michal Kalderon <michal.kalderon@marvell.com>,
Gal Pressman <galpress@amazon.com>
Subject: Re: [PATCH] RDMA/core: Ensure that rdma_user_mmap_entry_remove() is a fence
Date: Sat, 25 Jan 2020 14:52:14 -0400 [thread overview]
Message-ID: <20200125185214.GA15456@jggl> (raw)
In-Reply-To: <20200115202041.GA17199@ziepe.ca>
On Wed, Jan 15, 2020 at 08:20:44PM +0000, Jason Gunthorpe wrote:
> The set of entry->driver_removed is missing locking, protect it with
> xa_lock() which is held by the only reader.
>
> Otherwise readers may continue to see driver_removed = false after
> rdma_user_mmap_entry_remove() returns and may continue to try and
> establish new mmaps.
>
> Fixes: 3411f9f01b76 ("RDMA/core: Create mmap database and cookie helper functions")
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> Reviewed-by: Gal Pressman <galpress@amazon.com>
> Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
> ---
> drivers/infiniband/core/ib_core_uverbs.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to for-next
Jason
prev parent reply other threads:[~2020-01-25 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:20 [PATCH] RDMA/core: Ensure that rdma_user_mmap_entry_remove() is a fence Jason Gunthorpe
2020-01-16 8:51 ` Gal Pressman
2020-01-16 13:05 ` Jason Gunthorpe
2020-01-20 11:07 ` Michal Kalderon
2020-01-25 18:52 ` Jason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125185214.GA15456@jggl \
--to=jgg@ziepe.ca \
--cc=galpress@amazon.com \
--cc=jgg@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michal.kalderon@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.