From: Sasha Levin <sashal@kernel.org>
To: Michael Kelley <mikelley@microsoft.com>
Cc: Dexuan Cui <decui@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Andrea Parri <Andrea.Parri@microsoft.com>,
Wei Hu <weh@microsoft.com>
Subject: Re: [PATCH v2] Drivers: hv: vmbus: Ignore CHANNELMSG_TL_CONNECT_RESULT(23)
Date: Sat, 25 Jan 2020 16:42:12 -0500 [thread overview]
Message-ID: <20200125214212.GL1706@sasha-vm> (raw)
In-Reply-To: <MW2PR2101MB1052AEC27FF7287F5BA81C91D7320@MW2PR2101MB1052.namprd21.prod.outlook.com>
On Mon, Jan 20, 2020 at 12:51:51AM +0000, Michael Kelley wrote:
>From: Dexuan Cui <decui@microsoft.com> Sent: Sunday, January 19, 2020 3:29 PM
>>
>> When a Linux hv_sock app tries to connect to a Service GUID on which no
>> host app is listening, a recent host (RS3+) sends a
>> CHANNELMSG_TL_CONNECT_RESULT (23) message to Linux and this triggers such
>> a warning:
>>
>> unknown msgtype=23
>> WARNING: CPU: 2 PID: 0 at drivers/hv/vmbus_drv.c:1031 vmbus_on_msg_dpc
>>
>> Actually Linux can safely ignore the message because the Linux app's
>> connect() will time out in 2 seconds: see VSOCK_DEFAULT_CONNECT_TIMEOUT
>> and vsock_stream_connect(). We don't bother to make use of the message
>> because: 1) it's only supported on recent hosts; 2) a non-trivial effort
>> is required to use the message in Linux, but the benefit is small.
>>
>> So, let's not see the warning by silently ignoring the message.
>>
>> Signed-off-by: Dexuan Cui <decui@microsoft.com>
>> ---
>>
>> In v2 (followed Michael Kelley's suggestions):
>> Removed the redundant code in vmbus_onmessage()
>> Added the new enries into channel_message_table[].
>>
>> drivers/hv/channel_mgmt.c | 21 +++++++--------------
>> drivers/hv/vmbus_drv.c | 4 ++++
>> include/linux/hyperv.h | 2 ++
>> 3 files changed, 13 insertions(+), 14 deletions(-)
>>
>
>Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Queued up, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2020-01-25 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 23:29 [PATCH v2] Drivers: hv: vmbus: Ignore CHANNELMSG_TL_CONNECT_RESULT(23) Dexuan Cui
2020-01-20 0:51 ` Michael Kelley
2020-01-25 21:42 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125214212.GL1706@sasha-vm \
--to=sashal@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=Andrea.Parri@microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.