All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Antinoja <antti@fennosys.fi>
To: linux-wireless@vger.kernel.org
Cc: <amitkarwar@gmail.com>, <nishants@marvell.com>,
	<gbhat@marvell.com>, <huxinming820@gmail.com>
Subject: mwifiex: exit on error - without calling rcu_read_unlock()
Date: Sun, 26 Jan 2020 21:18:44 +0800	[thread overview]
Message-ID: <20200126211844.0dd4a761@gail> (raw)

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

Please refer to:

* https://grsecurity.net/the_life_of_a_bad_security_fix
* https://github.com/torvalds/linux/commit/3d94a4a8373bf5f45cf5f939e88b8354dbf2311b#diff-c5e2f17b92b8e8f30306c5dd148d874f

At quick glance it looks to me like the issue really is there: Not calling rcu_read_unlock() before return on line 237.

Happy Lunar New Year to everyone! =) 

Cheers,
Antti

-- 
Antti Antinoja            諾亞安提

Fennosys Oy
PL 14
10211 Inkoo
Finland

25141 新北市淡水區蕃薯裡 水碓25巷22號1樓
芬諾實有限公司

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2020-01-26 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-26 13:18 Antti Antinoja [this message]
2020-01-26 14:15 ` mwifiex: exit on error - without calling rcu_read_unlock() Kalle Valo
2020-01-26 15:04   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200126211844.0dd4a761@gail \
    --to=antti@fennosys.fi \
    --cc=amitkarwar@gmail.com \
    --cc=gbhat@marvell.com \
    --cc=huxinming820@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nishants@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.