From: Andrew Lunn <andrew@lunn.ch>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
Florian Fainelli <f.fainelli@gmail.com>,
John Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET request
Date: Mon, 27 Jan 2020 02:04:22 +0100 [thread overview]
Message-ID: <20200127010422.GD12816@lunn.ch> (raw)
In-Reply-To: <844bf6bf518640fbfc67b5dd7976d9e8683c2d2d.1580075977.git.mkubecek@suse.cz>
> + ret = ethnl_parse_header(&req_info, tb[ETHTOOL_A_DEBUG_HEADER],
> + genl_info_net(info), info->extack, true);
> + dev_put(dev);
Hi Michal
While reviewing this patch i noticed this dev_put() and wondered where
the dev_get() was. It is hiding inside ethnl_parse_header(). The
documentation does make it clear it takes a reference on the device,
but how many people read the documentation? I would not be too
surprised if at some point in the future we have bugs from missing
dev_put().
Could we make this a bit more explicit by calling it
ethnl_parse_header_dev_get(). It is rather long though.
Andrew
next prev parent reply other threads:[~2020-01-27 1:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 22:10 [PATCH net-next 0/7] ethtool netlink interface, part 2 Michal Kubecek
2020-01-26 22:11 ` [PATCH net-next 1/7] ethtool: fix kernel-doc descriptions Michal Kubecek
2020-01-26 22:11 ` [PATCH net-next 2/7] ethtool: provide message mask with DEBUG_GET request Michal Kubecek
2020-01-26 23:52 ` Andrew Lunn
2020-01-26 22:11 ` [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET request Michal Kubecek
2020-01-27 0:22 ` Andrew Lunn
2020-01-27 6:23 ` Michal Kubecek
2020-01-27 1:04 ` Andrew Lunn [this message]
2020-01-27 6:24 ` Michal Kubecek
2020-01-26 22:11 ` [PATCH net-next 4/7] ethtool: add DEBUG_NTF notification Michal Kubecek
2020-01-27 1:17 ` Andrew Lunn
2020-01-26 22:11 ` [PATCH net-next 5/7] ethtool: provide WoL settings with WOL_GET request Michal Kubecek
2020-01-27 2:11 ` Andrew Lunn
2020-01-26 22:11 ` [PATCH net-next 6/7] ethtool: set wake-on-lan settings with WOL_SET request Michal Kubecek
2020-01-26 22:11 ` [PATCH net-next 7/7] ethtool: add WOL_NTF notification Michal Kubecek
2020-01-26 23:34 ` [PATCH net-next 0/7] ethtool netlink interface, part 2 Andrew Lunn
2020-01-27 7:30 ` Michal Kubecek
2020-01-27 9:40 ` David Miller
2020-01-27 9:57 ` Michal Kubecek
2020-01-27 10:27 ` David Miller
2020-01-27 10:32 ` David Miller
2020-01-27 13:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127010422.GD12816@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.