From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46288C33CB1 for ; Mon, 27 Jan 2020 14:00:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11D9E205F4 for ; Mon, 27 Jan 2020 14:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Anm0ycSO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="n2LAN2Q8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11D9E205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zua1m0SvxFT5dzEhEMw2RVkTun1RbouH5uwWqdnl0r8=; b=Anm0ycSOULC6FT egZ5+9pEn7kp5ruTrvhlrvJaw+Ai6uuBqzCt/Y3jhCUwPRUbmPtKBaj1jU9ypEUtBIWEHPm2nsC1Y 3SAf/fyYc0JLL3UtTaGIpnRqHRxcFpaU+IaO/aTFdYRqjWDac3eoiwkUmslXw9ZvTIekuAbO23NQ0 9NeD1eglFqkw0eq4Dc1j5HNwbaunvvT6coEAUYhFYTGaiYM2rG9Qt/t8wvW+eAPAqqQh+hxc45i+R AkJKSqJVjpqm5YKHXlQTwWuE8TkqaXcck1PHlKTedjaiZSh734a6UEQjsbo/90zngr26U9GnvRXU2 uFAS2mUftYoJ2onJP3wA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iw4wc-00069O-90; Mon, 27 Jan 2020 14:00:50 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iw4wa-00068j-22 for linux-arm-kernel@lists.infradead.org; Mon, 27 Jan 2020 14:00:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S0oCkFJi5GJ0pOrckJdOjtGxi2RubX2p/f+d/hw//6w=; b=n2LAN2Q86IiwsDYj1Zwq6Buh2K 7Wdygzr06W4xlwMGl6JzgXacepLqP93mvOxqsiXfLRolQU4hNcWcrT7KwJqKlTKGbrWmD2i/SfxvO 4//Xmnt1oqXftdLBbd08Jh6YZRzfyzzrX7iNXHa8kUt00SR6ph1jvqsvblSHDoCPSYvQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1iw4wQ-0006YJ-LN; Mon, 27 Jan 2020 15:00:38 +0100 Date: Mon, 27 Jan 2020 15:00:38 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Subject: Re: [RFC net-next 6/8] net: phylink: Configure MAC/PCS when link is up without PHY Message-ID: <20200127140038.GD13647@lunn.ch> References: <9a2136885d9a892ff170be88fdffeda82c778a10.1580122909.git.Jose.Abreu@synopsys.com> <20200127112102.GT25745@shell.armlinux.org.uk> <20200127114600.GU25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200127114600.GU25745@shell.armlinux.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200127_060048_106231_F72752FF X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , Joao Pinto , Alexandre Torgue , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , Florian Fainelli , Maxime Coquelin , Jakub Kicinski , Giuseppe Cavallaro , "David S. Miller" , "linux-arm-kernel@lists.infradead.org" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Yes, I realise that, but it comes with the expense of potentially > breaking mvneta and mvpp2, where the settings are automatically > passed between the PCS and MAC in hardware. I also believe DSA > works around this, and I need to look at that. Hi Russell The mv88e6xxx driver has code for when SGMII is used. It transfers the negotiated speed from the PCS to the MAC. But it recently turned out something like this is also needed for other link modes involving the SERDES. It used to work, i think because Phylink would initially configure the MAC approximately right, or the mv88e6xxx driver was looking at phylink state it should not. But it no longer works. I would like to see a generic solution, and would be happy to remove the current SGMII code when you have something to replace it. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E83C2D0DB for ; Mon, 27 Jan 2020 14:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E01021739 for ; Mon, 27 Jan 2020 14:00:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="n2LAN2Q8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729098AbgA0OAs (ORCPT ); Mon, 27 Jan 2020 09:00:48 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55974 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727430AbgA0OAr (ORCPT ); Mon, 27 Jan 2020 09:00:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S0oCkFJi5GJ0pOrckJdOjtGxi2RubX2p/f+d/hw//6w=; b=n2LAN2Q86IiwsDYj1Zwq6Buh2K 7Wdygzr06W4xlwMGl6JzgXacepLqP93mvOxqsiXfLRolQU4hNcWcrT7KwJqKlTKGbrWmD2i/SfxvO 4//Xmnt1oqXftdLBbd08Jh6YZRzfyzzrX7iNXHa8kUt00SR6ph1jvqsvblSHDoCPSYvQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1iw4wQ-0006YJ-LN; Mon, 27 Jan 2020 15:00:38 +0100 Date: Mon, 27 Jan 2020 15:00:38 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Jose Abreu , "netdev@vger.kernel.org" , Joao Pinto , Giuseppe Cavallaro , Alexandre Torgue , "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Florian Fainelli , Heiner Kallweit , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC net-next 6/8] net: phylink: Configure MAC/PCS when link is up without PHY Message-ID: <20200127140038.GD13647@lunn.ch> References: <9a2136885d9a892ff170be88fdffeda82c778a10.1580122909.git.Jose.Abreu@synopsys.com> <20200127112102.GT25745@shell.armlinux.org.uk> <20200127114600.GU25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127114600.GU25745@shell.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yes, I realise that, but it comes with the expense of potentially > breaking mvneta and mvpp2, where the settings are automatically > passed between the PCS and MAC in hardware. I also believe DSA > works around this, and I need to look at that. Hi Russell The mv88e6xxx driver has code for when SGMII is used. It transfers the negotiated speed from the PCS to the MAC. But it recently turned out something like this is also needed for other link modes involving the SERDES. It used to work, i think because Phylink would initially configure the MAC approximately right, or the mv88e6xxx driver was looking at phylink state it should not. But it no longer works. I would like to see a generic solution, and would be happy to remove the current SGMII code when you have something to replace it. Andrew