From: Kalle Valo <kvalo@codeaurora.org>
To: m1s5p6688@gmail.com
Cc: linux-wireless@vger.kernel.org, amitkarwar@gmail.com,
nishants@marvell.com, gbhat@marvell.com, huxinming820@gmail.com
Subject: Re: [PATCH 1/2] mwifiex: Fix possible buffer overflows in mwifiex_ret_wmm_get_status()
Date: Mon, 27 Jan 2020 14:34:52 +0000 (UTC) [thread overview]
Message-ID: <20200127143452.B0CF8C4479C@smtp.codeaurora.org> (raw)
In-Reply-To: <20200102023927.4687-2-m1s5p6688@gmail.com>
m1s5p6688@gmail.com wrote:
> From: Qing Xu <m1s5p6688@gmail.com>
>
> mwifiex_ret_wmm_get_status() calls memcpy() without checking the
> destination size.Since the source is given from remote AP which
> contains illegal wmm elements , this may trigger a heap buffer
> overflow.
> Fix it by putting the length check before calling memcpy().
>
> Signed-off-by: Qing Xu <m1s5p6688@gmail.com>
2 patches applied to wireless-drivers.git, thanks.
3a9b153c5591 mwifiex: Fix possible buffer overflows in mwifiex_ret_wmm_get_status()
b70261a288ea mwifiex: Fix possible buffer overflows in mwifiex_cmd_append_vsie_tlv()
--
https://patchwork.kernel.org/patch/11315253/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-01-27 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 2:39 [PATCH 0/2] Fix two possible Buffer overflow in mwifiex m1s5p6688
2020-01-02 2:39 ` [PATCH 1/2] mwifiex: Fix possible buffer overflows in mwifiex_ret_wmm_get_status() m1s5p6688
2020-01-27 14:34 ` Kalle Valo [this message]
2020-01-02 2:39 ` [PATCH 2/2] mwifiex: Fix possible buffer overflows in mwifiex_cmd_append_vsie_tlv() m1s5p6688
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127143452.B0CF8C4479C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=gbhat@marvell.com \
--cc=huxinming820@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=m1s5p6688@gmail.com \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.