From: "J. Bruce Fields" <bfields@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] exportfs: fix handling of rename race in reconnect_one()
Date: Mon, 27 Jan 2020 16:17:57 -0500 [thread overview]
Message-ID: <20200127211757.GA122687@pick.fieldses.org> (raw)
In-Reply-To: <CAOQ4uxhqO5DtSwAtO950oGcnWVaVG+Vcdu6TYDfUKawVNGWEiA@mail.gmail.com>
On Mon, Jan 27, 2020 at 08:38:00PM +0200, Amir Goldstein wrote:
> > > Commit 909e22e05353 ("exportfs: fix 'passing zero to ERR_PTR()'
> > > warning") changes this behavior from always returning success,
> > > regardless if dentry was reconnected by somoe other task, to always
> > > returning a failure.
> >
> > I wonder whether it might be safest to take the out_reconnected case on
> > any error, not just -ENOENT.
> >
>
> I wondered that as well, but preferred to follow the precedent.
I can live with that.
> > There's not much value in preserving the error as exportfs_decode_fh()
> > ends up turning everything into ENOMEM or ESTALE for some reason.
> >
>
> You signed up on this reason...
Hah, I forgot that one.
--b.
>
> Thanks,
> Amir.
>
> commit 09bb8bfffd29c3dffb72bc2c69a062dfb1ae624c
> Author: NeilBrown <neilb@suse.com>
> Date: Thu Aug 4 10:19:06 2016 +1000
>
> exportfs: be careful to only return expected errors.
>
> When nfsd calls fh_to_dentry, it expect ESTALE or ENOMEM as errors.
> In particular it can be tempting to return ENOENT, but this is not
> handled well by nfsd.
>
> Rather than requiring strict adherence to error code code filesystems,
> treat all unexpected error codes the same as ESTALE. This is safest.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
>
next prev parent reply other threads:[~2020-01-27 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 22:08 [PATCH] exportfs: fix handling of rename race in reconnect_one() Amir Goldstein
2020-01-27 8:04 ` Christoph Hellwig
2020-01-27 17:30 ` J. Bruce Fields
2020-01-27 18:38 ` Amir Goldstein
2020-01-27 21:17 ` J. Bruce Fields [this message]
2020-02-06 20:22 ` Amir Goldstein
2020-02-06 21:10 ` J. Bruce Fields
2020-02-06 21:45 ` Al Viro
2020-02-07 6:26 ` Amir Goldstein
2020-03-13 14:33 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127211757.GA122687@pick.fieldses.org \
--to=bfields@redhat.com \
--cc=amir73il@gmail.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.