From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] console: Avoid positive return code from unregister_console()
Date: Tue, 28 Jan 2020 13:43:32 +0900 [thread overview]
Message-ID: <20200128044332.GA115889@google.com> (raw)
In-Reply-To: <20200127114719.69114-4-andriy.shevchenko@linux.intel.com>
On (20/01/27 13:47), Andy Shevchenko wrote:
[..]
> res = _braille_unregister_console(console);
> - if (res)
> + if (res < 0)
> return res;
> + if (res > 0)
> + return 0;
>
> - res = 1;
> + res = -ENODEV;
> console_lock();
> if (console_drivers == console) {
> console_drivers=console->next;
> @@ -2838,6 +2840,9 @@ int unregister_console(struct console *console)
> if (!res && (console->flags & CON_EXTENDED))
> nr_ext_console_drivers--;
>
> + if (res && !(console->flags & CON_ENABLED))
> + res = 0;
Console is not on the console_drivers list. Why does !ENABLED case
require extra handling? What about the case when console is ENABLED
but still not registered?
I think that if the console is not on the list (was never registered)
then we can just bail out, without console_sysfs_notify(), etc. IOW,
if (res) {
console->flags &= ~CON_ENABLED; /* just in case */
console_unlock();
return res;
}
-ss
next prev parent reply other threads:[~2020-01-28 4:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 11:47 [PATCH v3 1/5] console: Don't perform test for CON_BRL flag Andy Shevchenko
2020-01-27 11:47 ` [PATCH v3 2/5] console: Drop double check for console_drivers being non-NULL Andy Shevchenko
2020-01-29 13:24 ` Petr Mladek
2020-01-27 11:47 ` [PATCH v3 3/5] console: Use for_each_console() helper in unregister_console() Andy Shevchenko
2020-01-29 14:11 ` Petr Mladek
2020-01-27 11:47 ` [PATCH v3 4/5] console: Avoid positive return code from unregister_console() Andy Shevchenko
2020-01-28 4:43 ` Sergey Senozhatsky [this message]
2020-01-28 9:22 ` Andy Shevchenko
2020-01-28 9:25 ` Sergey Senozhatsky
2020-01-28 9:37 ` Sergey Senozhatsky
2020-01-28 9:52 ` Andy Shevchenko
2020-01-30 9:04 ` Petr Mladek
2020-01-30 9:58 ` Andy Shevchenko
2020-01-30 12:22 ` Petr Mladek
2020-01-30 13:13 ` Andy Shevchenko
2020-01-27 11:47 ` [PATCH v3 5/5] console: Introduce ->exit() callback Andy Shevchenko
2020-01-28 5:17 ` Sergey Senozhatsky
2020-01-28 9:44 ` Andy Shevchenko
2020-01-29 13:41 ` Sergey Senozhatsky
2020-01-29 14:25 ` Andy Shevchenko
2020-01-29 15:12 ` Sergey Senozhatsky
2020-01-29 16:50 ` Sergey Senozhatsky
2020-01-30 13:14 ` Andy Shevchenko
2020-01-30 13:22 ` Petr Mladek
2020-01-30 13:39 ` Andy Shevchenko
2020-01-30 9:09 ` Petr Mladek
2020-01-30 10:01 ` Andy Shevchenko
2020-01-29 12:29 ` [PATCH v3 1/5] console: Don't perform test for CON_BRL flag Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128044332.GA115889@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.