From: Cornelia Huck <cohuck@redhat.com>
To: Collin Walling <walling@linux.ibm.com>
Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org, rth@twiddle.net,
qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support
Date: Tue, 28 Jan 2020 12:19:38 +0100 [thread overview]
Message-ID: <20200128121938.66898e08.cohuck@redhat.com> (raw)
In-Reply-To: <96145c69-cead-2bf8-07b3-10989121588d@linux.ibm.com>
On Mon, 27 Jan 2020 13:52:48 -0500
Collin Walling <walling@linux.ibm.com> wrote:
> On 1/27/20 1:21 PM, Collin Walling wrote:
> > On 1/27/20 12:55 PM, David Hildenbrand wrote:
> >> On 27.01.20 18:29, Cornelia Huck wrote:
> >>> On Mon, 27 Jan 2020 18:09:11 +0100
> >>> David Hildenbrand <david@redhat.com> wrote:
> >>>> ... I actually thought we have something like this already. Personally,
> >>>> I think that would make sense. At least spapr seems to have something
> >>>> like this already (hw/ppc/spapr.c:spapr_machine_init().
> >>>>
> >>>> @Conny?
> >>>
> >>> What are you referring to? I only see the one with the FIXME in front
> >>> of it...
> >>
> >> That's the one I mean. The fixme states something about qdev ... but
> >> AFAIK that's only applicable if TYPE_DEVICE is involved. So maybe right
> >> now there is no other way than registering the vmstate directly.
> >>
> >
> > Hmm okay. I'll take a look at how spapr does it. I think I've registered a
> > vmstate via register_savevm_live() in an earlier version, but had difficulties
> > figuring out where to store the data. I'll revisit this approach.
> >
> > Thanks for the feedback!
> >
>
> Err perhaps not entirely in this manner...
>
> docs/devel/migration.rst declares the register_savevm_live() function as the
> "legacy way" of doing things. I'll have to see how other VMStateDescriptions
> are modeled. I think vmstate_register() is what I want.
>
> Sorry for the confusion.
Ok, I've now read what the FIXME actually says :) Since the machine
does not inherit from device (but from object), vmstate_register()
looks like the right thing to do.
next prev parent reply other threads:[~2020-01-28 11:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 22:14 [PATCH v6 0/2] Use DIAG318 to set Control Program Name & Version Codes Collin Walling
2020-01-24 22:14 ` [PATCH v6 1/2] s390/kvm: header sync for diag318 Collin Walling
2020-01-24 22:14 ` [PATCH v6 2/2] s390: diagnose 318 info reset and migration support Collin Walling
2020-01-27 11:20 ` David Hildenbrand
2020-01-27 15:57 ` Collin Walling
2020-01-27 17:09 ` David Hildenbrand
2020-01-27 17:29 ` Cornelia Huck
2020-01-27 17:55 ` David Hildenbrand
2020-01-27 18:21 ` Collin Walling
2020-01-27 18:52 ` Collin Walling
2020-01-28 11:19 ` Cornelia Huck [this message]
2020-01-27 11:36 ` Thomas Huth
2020-01-27 15:58 ` Collin Walling
2020-01-27 11:47 ` Cornelia Huck
2020-01-27 16:39 ` Collin Walling
2020-01-27 17:35 ` Cornelia Huck
2020-01-27 23:05 ` Collin Walling
2020-01-28 11:24 ` Cornelia Huck
2020-01-28 14:38 ` Collin Walling
2020-01-28 14:37 ` Collin Walling
2020-01-28 15:08 ` Cornelia Huck
2020-01-24 22:22 ` [PATCH v6 0/2] Use DIAG318 to set Control Program Name & Version Codes no-reply
2020-03-17 21:34 ` Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128121938.66898e08.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.