From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAB8C2D0DB for ; Tue, 28 Jan 2020 14:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF3EE2468D for ; Tue, 28 Jan 2020 14:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220232; bh=2O3y5rNs+/XzlaKFUsmezUaaTbOvATbmXJRT1ambPeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PHja+E9d8wZFZMDClmZQ7qoOMiK0HPQEZKgZn2PkldQFIadh1yVZhs6XXwlI7fzlO sET5Mc345qgZ1ZYg2NmDzK5MpQ6sFK5qdwV+Feb8s+46llO5wd85TIVR+02Ga5bIsb E1rD0rGgTb0O3RZUQgkFNMB1P9W19ElgqM80isOk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727947AbgA1ODw (ORCPT ); Tue, 28 Jan 2020 09:03:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:50552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727919AbgA1ODm (ORCPT ); Tue, 28 Jan 2020 09:03:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C545924683; Tue, 28 Jan 2020 14:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220222; bh=2O3y5rNs+/XzlaKFUsmezUaaTbOvATbmXJRT1ambPeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JvI4eYBjK96I5+wswxBQ0Z2xX4PdOiFX9tT7EWeJ6i32xq3jrGbUVWHIcMenYfgwx 6DDtLs+gaxpa0WLi73ekFnvf8VSwjLySdCkBdnqikDY9CJ2AwAn9jE8syXqx/eQjYW ONFPgxdmM0XkPUILpAHf3L+OGvXferhwwZsKqf5Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Vladis Dronov , Dmitry Torokhov Subject: [PATCH 5.4 065/104] Input: sur40 - fix interface sanity checks Date: Tue, 28 Jan 2020 15:00:26 +0100 Message-Id: <20200128135826.474728670@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135817.238524998@linuxfoundation.org> References: <20200128135817.238524998@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 6b32391ed675827f8425a414abbc6fbd54ea54fe upstream. Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface. This in turn could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: bdb5c57f209c ("Input: add sur40 driver for Samsung SUR40 (aka MS Surface 2.0/Pixelsense)") Signed-off-by: Johan Hovold Acked-by: Vladis Dronov Link: https://lore.kernel.org/r/20191210113737.4016-8-johan@kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/touchscreen/sur40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/touchscreen/sur40.c @@ -653,7 +653,7 @@ static int sur40_probe(struct usb_interf int error; /* Check if we really have the right interface. */ - iface_desc = &interface->altsetting[0]; + iface_desc = interface->cur_altsetting; if (iface_desc->desc.bInterfaceClass != 0xFF) return -ENODEV;