From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6512:3aa:0:0:0:0 with SMTP id v10csp672303lfp; Tue, 28 Jan 2020 08:19:17 -0800 (PST) X-Google-Smtp-Source: APXvYqwM20DEIa1vwN7qjBH0YWxeChn87ZO0YjWtr5s1050OeE28WP1L37AQ6096FkisPobYWqXU X-Received: by 2002:a54:4707:: with SMTP id k7mr3161848oik.153.1580228357118; Tue, 28 Jan 2020 08:19:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580228357; cv=none; d=google.com; s=arc-20160816; b=sjLCTqd+e0ZRyJIPUgPAbfiVidPr96olq1VLrRDbuBLq+3pXEi38/wOALSQ5qnMvPw iVURZAau2oob/hYlBePI8vQd6Tgjs8DHnuHKOMW/I7ZLUh61B3zC8TrJw9pWRoFySd4o 2GihamfEE7AaNXtn8qS1vWf92QVipNTjvCsT9hYHYrehaDvGUV05TvxgjiGfMBQOfv5d spyo038wC+JpqI/n4n5fLvQzy1i7BefPKzmAGXYL3Aj/epeMhffBL7DJ+ajKXQa9WC9U wm9mrRtnuBEcmA/O04S4zSZlkZRodctiyofr90XcfUynvmhALLHnDS+hggAF5i42CKLk 6nHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=TvgTVseyWvXm4+yLdxqYTDHmsvugnTvv6esW8T158zQ=; b=z8tVZRxDo7ehckFTVJZ64Hpw3W9XLvKGM68OuaYNTscBvX7VzdEqT+gZqzO6NTnpRz GZGyVGYxg5y4/GkMdQrewrjKvOjPD7DgaXgriC2TjVC/L8a42amp86ahVQKE4P4YdgMm oM8QAsce0yklg0/nDMfs0LOAVzMrEACGyA+bDZfvvoK4xvBWc5gUYkjNxWOFmuwJAyM6 /73TMGdlvKNJIGrBUV5z4m0PKAGUccOIOJpmB7vC0QW3BnVsnJJlqWXftuYBVUeT9hB7 X6VUGGQTU2nkB8v8BnuiTCtp/z4fNBbhp/rnPCIcPfCMxKl+6WLqctURuo740CHPXTym wS3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZE7mdXLW; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b141si5306138oii.79.2020.01.28.08.19.16; Tue, 28 Jan 2020 08:19:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZE7mdXLW; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726192AbgA1QTP (ORCPT + 5 others); Tue, 28 Jan 2020 11:19:15 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:50444 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725881AbgA1QTP (ORCPT ); Tue, 28 Jan 2020 11:19:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580228354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TvgTVseyWvXm4+yLdxqYTDHmsvugnTvv6esW8T158zQ=; b=ZE7mdXLW1G+QDBarEF1gQPnL4P9ab9InSO3ILnWdrT64sZlg8BYsSJSCj0lJ+Z+mU66nY6 T6c7Jd5uNZsKBkSmRjaIyNqhauXIKt1oB4h6pLHpF9703nC4XXQ3vOcW5e6x35rZ29sFFi FCfzDQAnbHIfdL02vsp21cNBS5H+2ew= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-odjdjK8COimfz7FpoA3kWg-1; Tue, 28 Jan 2020 11:19:13 -0500 X-MC-Unique: odjdjK8COimfz7FpoA3kWg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24464107ACC9; Tue, 28 Jan 2020 16:19:11 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B43B5DA7E; Tue, 28 Jan 2020 16:19:05 +0000 (UTC) Date: Tue, 28 Jan 2020 17:19:03 +0100 From: Igor Mammedov To: Dongjiu Geng Cc: , , , , , , , , , , , , , , zhengxiang9@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address Message-ID: <20200128171903.7055874a@redhat.com> In-Reply-To: <20200128154110.04baa5bc@redhat.com> References: <1578483143-14905-1-git-send-email-gengdongjiu@huawei.com> <1578483143-14905-6-git-send-email-gengdongjiu@huawei.com> <20200128154110.04baa5bc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: AB+A7BTBMyCP On Tue, 28 Jan 2020 15:41:10 +0100 Igor Mammedov wrote: > On Wed, 8 Jan 2020 19:32:19 +0800 > Dongjiu Geng wrote: > > in addition to comments of others: > > > Record the GHEB address via fw_cfg file, when recording > > a error to CPER, it will use this address to find out > > Generic Error Data Entries and write the error. > > > > Make the HEST GHES to a GED device. > > It's hard to parse this even kno mine comments are not readable either, let me try again: What I've lost at the end and wanted to say is that even when one knows context it's hard to read commit message and it will definitely be unreadable when one forgets context. > Pls rephrase/make commit message more verbose, > so it would describe why and what patch is supposed to do [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C27FC2D0DB for ; Tue, 28 Jan 2020 16:20:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 249B6214AF for ; Tue, 28 Jan 2020 16:20:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZE7mdXLW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 249B6214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwTas-0000Yj-AH for qemu-devel@archiver.kernel.org; Tue, 28 Jan 2020 11:20:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49232) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwTa9-0008Tt-Mc for qemu-devel@nongnu.org; Tue, 28 Jan 2020 11:19:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwTa7-0003i0-W2 for qemu-devel@nongnu.org; Tue, 28 Jan 2020 11:19:16 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:29803 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iwTa7-0003gt-Ht for qemu-devel@nongnu.org; Tue, 28 Jan 2020 11:19:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580228354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TvgTVseyWvXm4+yLdxqYTDHmsvugnTvv6esW8T158zQ=; b=ZE7mdXLW1G+QDBarEF1gQPnL4P9ab9InSO3ILnWdrT64sZlg8BYsSJSCj0lJ+Z+mU66nY6 T6c7Jd5uNZsKBkSmRjaIyNqhauXIKt1oB4h6pLHpF9703nC4XXQ3vOcW5e6x35rZ29sFFi FCfzDQAnbHIfdL02vsp21cNBS5H+2ew= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-odjdjK8COimfz7FpoA3kWg-1; Tue, 28 Jan 2020 11:19:13 -0500 X-MC-Unique: odjdjK8COimfz7FpoA3kWg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24464107ACC9; Tue, 28 Jan 2020 16:19:11 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B43B5DA7E; Tue, 28 Jan 2020 16:19:05 +0000 (UTC) Date: Tue, 28 Jan 2020 17:19:03 +0100 From: Igor Mammedov To: Dongjiu Geng Subject: Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address Message-ID: <20200128171903.7055874a@redhat.com> In-Reply-To: <20200128154110.04baa5bc@redhat.com> References: <1578483143-14905-1-git-send-email-gengdongjiu@huawei.com> <1578483143-14905-6-git-send-email-gengdongjiu@huawei.com> <20200128154110.04baa5bc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, linuxarm@huawei.com, shannon.zhaosl@gmail.com, zhengxiang9@huawei.com, qemu-arm@nongnu.org, james.morse@arm.com, xuwei5@huawei.com, jonathan.cameron@huawei.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 28 Jan 2020 15:41:10 +0100 Igor Mammedov wrote: > On Wed, 8 Jan 2020 19:32:19 +0800 > Dongjiu Geng wrote: > > in addition to comments of others: > > > Record the GHEB address via fw_cfg file, when recording > > a error to CPER, it will use this address to find out > > Generic Error Data Entries and write the error. > > > > Make the HEST GHES to a GED device. > > It's hard to parse this even kno mine comments are not readable either, let me try again: What I've lost at the end and wanted to say is that even when one knows context it's hard to read commit message and it will definitely be unreadable when one forgets context. > Pls rephrase/make commit message more verbose, > so it would describe why and what patch is supposed to do [...]