From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net-next v1 4/4] mptcp: handle tcp fallback when using syn cookies
Date: Tue, 28 Jan 2020 20:48:12 +0100 [thread overview]
Message-ID: <20200128194812.GF795@breakpoint.cc> (raw)
In-Reply-To: cb174326-928a-4037-b366-68f9eecb52c1@tessares.net
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> On 28/01/2020 16:01, Florian Westphal wrote:
> > I decided to remove the ifdef on tcp_rsk "is_mptcp" member because
> > if (IS_ENABLED()) is easier to read than "#ifdef IS_ENABLED()/#endif" pair.
>
> I agree with you that it is easier to read but will it be OK for upstream?
> Should we use a bitfield and include 'tfo_listener' in it?
It doesn't increase struct size, so I think its OK. bitfield would be
better but not for -net, we can do this in 2 weeks when net-next opens again.
next reply other threads:[~2020-01-28 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 19:48 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-28 18:17 [MPTCP] Re: [PATCH net-next v1 4/4] mptcp: handle tcp fallback when using syn cookies Christoph Paasch
2020-01-28 16:41 Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128194812.GF795@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.