From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com,
kirill@shutemov.name, dan.j.williams@intel.com,
yang.shi@linux.alibaba.com, thellstrom@vmware.com,
richardw.yang@linux.intel.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, digetx@gmail.com
Subject: [Patch v2 4/4] mm/mremap: start addresses are properly aligned
Date: Wed, 29 Jan 2020 08:26:42 +0800 [thread overview]
Message-ID: <20200129002642.13508-5-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20200129002642.13508-1-richardw.yang@linux.intel.com>
After previous cleanup, extent is the minimal step for both source and
destination. This means when extent is HPAGE_PMD_SIZE or PMD_SIZE,
old_addr and new_addr are properly aligned too.
Since these two functions are only invoked in move_page_tables, it is
safe to remove the check now.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
mm/huge_memory.c | 3 ---
mm/mremap.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 8f1bbbf01f5b..cc98d0f07d0a 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1878,9 +1878,6 @@ bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr,
struct mm_struct *mm = vma->vm_mm;
bool force_flush = false;
- if ((old_addr & ~HPAGE_PMD_MASK) || (new_addr & ~HPAGE_PMD_MASK))
- return false;
-
/*
* The destination pmd shouldn't be established, free_pgtables()
* should have release it.
diff --git a/mm/mremap.c b/mm/mremap.c
index b2f3344d090a..7510f4e03fca 100644
--- a/mm/mremap.c
+++ b/mm/mremap.c
@@ -199,9 +199,6 @@ static bool move_normal_pmd(struct vm_area_struct *vma, unsigned long old_addr,
struct mm_struct *mm = vma->vm_mm;
pmd_t pmd;
- if ((old_addr & ~PMD_MASK) || (new_addr & ~PMD_MASK))
- return false;
-
/*
* The destination pmd shouldn't be established, free_pgtables()
* should have release it.
--
2.17.1
next prev parent reply other threads:[~2020-01-29 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 0:26 [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
2020-01-29 0:26 ` [Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd() Wei Yang
2020-01-29 0:26 ` [Patch v2 2/4] mm/mremap: it is sure to have enough space when extent meets requirement Wei Yang
2020-01-29 0:26 ` [Patch v2 3/4] mm/mremap: calculate extent in one place Wei Yang
2020-01-29 0:26 ` Wei Yang [this message]
2020-01-30 22:18 ` [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Dmitry Osipenko
2020-01-30 23:05 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129002642.13508-5-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=digetx@gmail.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=thellstrom@vmware.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.