From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yang Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() Date: Wed, 29 Jan 2020 08:28:38 +0800 Message-ID: <20200129002838.GA12835@richard> References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> <20200128004301.GD20624@richard> <20200128232907.GA11467@richard> <27b70b0c-7945-cc85-8321-d9e4b6f17865@gmail.com> Reply-To: Wei Yang Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <27b70b0c-7945-cc85-8321-d9e4b6f17865@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane-mx.org@lists.infradead.org To: Dmitry Osipenko Cc: "linux-arm-kernel@lists.infradead.org" , thellstrom@vmware.com, yang.shi@linux.alibaba.com, aneesh.kumar@linux.ibm.com, Russell King - ARM Linux , Jon Hunter , linux-mm@kvack.org, Thierry Reding , Wei Yang , "linux-tegra@vger.kernel.org" , kirill@shutemov.name, akpm@linux-foundation.org, dan.j.williams@intel.com, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org T24gV2VkLCBKYW4gMjksIDIwMjAgYXQgMDI6MzU6MjVBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+MjkuMDEuMjAyMCAwMjoyOSwgV2VpIFlhbmcg0L/QuNGI0LXRgjoKPj4gT24gVHVl LCBKYW4gMjgsIDIwMjAgYXQgMDY6NTk6NDhQTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtvIHdyb3Rl Ogo+Pj4gMjguMDEuMjAyMCAwMzo0MywgV2VpIFlhbmcg0L/QuNGI0LXRgjoKPj4+PiBPbiBTdW4s IEphbiAyNiwgMjAyMCBhdCAwNTo0Nzo1N1BNICswMzAwLCBEbWl0cnkgT3NpcGVua28gd3JvdGU6 Cj4+Pj4+IDE4LjAxLjIwMjAgMDI6MjIsIFdlaSBZYW5nINC/0LjRiNC10YI6Cj4+Pj4+PiBVc2Ug dGhlIGdlbmVyYWwgaGVscGVyIGluc3RlYWQgb2YgZG8gaXQgYnkgaGFuZC4KPj4+Pj4+Cj4+Pj4+ PiBTaWduZWQtb2ZmLWJ5OiBXZWkgWWFuZyA8cmljaGFyZHcueWFuZ0BsaW51eC5pbnRlbC5jb20+ Cj4+Pj4+PiAtLS0KPj4+Pj4+ICBtbS9tcmVtYXAuYyB8IDcgKystLS0tLQo+Pj4+Pj4gIDEgZmls ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4+Pj4+Pgo+Pj4+Pj4g ZGlmZiAtLWdpdCBhL21tL21yZW1hcC5jIGIvbW0vbXJlbWFwLmMKPj4+Pj4+IGluZGV4IGMyYWY4 YmE0YmE0My4uYTI1ODkxNGYzZWUxIDEwMDY0NAo+Pj4+Pj4gLS0tIGEvbW0vbXJlbWFwLmMKPj4+ Pj4+ICsrKyBiL21tL21yZW1hcC5jCj4+Pj4+PiBAQCAtMjUzLDExICsyNTMsOCBAQCB1bnNpZ25l ZCBsb25nIG1vdmVfcGFnZV90YWJsZXMoc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsCj4+Pj4+ PiAgCj4+Pj4+PiAgCWZvciAoOyBvbGRfYWRkciA8IG9sZF9lbmQ7IG9sZF9hZGRyICs9IGV4dGVu dCwgbmV3X2FkZHIgKz0gZXh0ZW50KSB7Cj4+Pj4+PiAgCQljb25kX3Jlc2NoZWQoKTsKPj4+Pj4+ IC0JCW5leHQgPSAob2xkX2FkZHIgKyBQTURfU0laRSkgJiBQTURfTUFTSzsKPj4+Pj4+IC0JCS8q IGV2ZW4gaWYgbmV4dCBvdmVyZmxvd2VkLCBleHRlbnQgYmVsb3cgd2lsbCBiZSBvayAqLwo+Pj4+ Pj4gKwkJbmV4dCA9IHBtZF9hZGRyX2VuZChvbGRfYWRkciwgb2xkX2VuZCk7Cj4+Pj4+PiAgCQll eHRlbnQgPSBuZXh0IC0gb2xkX2FkZHI7Cj4+Pj4+PiAtCQlpZiAoZXh0ZW50ID4gb2xkX2VuZCAt IG9sZF9hZGRyKQo+Pj4+Pj4gLQkJCWV4dGVudCA9IG9sZF9lbmQgLSBvbGRfYWRkcjsKPj4+Pj4+ ICAJCW9sZF9wbWQgPSBnZXRfb2xkX3BtZCh2bWEtPnZtX21tLCBvbGRfYWRkcik7Cj4+Pj4+PiAg CQlpZiAoIW9sZF9wbWQpCj4+Pj4+PiAgCQkJY29udGludWU7Cj4+Pj4+PiBAQCAtMzAxLDcgKzI5 OCw3IEBAIHVuc2lnbmVkIGxvbmcgbW92ZV9wYWdlX3RhYmxlcyhzdHJ1Y3Qgdm1fYXJlYV9zdHJ1 Y3QgKnZtYSwKPj4+Pj4+ICAKPj4+Pj4+ICAJCWlmIChwdGVfYWxsb2MobmV3X3ZtYS0+dm1fbW0s IG5ld19wbWQpKQo+Pj4+Pj4gIAkJCWJyZWFrOwo+Pj4+Pj4gLQkJbmV4dCA9IChuZXdfYWRkciAr IFBNRF9TSVpFKSAmIFBNRF9NQVNLOwo+Pj4+Pj4gKwkJbmV4dCA9IHBtZF9hZGRyX2VuZChuZXdf YWRkciwgbmV3X2FkZHIgKyBsZW4pOwo+Pj4+Pj4gIAkJaWYgKGV4dGVudCA+IG5leHQgLSBuZXdf YWRkcikKPj4+Pj4+ICAJCQlleHRlbnQgPSBuZXh0IC0gbmV3X2FkZHI7Cj4+Pj4+PiAgCQltb3Zl X3B0ZXModm1hLCBvbGRfcG1kLCBvbGRfYWRkciwgb2xkX2FkZHIgKyBleHRlbnQsIG5ld192bWEs Cj4+Pj4+Pgo+Pj4+Pgo+Pj4+PiBIZWxsbyBXZWksCj4+Pj4+Cj4+Pj4+IFN0YXJ0aW5nIHdpdGgg bmV4dC0yMDIwMDEyMiwgSSdtIHNlZWluZyB0aGUgZm9sbG93aW5nIGluIEtNU0cgb24gTlZJRElB Cj4+Pj4+IFRlZ3JhIChBUk0zMik6Cj4+Pj4+Cj4+Pj4+ICBCVUc6IEJhZCByc3MtY291bnRlciBz dGF0ZSBtbToocHRydmFsKSB0eXBlOk1NX0FOT05QQUdFUyB2YWw6MTkwCj4+Pj4+Cj4+Pj4KPj4+ PiBUaGFua3MuCj4+Pj4KPj4+PiBXb3VsZCB5b3UgbWluZCBsZXR0aW5nIG1lIGtub3cgd2hpY2gg Y2FzZSB5b3UgYXJlIHRlc3Rpbmc/Cj4+Pgo+Pj4gTm90aGluZyBzcGVjaWFsLCBzeXN0ZW1kIHN0 YXJ0cyB0byBmYWxsIGFwYXJ0IGR1cmluZyBib290Lgo+Pj4KPj4+PiBPciB0aGUgc3BlY2lhbCB0 aGluZyBpcyAzMi1iaXQgcGxhdGZvcm0/Cj4+PiBJIGhhdmUgYSBsaW1pdGVkIGtub3dsZWRnZSBh Ym91dCBtbS8sIHNvIGNhbid0IHByb3ZpZGUgZGV0YWlsZWQgZXhwbGFuYXRpb24uCj4+Pgo+Pj4g UGxlYXNlIHRha2UgYSBsb29rIGF0IHRoaXM6Cj4+Pgo+Pj4gWzFdCj4+PiBodHRwczovL2VsaXhp ci5ib290bGluLmNvbS9saW51eC92NS41L3NvdXJjZS9hcmNoL2FybS9pbmNsdWRlL2FzbS9wZ3Rh YmxlLTJsZXZlbC5oI0wyMTAKPj4+Cj4+PiBbMl0KPj4+IGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4u Y29tL2xpbnV4L3Y1LjUvc291cmNlL2luY2x1ZGUvYXNtLWdlbmVyaWMvcGd0YWJsZS5oI0w1NDkK Pj4+Cj4+PiBbM10KPj4+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJu ZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC9jb21taXQvP2lkPWMwYmExMGI1MTJlYjJlMmEzODg4 YjZlNmNjMGUwODlmNWU3YTE5MWIKPj4gCj4+IFRoYW5rcywgSSBzZWUgdGhlIGRpZmZlcmVuY2Ug aGVyZS4KPj4gCj4+IElmIHRoaXMgaXMgdGhlIGNhc2UsIHdlIGNhbid0IHVzZSBwbWRfYWRkcl9l bmQoKSB0byBzaW1wbGlmeSB0aGUgY2FsY3VsYXRpb24uCj4+IFRoaXMgY2hhbmdlcyB0aGUgYmVo YXZpb3IuCj4+IAo+PiBJIHdvdWxkIHByZXBhcmUgYW5vdGhlciBwYXRjaCBzZXQgdG8gZml4IHRo aXMuIFdvdWxkIHlvdSBtaW5kIGhlbHBpbmcgbWUKPj4gdmVyaWZ5IG9uIHlvdXIgcGxhdGZvcm0/ Cj4KPlN1cmUsIHBsZWFzZSBmZWVsIGZyZWUgdG8gQ0MgbWUgb24gdGhhdCBwYXRjaC4KClRoYW5r cywgeW91IGFyZSBpbiB0aGUgY2MgbGlzdCBvZiB2Mi4KCkhvcGUgdGhpcyBvbmUgd29ya3MgZmlu ZSBvbiBBUk0uCgotLSAKV2VpIFlhbmcKSGVscCB5b3UsIEhlbHAgbWUKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4796C33CB3 for ; Wed, 29 Jan 2020 00:28:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B37E92467E for ; Wed, 29 Jan 2020 00:28:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B37E92467E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 67BD76B0003; Tue, 28 Jan 2020 19:28:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62CB06B0005; Tue, 28 Jan 2020 19:28:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 569FF6B0006; Tue, 28 Jan 2020 19:28:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 40B3F6B0003 for ; Tue, 28 Jan 2020 19:28:56 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 16D2933CD for ; Wed, 29 Jan 2020 00:28:56 +0000 (UTC) X-FDA: 76428786672.27.deer70_6b06c95b17f4c X-HE-Tag: deer70_6b06c95b17f4c X-Filterd-Recvd-Size: 5179 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Jan 2020 00:28:55 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2020 16:28:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,375,1574150400"; d="scan'208";a="229456426" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 28 Jan 2020 16:28:25 -0800 Date: Wed, 29 Jan 2020 08:28:38 +0800 From: Wei Yang To: Dmitry Osipenko Cc: Wei Yang , Russell King - ARM Linux , akpm@linux-foundation.org, dan.j.williams@intel.com, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, yang.shi@linux.alibaba.com, thellstrom@vmware.com, Thierry Reding , Jon Hunter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() Message-ID: <20200129002838.GA12835@richard> Reply-To: Wei Yang References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> <20200128004301.GD20624@richard> <20200128232907.GA11467@richard> <27b70b0c-7945-cc85-8321-d9e4b6f17865@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <27b70b0c-7945-cc85-8321-d9e4b6f17865@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 29, 2020 at 02:35:25AM +0300, Dmitry Osipenko wrote: >29.01.2020 02:29, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On Tue, Jan 28, 2020 at 06:59:48PM +0300, Dmitry Osipenko wrote: >>> 28.01.2020 03:43, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> On Sun, Jan 26, 2020 at 05:47:57PM +0300, Dmitry Osipenko wrote: >>>>> 18.01.2020 02:22, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>>> Use the general helper instead of do it by hand. >>>>>> >>>>>> Signed-off-by: Wei Yang >>>>>> --- >>>>>> mm/mremap.c | 7 ++----- >>>>>> 1 file changed, 2 insertions(+), 5 deletions(-) >>>>>> >>>>>> diff --git a/mm/mremap.c b/mm/mremap.c >>>>>> index c2af8ba4ba43..a258914f3ee1 100644 >>>>>> --- a/mm/mremap.c >>>>>> +++ b/mm/mremap.c >>>>>> @@ -253,11 +253,8 @@ unsigned long move_page_tables(struct vm_area= _struct *vma, >>>>>> =20 >>>>>> for (; old_addr < old_end; old_addr +=3D extent, new_addr +=3D e= xtent) { >>>>>> cond_resched(); >>>>>> - next =3D (old_addr + PMD_SIZE) & PMD_MASK; >>>>>> - /* even if next overflowed, extent below will be ok */ >>>>>> + next =3D pmd_addr_end(old_addr, old_end); >>>>>> extent =3D next - old_addr; >>>>>> - if (extent > old_end - old_addr) >>>>>> - extent =3D old_end - old_addr; >>>>>> old_pmd =3D get_old_pmd(vma->vm_mm, old_addr); >>>>>> if (!old_pmd) >>>>>> continue; >>>>>> @@ -301,7 +298,7 @@ unsigned long move_page_tables(struct vm_area_= struct *vma, >>>>>> =20 >>>>>> if (pte_alloc(new_vma->vm_mm, new_pmd)) >>>>>> break; >>>>>> - next =3D (new_addr + PMD_SIZE) & PMD_MASK; >>>>>> + next =3D pmd_addr_end(new_addr, new_addr + len); >>>>>> if (extent > next - new_addr) >>>>>> extent =3D next - new_addr; >>>>>> move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, >>>>>> >>>>> >>>>> Hello Wei, >>>>> >>>>> Starting with next-20200122, I'm seeing the following in KMSG on NV= IDIA >>>>> Tegra (ARM32): >>>>> >>>>> BUG: Bad rss-counter state mm:(ptrval) type:MM_ANONPAGES val:190 >>>>> >>>> >>>> Thanks. >>>> >>>> Would you mind letting me know which case you are testing? >>> >>> Nothing special, systemd starts to fall apart during boot. >>> >>>> Or the special thing is 32-bit platform? >>> I have a limited knowledge about mm/, so can't provide detailed expla= nation. >>> >>> Please take a look at this: >>> >>> [1] >>> https://elixir.bootlin.com/linux/v5.5/source/arch/arm/include/asm/pgt= able-2level.h#L210 >>> >>> [2] >>> https://elixir.bootlin.com/linux/v5.5/source/include/asm-generic/pgta= ble.h#L549 >>> >>> [3] >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co= mmit/?id=3Dc0ba10b512eb2e2a3888b6e6cc0e089f5e7a191b >>=20 >> Thanks, I see the difference here. >>=20 >> If this is the case, we can't use pmd_addr_end() to simplify the calcu= lation. >> This changes the behavior. >>=20 >> I would prepare another patch set to fix this. Would you mind helping = me >> verify on your platform? > >Sure, please feel free to CC me on that patch. Thanks, you are in the cc list of v2. Hope this one works fine on ARM. --=20 Wei Yang Help you, Help me