From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C396C2D0DB for ; Wed, 29 Jan 2020 13:44:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DA6F20716 for ; Wed, 29 Jan 2020 13:44:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="6Xz9fGxd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbgA2Noy (ORCPT ); Wed, 29 Jan 2020 08:44:54 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:58016 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgA2Noy (ORCPT ); Wed, 29 Jan 2020 08:44:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1PsCyZiJNzWSh/X6Yn9bmxCT8M3pbnDTwTnNpHkX7cM=; b=6Xz9fGxdmDKu13Msi/iLjnxov/ hLcxd6ClBqLKn7mV4k8sk58YcFO/NICBEHXYqKK18NYCAHaMlm8G4VjyKR5UDcNx04QbgqVt5YXMz ZVqby5uMl+ozrWtOZqnuDZrE2sXYFVivnqYIiR6gLhn1HFxjrgkJFWAL74dZaI16doH8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1iwneB-0006em-9p; Wed, 29 Jan 2020 14:44:47 +0100 Date: Wed, 29 Jan 2020 14:44:47 +0100 From: Andrew Lunn To: "Madalin Bucur (OSS)" Cc: Vladimir Oltean , Florian Fainelli , "davem@davemloft.net" , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "ykaukab@suse.de" , Russell King - ARM Linux admin Subject: Re: [PATCH net-next 1/2] net: phy: aquantia: add rate_adaptation indication Message-ID: <20200129134447.GA25384@lunn.ch> References: <1579701573-6609-1-git-send-email-madalin.bucur@oss.nxp.com> <1579701573-6609-2-git-send-email-madalin.bucur@oss.nxp.com> <68921c8a-06b6-d5c0-e857-14e7bc2c0a94@gmail.com> <77e3ddcb-bddb-32d8-9c87-48ba9a7f2773@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > I know it is set because someone does put some work in designing a system, > in provisioning a correct firmware image. Hi Madalin That is one of the things i don't like about the aquantia PHY. It can have all sorts of magic in its firmware, but the firmware is specific to the board. Is this phydev->rate_adaptation going to be correct for any other board using an Aquantia PHY? I think at least you need to poke around in the Aquantia PHY registers and ensure this feature is actually enabled before setting this bit to true. Andrew