From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [GIT PULL] USB/Thunderbolt/PHY patches for 5.6-rc1
Date: Wed, 29 Jan 2020 19:27:25 +0100 [thread overview]
Message-ID: <20200129182725.GA13441@kozik-lap> (raw)
In-Reply-To: <CAHk-=wg67HWkPawJRFffOS25CL0tjzF7tbk-mJot9oT8siqPfg@mail.gmail.com>
On Wed, Jan 29, 2020 at 10:23:54AM -0800, Linus Torvalds wrote:
> On Wed, Jan 29, 2020 at 10:20 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > The I2C fix for this is in Wolfram's tree already:
>
> It was never an i2c error.
>
> It was an error in that commit that made a change that introduced a new warning.
>
> It is *not* acceptable to break things and say "somebody else will fix
> it up later".
>
> If it's broken in the PHY tree, then the PHY tree is broken. It's that simple.
>
> We don't enable compile testing that causes warnings.
I never said it was an I2C error but only that the fix is there already.
The error in first place was mine because I did not spot the
bisectability problem when preparing the entire set of
compile-testing patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-01-29 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 10:14 [GIT PULL] USB/Thunderbolt/PHY patches for 5.6-rc1 Greg KH
2020-01-29 18:11 ` Linus Torvalds
2020-01-29 18:20 ` Krzysztof Kozlowski
2020-01-29 18:23 ` Linus Torvalds
2020-01-29 18:27 ` Krzysztof Kozlowski [this message]
2020-01-29 19:42 ` Greg KH
2020-01-29 21:34 ` Stephen Rothwell
2020-01-30 10:52 ` Felipe Balbi
2020-01-29 19:00 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129182725.GA13441@kozik-lap \
--to=krzk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.