All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: "Tammana, Gowtham" <g-tammana@ti.com>
Cc: "meta-arago@arago-project.org" <meta-arago@arago-project.org>,
	"Pothukuchi, Vijay" <vijayp@ti.com>
Subject: Re: [thud/zeus/master][PATCH v2] recipes-graphics: Add recipe for DevIL
Date: Wed, 29 Jan 2020 18:39:26 -0500	[thread overview]
Message-ID: <20200129233926.GT3658@beryl> (raw)
In-Reply-To: <474507d858444913bf9f6424cbdcb6a8@ti.com>

On Wed, Jan 29, 2020 at 06:34:34PM -0500, Tammana, Gowtham wrote:
> 
> 
> >-----Original Message-----
> >From: Dmytriyenko, Denys
> >Sent: Wednesday, January 29, 2020 4:00 PM
> >To: Tammana, Gowtham
> >Cc: meta-arago@arago-project.org; Pothukuchi, Vijay
> >Subject: Re: [meta-arago][thud/zeus/master][PATCH v2] recipes-graphics: Add
> >recipe for DevIL
> >
> >On Wed, Jan 29, 2020 at 03:22:06PM -0600, Gowtham Tammana wrote:
> >> Developers Image Library (DevIL) is a cross-platform image utility
> >> library with simple syntax (openil.sourceforge.net). Adding recipe to
> >> build from sources.
> >
> >Thanks! Looks good now - I'll merge it. Next time please don't forget to
> >provide brief summary of changes between patch revisions after --- line.
> 
> Oops. It's an oversight from me. Will take care of it next time.

No problem - it was still fresh in my mind since we just discussed it :)


> Thanks,
> Gowtham
> 
> >
> >> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> >> ---
> >>  .../recipes-graphics/devil/devil_1.8.0.bb     | 25 +++++++++++++++++++
> >>  .../devil/files/Remove-ILUT-dependency.patch  | 13 ++++++++++
> >>  2 files changed, 38 insertions(+)
> >>  create mode 100644 meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
> >>  create mode 100644 meta-arago-extras/recipes-graphics/devil/files/Remove-
> >ILUT-dependency.patch
> >>
> >> diff --git a/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb b/meta-
> >arago-extras/recipes-graphics/devil/devil_1.8.0.bb
> >> new file mode 100644
> >> index 00000000..3502ed0c
> >> --- /dev/null
> >> +++ b/meta-arago-extras/recipes-graphics/devil/devil_1.8.0.bb
> >> @@ -0,0 +1,25 @@
> >> +SUMMARY = "DevIL cross platform image utility library"
> >> +DESCRIPTION = "Developer's Image Library (DevIL) is a cross-platform image
> >\
> >> +               library utilizing simple syntax to load, save, convert, \
> >> +               manipulate, filter and display a variety of images."
> >> +HOMEPAGE = "https://github.com/DentonW/DevIL"
> >> +LICENSE = "LGPLv2"
> >> +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
> >> +
> >> +SRC_URI = "git://github.com/dentonw/devil.git;protocol=git;branch=master \
> >> +           file://Remove-ILUT-dependency.patch"
> >> +
> >> +SRCREV = "e34284a7e07763769f671a74b4fec718174ad862"
> >> +
> >> +PR = "r1"
> >> +S = "${WORKDIR}/git"
> >> +
> >> +COMPATIBLE_MACHINE = "j7-evm"
> >> +
> >> +# Build only DevIL
> >> +OECMAKE_SOURCEPATH = "${S}/DevIL"
> >> +
> >> +PACKAGECONFIG ??= "png"
> >> +PACKAGECONFIG[png] = "-DIL_NO_PNG=0,-DIL_NO_PNG=1,libpng,"
> >> +
> >> +inherit pkgconfig cmake
> >> diff --git a/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-
> >dependency.patch b/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-
> >dependency.patch
> >> new file mode 100644
> >> index 00000000..4f0f9dfa
> >> --- /dev/null
> >> +++ b/meta-arago-extras/recipes-graphics/devil/files/Remove-ILUT-
> >dependency.patch
> >> @@ -0,0 +1,13 @@
> >> +diff --git a/DevIL/CMakeLists.txt b/DevIL/CMakeLists.txt
> >> +index e342f93d..fae40167 100644
> >> +--- a/DevIL/CMakeLists.txt
> >> ++++ b/DevIL/CMakeLists.txt
> >> +@@ -6,7 +6,7 @@ set (CMAKE_MODULE_PATH
> >"${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules")
> >> +
> >> + add_subdirectory(src-IL)
> >> + add_subdirectory(src-ILU)
> >> +-add_subdirectory(src-ILUT)
> >> ++# add_subdirectory(src-ILUT)
> >> + option(IL_TESTS "build DevIL tests" ON)
> >> + if (IL_TESTS)
> >> +     ENABLE_TESTING()
> >> --
> >> 2.25.0
> >>


      reply	other threads:[~2020-01-29 23:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 21:22 [thud/zeus/master][PATCH v2] recipes-graphics: Add recipe for DevIL Gowtham Tammana
2020-01-29 21:59 ` Denys Dmytriyenko
2020-01-29 23:34   ` Tammana, Gowtham
2020-01-29 23:39     ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129233926.GT3658@beryl \
    --to=denys@ti.com \
    --cc=g-tammana@ti.com \
    --cc=meta-arago@arago-project.org \
    --cc=vijayp@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.