From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yang Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() Date: Thu, 30 Jan 2020 09:30:00 +0800 Message-ID: <20200130013000.GA5137@richard> References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> <20200129094738.GE25745@shell.armlinux.org.uk> <20200129215745.GA20736@richard> <20200129232441.GI25745@shell.armlinux.org.uk> Reply-To: Wei Yang Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200129232441.GI25745-QEMnZ+CodIVURfEZ8mYm6t73F7V6hmMc@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Russell King - ARM Linux admin Cc: Wei Yang , Dmitry Osipenko , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, aneesh.kumar-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org, kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org, yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org, thellstrom-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org, Thierry Reding , Jon Hunter , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Wed, Jan 29, 2020 at 11:24:41PM +0000, Russell King - ARM Linux admin wrote: >On Thu, Jan 30, 2020 at 05:57:45AM +0800, Wei Yang wrote: >> On Wed, Jan 29, 2020 at 09:47:38AM +0000, Russell King - ARM Linux admin wrote: >> >On Sun, Jan 26, 2020 at 05:47:57PM +0300, Dmitry Osipenko wrote: >> >> 18.01.2020 02:22, Wei Yang пишет: >> >> > Use the general helper instead of do it by hand. >> >> > >> >> > Signed-off-by: Wei Yang >> >> > --- >> >> > mm/mremap.c | 7 ++----- >> >> > 1 file changed, 2 insertions(+), 5 deletions(-) >> >> > >> >> > diff --git a/mm/mremap.c b/mm/mremap.c >> >> > index c2af8ba4ba43..a258914f3ee1 100644 >> >> > --- a/mm/mremap.c >> >> > +++ b/mm/mremap.c >> >> > @@ -253,11 +253,8 @@ unsigned long move_page_tables(struct vm_area_struct *vma, >> >> > >> >> > for (; old_addr < old_end; old_addr += extent, new_addr += extent) { >> >> > cond_resched(); >> >> > - next = (old_addr + PMD_SIZE) & PMD_MASK; >> >> > - /* even if next overflowed, extent below will be ok */ >> >> > + next = pmd_addr_end(old_addr, old_end); >> >> > extent = next - old_addr; >> >> > - if (extent > old_end - old_addr) >> >> > - extent = old_end - old_addr; >> >> > old_pmd = get_old_pmd(vma->vm_mm, old_addr); >> >> > if (!old_pmd) >> >> > continue; >> >> > @@ -301,7 +298,7 @@ unsigned long move_page_tables(struct vm_area_struct *vma, >> >> > >> >> > if (pte_alloc(new_vma->vm_mm, new_pmd)) >> >> > break; >> >> > - next = (new_addr + PMD_SIZE) & PMD_MASK; >> >> > + next = pmd_addr_end(new_addr, new_addr + len); >> >> > if (extent > next - new_addr) >> >> > extent = next - new_addr; >> >> > move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, >> >> > >> >> >> >> Hello Wei, >> >> >> >> Starting with next-20200122, I'm seeing the following in KMSG on NVIDIA >> >> Tegra (ARM32): >> >> >> >> BUG: Bad rss-counter state mm:(ptrval) type:MM_ANONPAGES val:190 >> >> >> >> and eventually kernel hangs. >> >> >> >> Git's bisection points to this patch and reverting it helps. Please fix, >> >> thanks in advance. >> > >> >The above is definitely wrong - pXX_addr_end() are designed to be used >> >with an address index within the pXX table table and the address index >> >of either the last entry in the same pXX table or the beginning of the >> >_next_ pXX table. Arbitary end address indicies are not allowed. >> > >> >> #define pmd_addr_end(addr, end) \ >> ({ unsigned long __boundary = ((addr) + PMD_SIZE) & PMD_MASK; \ >> (__boundary - 1 < (end) - 1)? __boundary: (end); \ >> }) >> >> If my understanding is correct, the definition here align the addr to next PMD >> boundary or end. >> >> I don't see the possibility to across another PMD. Do I miss something? > >Look at the definition of p*_addr_end() that are used when page tables >are rolled up. > Sorry, I don't get your point. What's the meaning of "roll up" here? Would you mind giving me an example? I see pmd_addr_end() is not used in many places in core kernel. By glancing those usages, all the places use it like pmd_addr_end(addr, end). Seems no specially handing on the end address. Or you mean the case when pmd_addr_end() is defined to return "end" directly? >> >When page tables are "rolled up" when levels don't exist, it is common >> >practice for these macros to just return their end address index. >> >Hence, if they are used with arbitary end address indicies, then the >> >iteration will fail. >> > >> >The only way to do this is: >> > >> > next = pmd_addr_end(old_addr, >> > pud_addr_end(old_addr, >> > p4d_addr_end(old_addr, >> > pgd_addr_end(old_addr, old_end)))); >> > >> >which gives pmd_addr_end() (and each of the intermediate pXX_addr_end()) >> >the correct end argument. However, that's a more complex and verbose, >> >and likely less efficient than the current code. >> > >> >I'd suggest that there's nothing to "fix" in the v5.5 code wrt this, >> >and trying to "clean it up" will just result in less efficient or >> >broken code. >> > >> >-- >> >RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ >> >FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up >> >According to speedtest.net: 11.9Mbps down 500kbps up >> >> -- >> Wei Yang >> Help you, Help me >> > >-- >RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ >FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up >According to speedtest.net: 11.9Mbps down 500kbps up -- Wei Yang Help you, Help me From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC421C33CB2 for ; Thu, 30 Jan 2020 01:30:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71D88206F0 for ; Thu, 30 Jan 2020 01:30:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dL6/2vU8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D88206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tjSjHBbs6EbTfDaSWzXW17TFJvzzyHr7iwAkRnnCdyE=; b=dL6/2vU8RoCqCf yU+DsEzRJu1tNM7Qnb3f/TL92oQzZ8WL2B6+z7TclrXmWhpXUCwNYfDvC2HAAS7EmOML6N1uDGhER 9VAqXbE4NvRhBthWxu1WUGgubbuo1W94BUQF3vMk836D38gQ/MqqiBwbkHjDZjCqcsYygzWqer6oK /vVXXCZRf5jFBt3LW2f5KcvbcbH+RikVj+yVIAUCb/TxomZuH0DJs/Js6K+3DqPvrkWT/fScG/qtE rEFSYZkLwWLZcAfku/qlhjA0QIyJQ+hQMlJ8NvB7bRMNPLyTuCp+gRl0fSUimUoE08U34TbXyiksK kI0x0MycfRY3eAMoqNqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwyea-0005EP-Lw; Thu, 30 Jan 2020 01:29:56 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwyeX-0005E0-BV for linux-arm-kernel@lists.infradead.org; Thu, 30 Jan 2020 01:29:55 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 17:29:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,380,1574150400"; d="scan'208";a="262007116" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 29 Jan 2020 17:29:45 -0800 Date: Thu, 30 Jan 2020 09:30:00 +0800 From: Wei Yang To: Russell King - ARM Linux admin Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() Message-ID: <20200130013000.GA5137@richard> References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> <20200129094738.GE25745@shell.armlinux.org.uk> <20200129215745.GA20736@richard> <20200129232441.GI25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200129232441.GI25745@shell.armlinux.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200129_172953_406738_749415B1 X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: thellstrom@vmware.com, yang.shi@linux.alibaba.com, akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, linux-kernel@vger.kernel.org, Jon Hunter , linux-mm@kvack.org, Thierry Reding , Wei Yang , "linux-tegra@vger.kernel.org" , kirill@shutemov.name, Dmitry Osipenko , dan.j.williams@intel.com, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKYW4gMjksIDIwMjAgYXQgMTE6MjQ6NDFQTSArMDAwMCwgUnVzc2VsbCBLaW5nIC0g QVJNIExpbnV4IGFkbWluIHdyb3RlOgo+T24gVGh1LCBKYW4gMzAsIDIwMjAgYXQgMDU6NTc6NDVB TSArMDgwMCwgV2VpIFlhbmcgd3JvdGU6Cj4+IE9uIFdlZCwgSmFuIDI5LCAyMDIwIGF0IDA5OjQ3 OjM4QU0gKzAwMDAsIFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCBhZG1pbiB3cm90ZToKPj4gPk9u IFN1biwgSmFuIDI2LCAyMDIwIGF0IDA1OjQ3OjU3UE0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3 cm90ZToKPj4gPj4gMTguMDEuMjAyMCAwMjoyMiwgV2VpIFlhbmcg0L/QuNGI0LXRgjoKPj4gPj4g PiBVc2UgdGhlIGdlbmVyYWwgaGVscGVyIGluc3RlYWQgb2YgZG8gaXQgYnkgaGFuZC4KPj4gPj4g PiAKPj4gPj4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkgWWFuZyA8cmljaGFyZHcueWFuZ0BsaW51eC5p bnRlbC5jb20+Cj4+ID4+ID4gLS0tCj4+ID4+ID4gIG1tL21yZW1hcC5jIHwgNyArKy0tLS0tCj4+ ID4+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4+ ID4+ID4gCj4+ID4+ID4gZGlmZiAtLWdpdCBhL21tL21yZW1hcC5jIGIvbW0vbXJlbWFwLmMKPj4g Pj4gPiBpbmRleCBjMmFmOGJhNGJhNDMuLmEyNTg5MTRmM2VlMSAxMDA2NDQKPj4gPj4gPiAtLS0g YS9tbS9tcmVtYXAuYwo+PiA+PiA+ICsrKyBiL21tL21yZW1hcC5jCj4+ID4+ID4gQEAgLTI1Mywx MSArMjUzLDggQEAgdW5zaWduZWQgbG9uZyBtb3ZlX3BhZ2VfdGFibGVzKHN0cnVjdCB2bV9hcmVh X3N0cnVjdCAqdm1hLAo+PiA+PiA+ICAKPj4gPj4gPiAgCWZvciAoOyBvbGRfYWRkciA8IG9sZF9l bmQ7IG9sZF9hZGRyICs9IGV4dGVudCwgbmV3X2FkZHIgKz0gZXh0ZW50KSB7Cj4+ID4+ID4gIAkJ Y29uZF9yZXNjaGVkKCk7Cj4+ID4+ID4gLQkJbmV4dCA9IChvbGRfYWRkciArIFBNRF9TSVpFKSAm IFBNRF9NQVNLOwo+PiA+PiA+IC0JCS8qIGV2ZW4gaWYgbmV4dCBvdmVyZmxvd2VkLCBleHRlbnQg YmVsb3cgd2lsbCBiZSBvayAqLwo+PiA+PiA+ICsJCW5leHQgPSBwbWRfYWRkcl9lbmQob2xkX2Fk ZHIsIG9sZF9lbmQpOwo+PiA+PiA+ICAJCWV4dGVudCA9IG5leHQgLSBvbGRfYWRkcjsKPj4gPj4g PiAtCQlpZiAoZXh0ZW50ID4gb2xkX2VuZCAtIG9sZF9hZGRyKQo+PiA+PiA+IC0JCQlleHRlbnQg PSBvbGRfZW5kIC0gb2xkX2FkZHI7Cj4+ID4+ID4gIAkJb2xkX3BtZCA9IGdldF9vbGRfcG1kKHZt YS0+dm1fbW0sIG9sZF9hZGRyKTsKPj4gPj4gPiAgCQlpZiAoIW9sZF9wbWQpCj4+ID4+ID4gIAkJ CWNvbnRpbnVlOwo+PiA+PiA+IEBAIC0zMDEsNyArMjk4LDcgQEAgdW5zaWduZWQgbG9uZyBtb3Zl X3BhZ2VfdGFibGVzKHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hLAo+PiA+PiA+ICAKPj4gPj4g PiAgCQlpZiAocHRlX2FsbG9jKG5ld192bWEtPnZtX21tLCBuZXdfcG1kKSkKPj4gPj4gPiAgCQkJ YnJlYWs7Cj4+ID4+ID4gLQkJbmV4dCA9IChuZXdfYWRkciArIFBNRF9TSVpFKSAmIFBNRF9NQVNL Owo+PiA+PiA+ICsJCW5leHQgPSBwbWRfYWRkcl9lbmQobmV3X2FkZHIsIG5ld19hZGRyICsgbGVu KTsKPj4gPj4gPiAgCQlpZiAoZXh0ZW50ID4gbmV4dCAtIG5ld19hZGRyKQo+PiA+PiA+ICAJCQll eHRlbnQgPSBuZXh0IC0gbmV3X2FkZHI7Cj4+ID4+ID4gIAkJbW92ZV9wdGVzKHZtYSwgb2xkX3Bt ZCwgb2xkX2FkZHIsIG9sZF9hZGRyICsgZXh0ZW50LCBuZXdfdm1hLAo+PiA+PiA+IAo+PiA+PiAK Pj4gPj4gSGVsbG8gV2VpLAo+PiA+PiAKPj4gPj4gU3RhcnRpbmcgd2l0aCBuZXh0LTIwMjAwMTIy LCBJJ20gc2VlaW5nIHRoZSBmb2xsb3dpbmcgaW4gS01TRyBvbiBOVklESUEKPj4gPj4gVGVncmEg KEFSTTMyKToKPj4gPj4gCj4+ID4+ICAgQlVHOiBCYWQgcnNzLWNvdW50ZXIgc3RhdGUgbW06KHB0 cnZhbCkgdHlwZTpNTV9BTk9OUEFHRVMgdmFsOjE5MAo+PiA+PiAKPj4gPj4gYW5kIGV2ZW50dWFs bHkga2VybmVsIGhhbmdzLgo+PiA+PiAKPj4gPj4gR2l0J3MgYmlzZWN0aW9uIHBvaW50cyB0byB0 aGlzIHBhdGNoIGFuZCByZXZlcnRpbmcgaXQgaGVscHMuIFBsZWFzZSBmaXgsCj4+ID4+IHRoYW5r cyBpbiBhZHZhbmNlLgo+PiA+Cj4+ID5UaGUgYWJvdmUgaXMgZGVmaW5pdGVseSB3cm9uZyAtIHBY WF9hZGRyX2VuZCgpIGFyZSBkZXNpZ25lZCB0byBiZSB1c2VkCj4+ID53aXRoIGFuIGFkZHJlc3Mg aW5kZXggd2l0aGluIHRoZSBwWFggdGFibGUgdGFibGUgYW5kIHRoZSBhZGRyZXNzIGluZGV4Cj4+ ID5vZiBlaXRoZXIgdGhlIGxhc3QgZW50cnkgaW4gdGhlIHNhbWUgcFhYIHRhYmxlIG9yIHRoZSBi ZWdpbm5pbmcgb2YgdGhlCj4+ID5fbmV4dF8gcFhYIHRhYmxlLiAgQXJiaXRhcnkgZW5kIGFkZHJl c3MgaW5kaWNpZXMgYXJlIG5vdCBhbGxvd2VkLgo+PiA+Cj4+IAo+PiAjZGVmaW5lIHBtZF9hZGRy X2VuZChhZGRyLCBlbmQpCQkJCQkJXAo+PiAoewl1bnNpZ25lZCBsb25nIF9fYm91bmRhcnkgPSAo KGFkZHIpICsgUE1EX1NJWkUpICYgUE1EX01BU0s7CVwKPj4gCShfX2JvdW5kYXJ5IC0gMSA8IChl bmQpIC0gMSk/IF9fYm91bmRhcnk6IChlbmQpOwkJXAo+PiB9KQo+PiAKPj4gSWYgbXkgdW5kZXJz dGFuZGluZyBpcyBjb3JyZWN0LCB0aGUgZGVmaW5pdGlvbiBoZXJlIGFsaWduIHRoZSBhZGRyIHRv IG5leHQgUE1ECj4+IGJvdW5kYXJ5IG9yIGVuZC4KPj4gCj4+IEkgZG9uJ3Qgc2VlIHRoZSBwb3Nz aWJpbGl0eSB0byBhY3Jvc3MgYW5vdGhlciBQTUQuIERvIEkgbWlzcyBzb21ldGhpbmc/Cj4KPkxv b2sgYXQgdGhlIGRlZmluaXRpb24gb2YgcCpfYWRkcl9lbmQoKSB0aGF0IGFyZSB1c2VkIHdoZW4g cGFnZSB0YWJsZXMKPmFyZSByb2xsZWQgdXAuCj4KClNvcnJ5LCBJIGRvbid0IGdldCB5b3VyIHBv aW50LgoKV2hhdCdzIHRoZSBtZWFuaW5nIG9mICJyb2xsIHVwIiBoZXJlPwoKV291bGQgeW91IG1p bmQgZ2l2aW5nIG1lIGFuIGV4YW1wbGU/IEkgc2VlIHBtZF9hZGRyX2VuZCgpIGlzIG5vdCB1c2Vk IGluIG1hbnkKcGxhY2VzIGluIGNvcmUga2VybmVsLiBCeSBnbGFuY2luZyB0aG9zZSB1c2FnZXMs IGFsbCB0aGUgcGxhY2VzIHVzZSBpdCBsaWtlCnBtZF9hZGRyX2VuZChhZGRyLCBlbmQpLiBTZWVt cyBubyBzcGVjaWFsbHkgaGFuZGluZyBvbiB0aGUgZW5kIGFkZHJlc3MuCgpPciB5b3UgbWVhbiB0 aGUgY2FzZSB3aGVuIHBtZF9hZGRyX2VuZCgpIGlzIGRlZmluZWQgdG8gcmV0dXJuICJlbmQiIGRp cmVjdGx5PyAKCj4+ID5XaGVuIHBhZ2UgdGFibGVzIGFyZSAicm9sbGVkIHVwIiB3aGVuIGxldmVs cyBkb24ndCBleGlzdCwgaXQgaXMgY29tbW9uCj4+ID5wcmFjdGljZSBmb3IgdGhlc2UgbWFjcm9z IHRvIGp1c3QgcmV0dXJuIHRoZWlyIGVuZCBhZGRyZXNzIGluZGV4Lgo+PiA+SGVuY2UsIGlmIHRo ZXkgYXJlIHVzZWQgd2l0aCBhcmJpdGFyeSBlbmQgYWRkcmVzcyBpbmRpY2llcywgdGhlbiB0aGUK Pj4gPml0ZXJhdGlvbiB3aWxsIGZhaWwuCj4+ID4KPj4gPlRoZSBvbmx5IHdheSB0byBkbyB0aGlz IGlzOgo+PiA+Cj4+ID4JbmV4dCA9IHBtZF9hZGRyX2VuZChvbGRfYWRkciwKPj4gPgkJCXB1ZF9h ZGRyX2VuZChvbGRfYWRkciwKPj4gPgkJCQlwNGRfYWRkcl9lbmQob2xkX2FkZHIsCj4+ID4JCQkJ CXBnZF9hZGRyX2VuZChvbGRfYWRkciwgb2xkX2VuZCkpKSk7Cj4+ID4KPj4gPndoaWNoIGdpdmVz IHBtZF9hZGRyX2VuZCgpIChhbmQgZWFjaCBvZiB0aGUgaW50ZXJtZWRpYXRlIHBYWF9hZGRyX2Vu ZCgpKQo+PiA+dGhlIGNvcnJlY3QgZW5kIGFyZ3VtZW50LiAgSG93ZXZlciwgdGhhdCdzIGEgbW9y ZSBjb21wbGV4IGFuZCB2ZXJib3NlLAo+PiA+YW5kIGxpa2VseSBsZXNzIGVmZmljaWVudCB0aGFu IHRoZSBjdXJyZW50IGNvZGUuCj4+ID4KPj4gPkknZCBzdWdnZXN0IHRoYXQgdGhlcmUncyBub3Ro aW5nIHRvICJmaXgiIGluIHRoZSB2NS41IGNvZGUgd3J0IHRoaXMsCj4+ID5hbmQgdHJ5aW5nIHRv ICJjbGVhbiBpdCB1cCIgd2lsbCBqdXN0IHJlc3VsdCBpbiBsZXNzIGVmZmljaWVudCBvcgo+PiA+ YnJva2VuIGNvZGUuCj4+ID4KPj4gPi0tIAo+PiA+Uk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwczov L3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCj4+ID5GVFRDIGJyb2FkYmFu ZCBmb3IgMC44bWlsZSBsaW5lIGluIHN1YnVyYmlhOiBzeW5jIGF0IDEyLjFNYnBzIGRvd24gNjIy a2JwcyB1cAo+PiA+QWNjb3JkaW5nIHRvIHNwZWVkdGVzdC5uZXQ6IDExLjlNYnBzIGRvd24gNTAw a2JwcyB1cAo+PiAKPj4gLS0gCj4+IFdlaSBZYW5nCj4+IEhlbHAgeW91LCBIZWxwIG1lCj4+IAo+ Cj4tLSAKPlJNSydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2Rl dmVsb3Blci9wYXRjaGVzLwo+RlRUQyBicm9hZGJhbmQgZm9yIDAuOG1pbGUgbGluZSBpbiBzdWJ1 cmJpYTogc3luYyBhdCAxMi4xTWJwcyBkb3duIDYyMmticHMgdXAKPkFjY29yZGluZyB0byBzcGVl ZHRlc3QubmV0OiAxMS45TWJwcyBkb3duIDUwMGticHMgdXAKCi0tIApXZWkgWWFuZwpIZWxwIHlv dSwgSGVscCBtZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85AFEC33CB2 for ; Thu, 30 Jan 2020 01:29:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 31F07206F0 for ; Thu, 30 Jan 2020 01:29:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31F07206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 87EE16B02C3; Wed, 29 Jan 2020 20:29:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8305D6B02C4; Wed, 29 Jan 2020 20:29:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71E0E6B02C5; Wed, 29 Jan 2020 20:29:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 5A4AB6B02C3 for ; Wed, 29 Jan 2020 20:29:51 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EDDB682499B9 for ; Thu, 30 Jan 2020 01:29:50 +0000 (UTC) X-FDA: 76432568940.29.cub06_72f54dd810551 X-HE-Tag: cub06_72f54dd810551 X-Filterd-Recvd-Size: 6707 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jan 2020 01:29:49 +0000 (UTC) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 17:29:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,380,1574150400"; d="scan'208";a="262007116" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 29 Jan 2020 17:29:45 -0800 Date: Thu, 30 Jan 2020 09:30:00 +0800 From: Wei Yang To: Russell King - ARM Linux admin Cc: Wei Yang , Dmitry Osipenko , akpm@linux-foundation.org, dan.j.williams@intel.com, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, yang.shi@linux.alibaba.com, thellstrom@vmware.com, Thierry Reding , Jon Hunter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/5] mm/mremap: use pmd_addr_end to calculate next in move_page_tables() Message-ID: <20200130013000.GA5137@richard> Reply-To: Wei Yang References: <20200117232254.2792-1-richardw.yang@linux.intel.com> <20200117232254.2792-4-richardw.yang@linux.intel.com> <7147774a-14e9-4ff3-1548-4565f0d214d5@gmail.com> <20200129094738.GE25745@shell.armlinux.org.uk> <20200129215745.GA20736@richard> <20200129232441.GI25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200129232441.GI25745@shell.armlinux.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 29, 2020 at 11:24:41PM +0000, Russell King - ARM Linux admin = wrote: >On Thu, Jan 30, 2020 at 05:57:45AM +0800, Wei Yang wrote: >> On Wed, Jan 29, 2020 at 09:47:38AM +0000, Russell King - ARM Linux adm= in wrote: >> >On Sun, Jan 26, 2020 at 05:47:57PM +0300, Dmitry Osipenko wrote: >> >> 18.01.2020 02:22, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> > Use the general helper instead of do it by hand. >> >> >=20 >> >> > Signed-off-by: Wei Yang >> >> > --- >> >> > mm/mremap.c | 7 ++----- >> >> > 1 file changed, 2 insertions(+), 5 deletions(-) >> >> >=20 >> >> > diff --git a/mm/mremap.c b/mm/mremap.c >> >> > index c2af8ba4ba43..a258914f3ee1 100644 >> >> > --- a/mm/mremap.c >> >> > +++ b/mm/mremap.c >> >> > @@ -253,11 +253,8 @@ unsigned long move_page_tables(struct vm_are= a_struct *vma, >> >> > =20 >> >> > for (; old_addr < old_end; old_addr +=3D extent, new_addr +=3D = extent) { >> >> > cond_resched(); >> >> > - next =3D (old_addr + PMD_SIZE) & PMD_MASK; >> >> > - /* even if next overflowed, extent below will be ok */ >> >> > + next =3D pmd_addr_end(old_addr, old_end); >> >> > extent =3D next - old_addr; >> >> > - if (extent > old_end - old_addr) >> >> > - extent =3D old_end - old_addr; >> >> > old_pmd =3D get_old_pmd(vma->vm_mm, old_addr); >> >> > if (!old_pmd) >> >> > continue; >> >> > @@ -301,7 +298,7 @@ unsigned long move_page_tables(struct vm_area= _struct *vma, >> >> > =20 >> >> > if (pte_alloc(new_vma->vm_mm, new_pmd)) >> >> > break; >> >> > - next =3D (new_addr + PMD_SIZE) & PMD_MASK; >> >> > + next =3D pmd_addr_end(new_addr, new_addr + len); >> >> > if (extent > next - new_addr) >> >> > extent =3D next - new_addr; >> >> > move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma, >> >> >=20 >> >>=20 >> >> Hello Wei, >> >>=20 >> >> Starting with next-20200122, I'm seeing the following in KMSG on NV= IDIA >> >> Tegra (ARM32): >> >>=20 >> >> BUG: Bad rss-counter state mm:(ptrval) type:MM_ANONPAGES val:190 >> >>=20 >> >> and eventually kernel hangs. >> >>=20 >> >> Git's bisection points to this patch and reverting it helps. Please= fix, >> >> thanks in advance. >> > >> >The above is definitely wrong - pXX_addr_end() are designed to be use= d >> >with an address index within the pXX table table and the address inde= x >> >of either the last entry in the same pXX table or the beginning of th= e >> >_next_ pXX table. Arbitary end address indicies are not allowed. >> > >>=20 >> #define pmd_addr_end(addr, end) \ >> ({ unsigned long __boundary =3D ((addr) + PMD_SIZE) & PMD_MASK; \ >> (__boundary - 1 < (end) - 1)? __boundary: (end); \ >> }) >>=20 >> If my understanding is correct, the definition here align the addr to = next PMD >> boundary or end. >>=20 >> I don't see the possibility to across another PMD. Do I miss something= ? > >Look at the definition of p*_addr_end() that are used when page tables >are rolled up. > Sorry, I don't get your point. What's the meaning of "roll up" here? Would you mind giving me an example? I see pmd_addr_end() is not used in = many places in core kernel. By glancing those usages, all the places use it li= ke pmd_addr_end(addr, end). Seems no specially handing on the end address. Or you mean the case when pmd_addr_end() is defined to return "end" direc= tly?=20 >> >When page tables are "rolled up" when levels don't exist, it is commo= n >> >practice for these macros to just return their end address index. >> >Hence, if they are used with arbitary end address indicies, then the >> >iteration will fail. >> > >> >The only way to do this is: >> > >> > next =3D pmd_addr_end(old_addr, >> > pud_addr_end(old_addr, >> > p4d_addr_end(old_addr, >> > pgd_addr_end(old_addr, old_end)))); >> > >> >which gives pmd_addr_end() (and each of the intermediate pXX_addr_end= ()) >> >the correct end argument. However, that's a more complex and verbose= , >> >and likely less efficient than the current code. >> > >> >I'd suggest that there's nothing to "fix" in the v5.5 code wrt this, >> >and trying to "clean it up" will just result in less efficient or >> >broken code. >> > >> >--=20 >> >RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ >> >FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 62= 2kbps up >> >According to speedtest.net: 11.9Mbps down 500kbps up >>=20 >> --=20 >> Wei Yang >> Help you, Help me >>=20 > >--=20 >RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ >FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kb= ps up >According to speedtest.net: 11.9Mbps down 500kbps up --=20 Wei Yang Help you, Help me