From: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
To: johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: [PATCH V3 2/6] USB: serial: f81232: Add tx_empty function
Date: Thu, 30 Jan 2020 13:47:48 +0800 [thread overview]
Message-ID: <20200130054752.9368-3-hpeter+linux_kernel@gmail.com> (raw)
In-Reply-To: <20200130054752.9368-1-hpeter+linux_kernel@gmail.com>
Add tx_empty() function for F81232. Without this, console redirection will
get garbage data.
Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
---
Changelog:
v3:
1. Modify return true when accessing device with error.
v2:
1: Change check tx empty from UART_LSR_TEMT | UART_LSR_THRE to
UART_LSR_TEMT only.
drivers/usb/serial/f81232.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index c07d376c743d..793d0b30e347 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -685,6 +685,20 @@ static void f81232_dtr_rts(struct usb_serial_port *port, int on)
f81232_set_mctrl(port, 0, TIOCM_DTR | TIOCM_RTS);
}
+static bool f81232_tx_empty(struct usb_serial_port *port)
+{
+ int status;
+ u8 tmp;
+
+ status = f81232_get_register(port, LINE_STATUS_REGISTER, &tmp);
+ if (!status) {
+ if ((tmp & UART_LSR_TEMT) != UART_LSR_TEMT)
+ return false;
+ }
+
+ return true;
+}
+
static int f81232_carrier_raised(struct usb_serial_port *port)
{
u8 msr;
@@ -820,6 +834,7 @@ static struct usb_serial_driver f81232_device = {
.tiocmget = f81232_tiocmget,
.tiocmset = f81232_tiocmset,
.tiocmiwait = usb_serial_generic_tiocmiwait,
+ .tx_empty = f81232_tx_empty,
.process_read_urb = f81232_process_read_urb,
.read_int_callback = f81232_read_int_callback,
.port_probe = f81232_port_probe,
--
2.17.1
next prev parent reply other threads:[~2020-01-30 5:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 5:47 [PATCH V3 0/6] Add Fintek F81534A series usb-to-serial driver Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` [PATCH V3 1/6] USB: serial: f81232: Extract LSR handler Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` Ji-Ze Hong (Peter Hong) [this message]
2020-01-30 5:47 ` [PATCH V3 3/6] USB: serial: f81232: Use devm_kzalloc Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` [PATCH V3 4/6] USB: serial: f81232: Add F81534A support Ji-Ze Hong (Peter Hong)
2020-02-25 11:13 ` Johan Hovold
2020-01-30 5:47 ` [PATCH V3 5/6] USB: serial: f81232: Set F81534A serial port with RS232 mode Ji-Ze Hong (Peter Hong)
2020-01-30 5:47 ` [PATCH V3 6/6] USB: serial: f81232: Add generator for F81534A Ji-Ze Hong (Peter Hong)
2020-02-25 11:23 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130054752.9368-3-hpeter+linux_kernel@gmail.com \
--to=hpeter@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.