All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Richard Dodd <richard.o.dodd@gmail.com>
Cc: Oliver Neukum <oneukum@suse.com>, linux-usb@vger.kernel.org
Subject: Re: Usb midi device does not work on wake
Date: Thu, 30 Jan 2020 07:34:03 +0100	[thread overview]
Message-ID: <20200130063403.GB628384@kroah.com> (raw)
In-Reply-To: <CAAWug1eZiDgMGH9qDi=_Cj_=-HU2icVpNCzeaRYJLzQBChJDJA@mail.gmail.com>

On Wed, Jan 29, 2020 at 03:47:29PM +0000, Richard Dodd wrote:
> On Mon, Jan 13, 2020 at 9:40 AM Oliver Neukum <oneukum@suse.com> wrote:
> >
> > Am Sonntag, den 12.01.2020, 12:06 +0000 schrieb Richard Dodd:
> > > Hello
> > >
> > > I've got a Novation midi-over-usb device (LaunchControl XL) that works
> > > correctly on boot, but remains in power-off mode when waking from
> > > sleep.
> > >
> > > I suspect that there is some sort of initialisation that needs to be
> > > applied. Could anyone suggest possible causes, or point me in the
> > > direction of the relevant source code. I found `sound/usb/quirks.c`,
> > > which seems to be the place to handle this kind of thing, but there is
> > > no mention of my device anywhere in the source tree at present
> > > (1235:0061).
> >
> > Hi,
> >
> > some devices need an additional reset. They have the quirk RESET_RESUME
> > in that file. Try adding your device to that list and recompile your
> > kernel.
> >
> >         HTH
> >                 Oliver
> >
> 
> Hi
> 
> I found the list you are talking about in `drivers/usb/core/quirks.c`,
> and when I patched it, my device correctly woke up after suspend. :)
> 
> Can I upstream the patch by posting it here. The patch is attached to
> this email.

Can you please resend this in the format described in the documentation
so that we can apply it to the tree?

thanks,

greg k-h

  reply	other threads:[~2020-01-30  6:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-12 12:06 Usb midi device does not work on wake Richard Dodd
2020-01-13  9:23 ` Oliver Neukum
2020-01-29 15:47   ` Richard Dodd
2020-01-30  6:34     ` Greg KH [this message]
2020-01-30 16:58       ` Richard Dodd
2020-01-30 17:33         ` Greg KH
     [not found]           ` <CAAWug1d7u1bGhkyYRbEk1g4a3oMPgxCrppeTPtjLT-uuHhf83g@mail.gmail.com>
2020-01-31 21:40             ` Greg KH
2020-02-12 14:22               ` [PATCH] USB: Fix novation SourceControl XL after suspend richard.o.dodd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200130063403.GB628384@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=richard.o.dodd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.