From: Wolfram Sang <wsa@the-dreams.de>
To: shubhrajyoti.datta@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
michal.simek@xilinx.com,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
Shubhrajyoti Datta <shubhraj@xilinx.com>
Subject: Re: [PATCH 3/4] i2c: cadence: Implement save restore
Date: Thu, 30 Jan 2020 09:21:01 +0100 [thread overview]
Message-ID: <20200130082101.GE2208@ninjato> (raw)
In-Reply-To: <1575888052-20447-3-git-send-email-shubhrajyoti.datta@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Mon, Dec 09, 2019 at 04:10:51PM +0530, shubhrajyoti.datta@gmail.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> Implement save restore for i2c module.
> Since we have only a couple of registers
> an unconditional restore is done.
The patch description misses an explanation *why* this is needed. From a
distance looks like a bugfix, so a Fixes tag may be needed, too.
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
This is messy. Ack + SoB from Michal. Two xilinx-SoBs from you. Please
fix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-30 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 10:40 [PATCH 1/4] i2c: cadence: Fix error printing in case of defer shubhrajyoti.datta
2019-12-09 10:40 ` [PATCH 2/4] i2c: cadence: Fix power management order of operations shubhrajyoti.datta
2020-01-30 8:16 ` Wolfram Sang
2019-12-09 10:40 ` [PATCH 3/4] i2c: cadence: Implement save restore shubhrajyoti.datta
2020-01-30 8:21 ` Wolfram Sang [this message]
2019-12-09 10:40 ` [PATCH 4/4] i2c: cadence: Recover bus after controller reset shubhrajyoti.datta
2020-01-30 8:14 ` [PATCH 1/4] i2c: cadence: Fix error printing in case of defer Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130082101.GE2208@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhraj@xilinx.com \
--cc=shubhrajyoti.datta@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.